projjal commented on pull request #5947:
URL: https://github.com/apache/arrow/pull/5947#issuecomment-629051199
ping @praveenbingo
This is an automated message from the Apache Git Service.
To respond to the message, please lo
emkornfield commented on pull request #7188:
URL: https://github.com/apache/arrow/pull/7188#issuecomment-629047852
master should be fixed now.
This is an automated message from the Apache Git Service.
To respond to the messag
emkornfield closed pull request #7190:
URL: https://github.com/apache/arrow/pull/7190
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
github-actions[bot] commented on pull request #7190:
URL: https://github.com/apache/arrow/pull/7190#issuecomment-629040671
https://issues.apache.org/jira/browse/ARROW-8811
This is an automated message from the Apache Git Serv
emkornfield opened a new pull request #7190:
URL: https://github.com/apache/arrow/pull/7190
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above t
emkornfield commented on pull request #7188:
URL: https://github.com/apache/arrow/pull/7188#issuecomment-629032828
No it looks like a broke some things merging PRs
This is an automated message from the Apache Git Service.
To
emkornfield commented on pull request #6725:
URL: https://github.com/apache/arrow/pull/6725#issuecomment-629031230
ping @sbinet do you think you will have time to take a look?
This is an automated message from the Apache Git
emkornfield commented on pull request #5947:
URL: https://github.com/apache/arrow/pull/5947#issuecomment-629030755
@praveenbingo @projjal ?
This is an automated message from the Apache Git Service.
To respond to the message,
emkornfield commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r425569039
##
File path: java/dataset/src/test/resources/avroschema/user.avsc
##
@@ -0,0 +1,26 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under on
emkornfield commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r425568786
##
File path:
java/dataset/src/test/java/org/apache/arrow/dataset/file/TestSingleFileDataset.java
##
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apache S
emkornfield commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r425568045
##
File path:
java/dataset/src/test/java/org/apache/arrow/dataset/file/TestSingleFileDataset.java
##
@@ -0,0 +1,237 @@
+/*
+ * Licensed to the Apache S
emkornfield commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r425567714
##
File path:
java/dataset/src/test/java/org/apache/arrow/dataset/file/TestSingleFileDatasetFactory.java
##
@@ -0,0 +1,36 @@
+/*
+ * Licensed to the Ap
emkornfield commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r425565876
##
File path:
java/dataset/src/main/java/org/apache/arrow/memory/NativeUnderlingMemory.java
##
@@ -0,0 +1,65 @@
+/*
+ * Licensed to the Apache Software
emkornfield commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r425565612
##
File path:
java/dataset/src/main/java/org/apache/arrow/dataset/source/DatasetFactory.java
##
@@ -0,0 +1,51 @@
+/*
+ * Licensed to the Apache Softwar
emkornfield commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r425565223
##
File path:
java/dataset/src/main/java/org/apache/arrow/dataset/jni/NativeScanTask.java
##
@@ -0,0 +1,110 @@
+/*
+ * Licensed to the Apache Software
emkornfield commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r425564595
##
File path:
java/dataset/src/main/java/org/apache/arrow/dataset/jni/NativeDataset.java
##
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Fo
emkornfield commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r425564123
##
File path:
java/dataset/src/main/java/org/apache/arrow/dataset/file/JniWrapper.java
##
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foun
emkornfield commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r425563920
##
File path: cpp/src/jni/dataset/proto/Types.proto
##
@@ -0,0 +1,149 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more cont
rongma1997 commented on pull request #7188:
URL: https://github.com/apache/arrow/pull/7188#issuecomment-629023063
> Thanks for the PR @rongma1997.
>
> I'm not clear if the failure in ORC is caused by this change. could you
try rebasing?
>
> I'm also not sure how I feel about m
emkornfield closed pull request #5719:
URL: https://github.com/apache/arrow/pull/5719
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
emkornfield commented on pull request #5719:
URL: https://github.com/apache/arrow/pull/5719#issuecomment-629022641
Closing due to inactivity, I think the write path is still of interest but
with integration of datasets the read path is probably less relevant?
-
emkornfield commented on pull request #6925:
URL: https://github.com/apache/arrow/pull/6925#issuecomment-629021225
@projjal @praveenbingo @pravindra do any of you have time to look at this?
This is an automated message from t
emkornfield closed pull request #6672:
URL: https://github.com/apache/arrow/pull/6672
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
emkornfield commented on pull request #6811:
URL: https://github.com/apache/arrow/pull/6811#issuecomment-629018243
@pitrou was there ever consensus on this, I think we wanted something even
if it wasn't black?
This is an aut
emkornfield closed pull request #6956:
URL: https://github.com/apache/arrow/pull/6956
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
emkornfield closed pull request #6608:
URL: https://github.com/apache/arrow/pull/6608
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
emkornfield commented on pull request #6608:
URL: https://github.com/apache/arrow/pull/6608#issuecomment-629017382
+1 thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
emkornfield commented on pull request #6433:
URL: https://github.com/apache/arrow/pull/6433#issuecomment-629017180
@jacques-n are you happy with the test coverage? Any other issues?
This is an automated message from the Apac
emkornfield commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-629016911
@BryanCutler @siddharthteotia I think I'm OK merging if this is you are
happy with the code and following up on integation tests as part of ARROW-6110?
What do you two think?
emkornfield commented on pull request #6402:
URL: https://github.com/apache/arrow/pull/6402#issuecomment-629016512
@siddharthteotia could you take another look at this to see if it is
mergeable?
This is an automated message
emkornfield commented on pull request #6156:
URL: https://github.com/apache/arrow/pull/6156#issuecomment-629016291
@praveenbingo did you have a chance to investigate?
This is an automated message from the Apache Git Service.
github-actions[bot] commented on pull request #7189:
URL: https://github.com/apache/arrow/pull/7189#issuecomment-629016109
https://issues.apache.org/jira/browse/ARROW-8795
This is an automated message from the Apache Git Serv
emkornfield closed pull request #6464:
URL: https://github.com/apache/arrow/pull/6464
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
emkornfield closed pull request #6912:
URL: https://github.com/apache/arrow/pull/6912
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
ilijapuaca opened a new pull request #7189:
URL: https://github.com/apache/arrow/pull/7189
Per suggestion from
[JIRA](https://issues.apache.org/jira/browse/ARROW-8795), opening up a pull
request to potentially get the ball rolling on having iOS as one of the
supported platforms.
Pe
emkornfield commented on pull request #6622:
URL: https://github.com/apache/arrow/pull/6622#issuecomment-629014393
@liyafan82 sorry for the delay would you mind rebasing once more? I'll
merge later tonight if I'm online or first thing tomorrow, so you won't need to
do it again.
emkornfield commented on pull request #6912:
URL: https://github.com/apache/arrow/pull/6912#issuecomment-629014048
+1 thank you @tianchen92
This is an automated message from the Apache Git Service.
To respond to the message,
emkornfield commented on a change in pull request #6956:
URL: https://github.com/apache/arrow/pull/6956#discussion_r425554221
##
File path:
java/memory/src/test/java/org/apache/arrow/memory/TestUnsafeAllocationManager.java
##
@@ -0,0 +1,70 @@
+/*
+ * Licensed to the Apache Sof
emkornfield commented on pull request #7100:
URL: https://github.com/apache/arrow/pull/7100#issuecomment-629012519
@rymurr could you add a section to the Readme with the maven command to run
integration tests? Otherwise I think this should be mergeable. @kszucs do the
machines the nightl
emkornfield closed pull request #7095:
URL: https://github.com/apache/arrow/pull/7095
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
emkornfield commented on a change in pull request #7101:
URL: https://github.com/apache/arrow/pull/7101#discussion_r425552223
##
File path:
java/memory/src/main/java/org/apache/arrow/memory/util/hash/SimpleHasher.java
##
@@ -58,21 +56,21 @@ public int hashCode(long address, lo
emkornfield commented on pull request #7095:
URL: https://github.com/apache/arrow/pull/7095#issuecomment-629011438
Thanks @rymurr
This is an automated message from the Apache Git Service.
To respond to the message, please lo
emkornfield commented on pull request #7188:
URL: https://github.com/apache/arrow/pull/7188#issuecomment-629010817
Thanks for the PR @rongma1997.
I'm not clear if the failure in ORC is caused by this change. could you try
rebasing?
I'm also not sure how I feel about moving
emkornfield closed pull request #7012:
URL: https://github.com/apache/arrow/pull/7012
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
emkornfield commented on pull request #7012:
URL: https://github.com/apache/arrow/pull/7012#issuecomment-629009816
+1 thanks.
This is an automated message from the Apache Git Service.
To respond to the message, please log on
wesm commented on pull request #7178:
URL: https://github.com/apache/arrow/pull/7178#issuecomment-629007132
The rebase headache of this should not be good bad, FWIW. Working furiously
to refactor things...
This is an autom
wesm edited a comment on pull request #7178:
URL: https://github.com/apache/arrow/pull/7178#issuecomment-629007132
The rebase headache of this should not be too bad, FWIW. Working furiously
to refactor things...
This is an
nealrichardson closed pull request #7132:
URL: https://github.com/apache/arrow/pull/7132
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
nealrichardson closed pull request #7185:
URL: https://github.com/apache/arrow/pull/7185
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
github-actions[bot] commented on pull request #7188:
URL: https://github.com/apache/arrow/pull/7188#issuecomment-628999094
https://issues.apache.org/jira/browse/ARROW-8803
This is an automated message from the Apache Git Serv
rongma1997 opened a new pull request #7188:
URL: https://github.com/apache/arrow/pull/7188
In my use case, I need to read RecordBatch with **compressed** underlying
buffers using Java's IPC API, and I'm finally blocked by the VectorLoader's
"load" method. In this method,
root.se
nealrichardson closed pull request #7183:
URL: https://github.com/apache/arrow/pull/7183
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
github-actions[bot] commented on pull request #7184:
URL: https://github.com/apache/arrow/pull/7184#issuecomment-628997678
Revision: 0e7c2c4d7d79fe53188a71f130cefee4a7c541d6
Submitted crossbow builds: [ursa-labs/crossbow @
actions-261](https://github.com/ursa-labs/crossbow/branches/a
nealrichardson commented on pull request #7184:
URL: https://github.com/apache/arrow/pull/7184#issuecomment-628997326
@github-actions crossbow submit *autobrew
This is an automated message from the Apache Git Service.
To resp
github-actions[bot] commented on pull request #7170:
URL: https://github.com/apache/arrow/pull/7170#issuecomment-628995011
Revision: c238e6279587b8024e53cff4bd20f21c95651a83
Submitted crossbow builds: [ursa-labs/crossbow @
actions-260](https://github.com/ursa-labs/crossbow/branches/a
nealrichardson commented on pull request #7170:
URL: https://github.com/apache/arrow/pull/7170#issuecomment-628994602
@github-actions crossbow submit verify-rc-wheel* verify-rc-binaries*
This is an automated message from the
fsaintjacques closed pull request #7135:
URL: https://github.com/apache/arrow/pull/7135
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
ursabot commented on pull request #7135:
URL: https://github.com/apache/arrow/pull/7135#issuecomment-628980113
[AMD64 Ubuntu 18.04 C++ Benchmark
(#105803)](https://ci.ursalabs.org/#builders/73/builds/64) builder has been
succeeded.
Revision: 9db5af011291f3ca8e0aa888f5387f0a6c7dcfc2
fsaintjacques commented on pull request #7135:
URL: https://github.com/apache/arrow/pull/7135#issuecomment-628976390
@ursabot benchmark --suite-filter=arrow-bit-util-benchmark
--benchmark-filter=BenchmarkBitmapAnd
This is an
fsaintjacques commented on pull request #7135:
URL: https://github.com/apache/arrow/pull/7135#issuecomment-628970734
Yes, that's what I'm looking into. Anyhow, this is a very nice improvement,
good job @cyb70289.
This is an
cyb70289 commented on pull request #7135:
URL: https://github.com/apache/arrow/pull/7135#issuecomment-628970238
> I'm surprised by the results of buildbot, it shows almost no improvement.
On my desktop with clang-10 and gcc-9, the old version is roughly 50m/sec and
the new version is aroun
fsaintjacques commented on pull request #7135:
URL: https://github.com/apache/arrow/pull/7135#issuecomment-628968358
I'm surprised by the results of buildbot, it shows almost no improvement. On
my desktop with clang-10 and gcc-9, the old version is roughly 50m/sec and the
new version is ar
github-actions[bot] commented on pull request #7187:
URL: https://github.com/apache/arrow/pull/7187#issuecomment-628964680
https://issues.apache.org/jira/browse/ARROW-8809
This is an automated message from the Apache Git Serv
bkietz closed pull request #7099:
URL: https://github.com/apache/arrow/pull/7099
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
andygrove commented on pull request #7187:
URL: https://github.com/apache/arrow/pull/7187#issuecomment-628961023
cc @pauldix
This is an automated message from the Apache Git Service.
To respond to the message, please log
andygrove opened a new pull request #7187:
URL: https://github.com/apache/arrow/pull/7187
Fix JSON schema bug exposed by integration tests
This is an automated message from the Apache Git Service.
To respond to the message, p
github-actions[bot] commented on pull request #7186:
URL: https://github.com/apache/arrow/pull/7186#issuecomment-628948880
https://issues.apache.org/jira/browse/ARROW-8808
This is an automated message from the Apache Git Serv
andygrove opened a new pull request #7186:
URL: https://github.com/apache/arrow/pull/7186
Fix divide by zero error in one of the builders. This bug was exposed by the
integration tests.
This is an automated message from the
wesm commented on pull request #7135:
URL: https://github.com/apache/arrow/pull/7135#issuecomment-628945753
Cool. We really ought to show the times in more readable units (microseconds)
This is an automated message from the A
andygrove commented on a change in pull request #7064:
URL: https://github.com/apache/arrow/pull/7064#discussion_r425486631
##
File path: dev/archery/archery/integration/runner.py
##
@@ -303,7 +304,7 @@ def get_static_json_files():
def run_all_tests(with_cpp=True, with_jav
github-actions[bot] commented on pull request #7185:
URL: https://github.com/apache/arrow/pull/7185#issuecomment-628930783
https://issues.apache.org/jira/browse/ARROW-8615
This is an automated message from the Apache Git Serv
ursabot commented on pull request #7135:
URL: https://github.com/apache/arrow/pull/7135#issuecomment-628930884
[AMD64 Ubuntu 18.04 C++ Benchmark
(#105789)](https://ci.ursalabs.org/#builders/73/builds/63) builder has been
succeeded.
Revision: 4d43fbee975c260be0c3a572a786f5fc8c086951
nealrichardson opened a new pull request #7185:
URL: https://github.com/apache/arrow/pull/7185
This also closes a gap in FeatherReader$create where a file connection could
be opened but not returned to the user for closing.
fsaintjacques commented on pull request #7135:
URL: https://github.com/apache/arrow/pull/7135#issuecomment-628923180
@ursabot benchmark --suite-filter=arrow-bit-util-benchmark
This is an automated message from the Apache Git
ursabot commented on pull request #7135:
URL: https://github.com/apache/arrow/pull/7135#issuecomment-628922964
```
Usage: @ursabot [OPTIONS] COMMAND [ARGS]...
Ursabot
Options:
--help Show this message and exit.
Commands:
benchmark Run the benchmark suite
fsaintjacques commented on pull request #7135:
URL: https://github.com/apache/arrow/pull/7135#issuecomment-628923053
@ursabot benchmark --help
This is an automated message from the Apache Git Service.
To respond to the messag
ursabot commented on pull request #7135:
URL: https://github.com/apache/arrow/pull/7135#issuecomment-628923055
```
Usage: @ursabot benchmark [OPTIONS] []
Run the benchmark suite in comparison mode.
This command will run the benchmark suite for tip of the branch commit
fsaintjacques commented on pull request #7135:
URL: https://github.com/apache/arrow/pull/7135#issuecomment-628922958
@ursabot --help
This is an automated message from the Apache Git Service.
To respond to the message, please
andygrove commented on pull request #7064:
URL: https://github.com/apache/arrow/pull/7064#issuecomment-628922079
@pauldix ok, that other PR is merged. My next step is to get the integration
tests running locally and then I can hopefully contribute more to this effort.
andygrove closed pull request #7167:
URL: https://github.com/apache/arrow/pull/7167
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
andygrove closed pull request #7168:
URL: https://github.com/apache/arrow/pull/7168
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
fsaintjacques commented on pull request #7135:
URL: https://github.com/apache/arrow/pull/7135#issuecomment-628920728
The aligned version is auto-vectorized.
This is an automated message from the Apache Git Service.
To respond
github-actions[bot] commented on pull request #7184:
URL: https://github.com/apache/arrow/pull/7184#issuecomment-628914708
https://issues.apache.org/jira/browse/ARROW-8734
This is an automated message from the Apache Git Serv
nealrichardson opened a new pull request #7184:
URL: https://github.com/apache/arrow/pull/7184
Among the changes here:
* `install_arrow(binary=TRUE)` (default) will not prompt the user whether
they want to install a newer version from source
* If a `brew` formula is included in `r
kou closed pull request #7177:
URL: https://github.com/apache/arrow/pull/7177
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
andygrove commented on a change in pull request #7167:
URL: https://github.com/apache/arrow/pull/7167#discussion_r425450524
##
File path: rust/datafusion/src/execution/context.rs
##
@@ -233,11 +233,12 @@ impl ExecutionContext {
pub fn table(&mut self, table_name: &str) ->
github-actions[bot] commented on pull request #7183:
URL: https://github.com/apache/arrow/pull/7183#issuecomment-628897602
https://issues.apache.org/jira/browse/ARROW-8586
This is an automated message from the Apache Git Serv
nealrichardson commented on a change in pull request #7183:
URL: https://github.com/apache/arrow/pull/7183#discussion_r425440850
##
File path: r/tools/linuxlibs.R
##
@@ -80,45 +80,103 @@ identify_os <- function(os = Sys.getenv("LIBARROW_BINARY",
Sys.getenv("LIBARROW_
retu
nealrichardson opened a new pull request #7183:
URL: https://github.com/apache/arrow/pull/7183
This resolves some of the issues reported in the JIRA:
* The centos-7 binary is now correctly identified if the lsb_release command
is installed
* A note is added explaining how to work
kou closed pull request #7161:
URL: https://github.com/apache/arrow/pull/7161
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
github-actions[bot] commented on pull request #7161:
URL: https://github.com/apache/arrow/pull/7161#issuecomment-628891143
https://issues.apache.org/jira/browse/ARROW-8778
This is an automated message from the Apache Git Serv
jorisvandenbossche edited a comment on pull request #6303:
URL: https://github.com/apache/arrow/pull/6303#issuecomment-621937113
This is an automated message from the Apache Git Service.
To respond to the message, please log o
wesm commented on pull request #7135:
URL: https://github.com/apache/arrow/pull/7135#issuecomment-628875060
@fsaintjacques @pitrou any more review needed on this or can it be merged?
Should the aligned case be optimized to use word-wise operations? If so we
should open a JIRA issue a
nealrichardson closed pull request #7182:
URL: https://github.com/apache/arrow/pull/7182
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to g
kou closed pull request #7171:
URL: https://github.com/apache/arrow/pull/7171
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
bkietz commented on pull request #7181:
URL: https://github.com/apache/arrow/pull/7181#issuecomment-628867690
CI failure is a minio flake
https://github.com/apache/arrow/pull/7181/checks?check_run_id=675715164#step:8:3095
Th
kou commented on a change in pull request #7171:
URL: https://github.com/apache/arrow/pull/7171#discussion_r425407869
##
File path: .travis.yml
##
@@ -92,6 +95,9 @@ script:
-e ARROW_PARQUET=${ARROW_PARQUET:-ON} \
-e PARQUET_BUILD_EXAMPLES=${PARQUET_BUILD_EXAMPLES:
github-actions[bot] commented on pull request #7182:
URL: https://github.com/apache/arrow/pull/7182#issuecomment-628857862
https://issues.apache.org/jira/browse/ARROW-8804
This is an automated message from the Apache Git Serv
nealrichardson opened a new pull request #7182:
URL: https://github.com/apache/arrow/pull/7182
In https://github.com/ursa-labs/arrow-r-nightly/pull/10 I discovered some
ways to simplify the GHA workflow, and I also needed to tweak the build script
so that it could be run twice in the same
paddyhoran closed pull request #7140:
URL: https://github.com/apache/arrow/pull/7140
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
1 - 100 of 152 matches
Mail list logo
