[GitHub] [arrow] sunchao commented on pull request #6770: ARROW-7842: [Rust] [Parquet] implement array_reader for list type columns

2020-05-15 Thread GitBox
sunchao commented on pull request #6770: URL: https://github.com/apache/arrow/pull/6770#issuecomment-629593692 @maxburke yes was looking at this but the change was bigger than I expected and I was not able to finish it. Still looking.

[GitHub] [arrow] sunchao commented on pull request #6898: ARROW-8399: [Rust] Extend memory alignments to include other architectures

2020-05-15 Thread GitBox
sunchao commented on pull request #6898: URL: https://github.com/apache/arrow/pull/6898#issuecomment-629593291 Build errors: ``` error: unnecessary parentheses around assigned value --> arrow\src\memory.rs:43:30 | 43 | pub const ALIGNMENT: usize = (1 << 7); |

[GitHub] [arrow] sunchao commented on pull request #7061: ARROW-8629: [Rust] Eliminate indirection of zero sized allocations

2020-05-15 Thread GitBox
sunchao commented on pull request #7061: URL: https://github.com/apache/arrow/pull/7061#issuecomment-629593043 @vertexclique hmm I'm seeing multiple tests failing: ``` ipc::reader::tests::read_generated_streams stdout thread

[GitHub] [arrow] github-actions[bot] commented on pull request #7199: ARROW-8820: fix date_trunc functions to return date types

2020-05-15 Thread GitBox
github-actions[bot] commented on pull request #7199: URL: https://github.com/apache/arrow/pull/7199#issuecomment-629592927 https://issues.apache.org/jira/browse/ARROW-8820 This is an automated message from the Apache Git

[GitHub] [arrow] pprudhvi opened a new pull request #7199: ARROW-8820: fix date_trunc functions to return date types

2020-05-15 Thread GitBox
pprudhvi opened a new pull request #7199: URL: https://github.com/apache/arrow/pull/7199 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] emkornfield commented on pull request #7181: ARROW-8799: [C++][Parquet] NestedListReader needs to handle empty item batches

2020-05-15 Thread GitBox
emkornfield commented on pull request #7181: URL: https://github.com/apache/arrow/pull/7181#issuecomment-629590380 @bkietz could you add a unit test? This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] emkornfield closed pull request #6622: ARROW-8121: [Java] Enhance code style checking for Java code (add spaces after commas, semi-colons and type casts)

2020-05-15 Thread GitBox
emkornfield closed pull request #6622: URL: https://github.com/apache/arrow/pull/6622 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] eerhardt commented on pull request #7158: ARROW-8788: [C#] Introduce bit-packed builder for null support in builders

2020-05-15 Thread GitBox
eerhardt commented on pull request #7158: URL: https://github.com/apache/arrow/pull/7158#issuecomment-629577781 Thanks for getting this out @mr-smidge. Sorry I didn’t get time to review it this week, but it is on my list for early next week to take a look.

[GitHub] [arrow] paddyhoran commented on pull request #7198: ARROW-8818: [Rust] Failing to build on master due to Flatbuffers/Union issues

2020-05-15 Thread GitBox
paddyhoran commented on pull request #7198: URL: https://github.com/apache/arrow/pull/7198#issuecomment-629559536 I don't quite know what happened to by local setup. I was getting an error due to flatbuffers and once I bumped flatbuffers to 0.6.1 is resolved. I can't re-create it now so

[GitHub] [arrow] github-actions[bot] commented on pull request #7198: ARROW-8818: [Rust] Failing to build on master due to Flatbuffers/Union issues

2020-05-15 Thread GitBox
github-actions[bot] commented on pull request #7198: URL: https://github.com/apache/arrow/pull/7198#issuecomment-629557971 https://issues.apache.org/jira/browse/ARROW-8818 This is an automated message from the Apache Git

[GitHub] [arrow] paddyhoran commented on issue #7194: Rust docs don't compile for arrow 0.17.0

2020-05-15 Thread GitBox
paddyhoran commented on issue #7194: URL: https://github.com/apache/arrow/issues/7194#issuecomment-629557139 Hi @ritchie46, thanks for the issue report. We use JIRA for issue tracking so I opened an [issue](https://issues.apache.org/jira/browse/ARROW-8819) there.

[GitHub] [arrow] paddyhoran closed issue #7194: Rust docs don't compile for arrow 0.17.0

2020-05-15 Thread GitBox
paddyhoran closed issue #7194: URL: https://github.com/apache/arrow/issues/7194 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] paddyhoran opened a new pull request #7198: ARROW-8818: [Rust] Failing to build on master due to Flatbuffers/Union issues

2020-05-15 Thread GitBox
paddyhoran opened a new pull request #7198: URL: https://github.com/apache/arrow/pull/7198 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [arrow] kou commented on pull request #7146: ARROW-8757: [C++][Plasma] Write Plasma header in little-endian format

2020-05-15 Thread GitBox
kou commented on pull request #7146: URL: https://github.com/apache/arrow/pull/7146#issuecomment-629530281 Rerunning fixed the test failure. I've merged this. Sorry. I forgot to merge this. This is an automated message

[GitHub] [arrow] kou closed pull request #7146: ARROW-8757: [C++][Plasma] Write Plasma header in little-endian format

2020-05-15 Thread GitBox
kou closed pull request #7146: URL: https://github.com/apache/arrow/pull/7146 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] nealrichardson closed pull request #7197: ARROW-7967: [CI][Crossbow] Pin macOS version in autobrew job to match CRAN

2020-05-15 Thread GitBox
nealrichardson closed pull request #7197: URL: https://github.com/apache/arrow/pull/7197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] nealrichardson closed pull request #7196: ARROW-8556: [R] zstd symbol not found if there are multiple installations of zstd

2020-05-15 Thread GitBox
nealrichardson closed pull request #7196: URL: https://github.com/apache/arrow/pull/7196 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] kou commented on pull request #7192: ARROW-8815: [Dev][Release] Binary upload script should retry on unexpected bintray request error

2020-05-15 Thread GitBox
kou commented on pull request #7192: URL: https://github.com/apache/arrow/pull/7192#issuecomment-629525297 Could you try the following command with this change to collect the HTTP error response on download? ```shell BINTRAY_REPOSITORY=kszucs/arrow dev/release/03-binary.sh 0.17.1

[GitHub] [arrow] kou commented on a change in pull request #7192: ARROW-8815: [Dev][Release] Binary upload script should retry on unexpected bintray request error

2020-05-15 Thread GitBox
kou commented on a change in pull request #7192: URL: https://github.com/apache/arrow/pull/7192#discussion_r426068491 ## File path: dev/release/binary-task.rb ## @@ -610,7 +610,7 @@ def download_url(url, output_path)

[GitHub] [arrow] github-actions[bot] commented on pull request #7197: ARROW-7967: [CI][Crossbow] Pin macOS version in autobrew job to match CRAN

2020-05-15 Thread GitBox
github-actions[bot] commented on pull request #7197: URL: https://github.com/apache/arrow/pull/7197#issuecomment-629518324 https://issues.apache.org/jira/browse/ARROW-7967 This is an automated message from the Apache Git

[GitHub] [arrow] kou closed pull request #7191: ARROW-8814: [Dev][Release] Binary upload script keeps raising locale warnings

2020-05-15 Thread GitBox
kou closed pull request #7191: URL: https://github.com/apache/arrow/pull/7191 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] github-actions[bot] commented on pull request #7197: ARROW-7967: [CI][Crossbow] Pin macOS version in autobrew job to match CRAN

2020-05-15 Thread GitBox
github-actions[bot] commented on pull request #7197: URL: https://github.com/apache/arrow/pull/7197#issuecomment-629515712 Revision: 7f50e24a7ecb593ceb0e0f5fec4c13e1f05e36db Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] nealrichardson commented on pull request #7197: ARROW-7967: [CI][Crossbow] Pin macOS version in autobrew job to match CRAN

2020-05-15 Thread GitBox
nealrichardson commented on pull request #7197: URL: https://github.com/apache/arrow/pull/7197#issuecomment-629514818 @github-actions crossbow submit homebrew-r-autobrew This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson commented on a change in pull request #7197: ARROW-7967: [CI][Crossbow] Pin macOS version in autobrew job to match CRAN

2020-05-15 Thread GitBox
nealrichardson commented on a change in pull request #7197: URL: https://github.com/apache/arrow/pull/7197#discussion_r426063851 ## File path: dev/tasks/homebrew-formulae/travis.osx.r.yml ## @@ -15,10 +15,8 @@ # limitations under the License. os: osx -# CRAN builds on

[GitHub] [arrow] nealrichardson opened a new pull request #7197: ARROW-7967: [CI][Crossbow] Pin macOS version in autobrew job to match CRAN

2020-05-15 Thread GitBox
nealrichardson opened a new pull request #7197: URL: https://github.com/apache/arrow/pull/7197 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] nealrichardson closed pull request #7195: ARROW-7803: [R][CI] Autobrew/homebrew tests should not always install from master

2020-05-15 Thread GitBox
nealrichardson closed pull request #7195: URL: https://github.com/apache/arrow/pull/7195 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] github-actions[bot] commented on pull request #7196: ARROW-8556: [R] zstd symbol not found if there are multiple installations of zstd

2020-05-15 Thread GitBox
github-actions[bot] commented on pull request #7196: URL: https://github.com/apache/arrow/pull/7196#issuecomment-629501150 Revision: d59fdcaa78ba3ec38c314027648cacd09eab Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] nealrichardson commented on pull request #7196: ARROW-8556: [R] zstd symbol not found if there are multiple installations of zstd

2020-05-15 Thread GitBox
nealrichardson commented on pull request #7196: URL: https://github.com/apache/arrow/pull/7196#issuecomment-629500237 @github-actions crossbow submit *as-cran* This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #7196: ARROW-8556: [R] zstd symbol not found if there are multiple installations of zstd

2020-05-15 Thread GitBox
github-actions[bot] commented on pull request #7196: URL: https://github.com/apache/arrow/pull/7196#issuecomment-629494157 ``` No such command 'crossbow-submit'. ``` This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson commented on pull request #7196: ARROW-8556: [R] zstd symbol not found if there are multiple installations of zstd

2020-05-15 Thread GitBox
nealrichardson commented on pull request #7196: URL: https://github.com/apache/arrow/pull/7196#issuecomment-629493581 @github-actions crossbow-submit *as-cran* This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #7195: ARROW-7803: [R][CI] Autobrew/homebrew tests should not always install from master

2020-05-15 Thread GitBox
github-actions[bot] commented on pull request #7195: URL: https://github.com/apache/arrow/pull/7195#issuecomment-629491844 Revision: a4bcd1081fffca271389bf611ad7f5737e671f8f Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] github-actions[bot] commented on pull request #7196: ARROW-8556: [R] zstd symbol not found if there are multiple installations of zstd

2020-05-15 Thread GitBox
github-actions[bot] commented on pull request #7196: URL: https://github.com/apache/arrow/pull/7196#issuecomment-629490554 https://issues.apache.org/jira/browse/ARROW-8556 This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson commented on pull request #7195: ARROW-7803: [R][CI] Autobrew/homebrew tests should not always install from master

2020-05-15 Thread GitBox
nealrichardson commented on pull request #7195: URL: https://github.com/apache/arrow/pull/7195#issuecomment-629490945 @github-actions crossbow submit homebrew-cpp-autobrew This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson opened a new pull request #7196: ARROW-8556: [R] zstd symbol not found if there are multiple installations of zstd

2020-05-15 Thread GitBox
nealrichardson opened a new pull request #7196: URL: https://github.com/apache/arrow/pull/7196 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] github-actions[bot] commented on pull request #7195: ARROW-7803: [R][CI] Autobrew/homebrew tests should not always install from master

2020-05-15 Thread GitBox
github-actions[bot] commented on pull request #7195: URL: https://github.com/apache/arrow/pull/7195#issuecomment-629478994 Revision: dad17e9312a234a27b9560569cd96f7fa44f1ccb Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] nealrichardson commented on pull request #7195: ARROW-7803: [R][CI] Autobrew/homebrew tests should not always install from master

2020-05-15 Thread GitBox
nealrichardson commented on pull request #7195: URL: https://github.com/apache/arrow/pull/7195#issuecomment-629478277 @github-actions crossbow submit homebrew* This is an automated message from the Apache Git Service. To

[GitHub] [arrow] nealrichardson commented on pull request #7195: ARROW-7803: [R][CI] Autobrew/homebrew tests should not always install from master

2020-05-15 Thread GitBox
nealrichardson commented on pull request #7195: URL: https://github.com/apache/arrow/pull/7195#issuecomment-629473653 @github-actions crossbow submit homebrew* This is an automated message from the Apache Git Service. To

[GitHub] [arrow] andygrove commented on a change in pull request #7193: ARROW-7924: [Rust] Add sort for float types

2020-05-15 Thread GitBox
andygrove commented on a change in pull request #7193: URL: https://github.com/apache/arrow/pull/7193#discussion_r426027665 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -283,6 +285,30 @@ mod tests { None, vec![3, 1, 4, 2, 0, 5],

[GitHub] [arrow] nealrichardson closed pull request #6879: ARROW-8377: [CI][C++][R] Build and run C++ tests on Rtools build

2020-05-15 Thread GitBox
nealrichardson closed pull request #6879: URL: https://github.com/apache/arrow/pull/6879 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] nealrichardson commented on pull request #6879: ARROW-8377: [CI][C++][R] Build and run C++ tests on Rtools build

2020-05-15 Thread GitBox
nealrichardson commented on pull request #6879: URL: https://github.com/apache/arrow/pull/6879#issuecomment-629460156 I'm closing this; don't think it's worth our time right now to pursue further. We can revisit later if we want.

[GitHub] [arrow] nealrichardson closed pull request #7080: ARROW-8662: [CI] Consolidate appveyor scripts

2020-05-15 Thread GitBox
nealrichardson closed pull request #7080: URL: https://github.com/apache/arrow/pull/7080 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] nealrichardson commented on pull request #7080: ARROW-8662: [CI] Consolidate appveyor scripts

2020-05-15 Thread GitBox
nealrichardson commented on pull request #7080: URL: https://github.com/apache/arrow/pull/7080#issuecomment-629458850 Interpreting that  as an approval. Appveyor passed so I'm merging. This is an automated message from the

[GitHub] [arrow] github-actions[bot] commented on pull request #7195: ARROW-7803: [R][CI] Autobrew/homebrew tests should not always install from master

2020-05-15 Thread GitBox
github-actions[bot] commented on pull request #7195: URL: https://github.com/apache/arrow/pull/7195#issuecomment-629455217 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] nealrichardson commented on pull request #7195: ARROW-7803: [R][CI] Autobrew/homebrew tests should not always install from master

2020-05-15 Thread GitBox
nealrichardson commented on pull request #7195: URL: https://github.com/apache/arrow/pull/7195#issuecomment-629454630 @github-actions crossbow submit homebrew* This is an automated message from the Apache Git Service. To

[GitHub] [arrow] nealrichardson opened a new pull request #7195: ARROW-7803: [R][CI] Autobrew/homebrew tests should not always install from master

2020-05-15 Thread GitBox
nealrichardson opened a new pull request #7195: URL: https://github.com/apache/arrow/pull/7195 The crossbow jobs now append `, :revision => "the_current_sha"` to the git URL in the formula, which makes brew install checkout that commit to build from. Relevant homebrew docs:

[GitHub] [arrow] nevi-me commented on pull request #7186: ARROW-8808: [Rust] Fix divide by zero error in builder

2020-05-15 Thread GitBox
nevi-me commented on pull request #7186: URL: https://github.com/apache/arrow/pull/7186#issuecomment-629442658 > Thanks, I hadn't seen that. It might be faster to get this one merged since it is small. It looks like there are no reviews yet on #7159. I'm fine either way, but would like to

[GitHub] [arrow] nevi-me commented on a change in pull request #7193: ARROW-7924: [Rust] Add sort for float types

2020-05-15 Thread GitBox
nevi-me commented on a change in pull request #7193: URL: https://github.com/apache/arrow/pull/7193#discussion_r426001210 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -283,6 +285,30 @@ mod tests { None, vec![3, 1, 4, 2, 0, 5],

[GitHub] [arrow] ritchie46 opened a new issue #7194: Rust docs don't compile for arrow 0.17.0

2020-05-15 Thread GitBox
ritchie46 opened a new issue #7194: URL: https://github.com/apache/arrow/issues/7194 The arrow docs for Rust don't compile for version 0.17.0. ``` [INFO] [stderr] Error: "Failed to locate format/Flight.proto in any parent directory" ``` See the build logs in

[GitHub] [arrow] pitrou commented on a change in pull request #7172: ARROW-8763: [C++] Add RandomAccessFile::WillNeed

2020-05-15 Thread GitBox
pitrou commented on a change in pull request #7172: URL: https://github.com/apache/arrow/pull/7172#discussion_r425997507 ## File path: cpp/src/arrow/util/io_util.cc ## @@ -1072,6 +1072,61 @@ Status MemoryMapRemap(void* addr, size_t old_size, size_t new_size, int fildes,

[GitHub] [arrow] pitrou commented on a change in pull request #7172: ARROW-8763: [C++] Add RandomAccessFile::WillNeed

2020-05-15 Thread GitBox
pitrou commented on a change in pull request #7172: URL: https://github.com/apache/arrow/pull/7172#discussion_r425997334 ## File path: cpp/src/arrow/io/file.cc ## @@ -636,6 +665,9 @@ Result> MemoryMappedFile::ReadAt(int64_t position, ARROW_ASSIGN_OR_RAISE( nbytes,

[GitHub] [arrow] fsaintjacques commented on a change in pull request #7172: ARROW-8763: [C++] Add RandomAccessFile::WillNeed

2020-05-15 Thread GitBox
fsaintjacques commented on a change in pull request #7172: URL: https://github.com/apache/arrow/pull/7172#discussion_r425995665 ## File path: cpp/src/arrow/io/file.cc ## @@ -636,6 +665,9 @@ Result> MemoryMappedFile::ReadAt(int64_t position, ARROW_ASSIGN_OR_RAISE(

[GitHub] [arrow] nevi-me commented on a change in pull request #7193: ARROW-7924: [Rust] Add sort for float types

2020-05-15 Thread GitBox
nevi-me commented on a change in pull request #7193: URL: https://github.com/apache/arrow/pull/7193#discussion_r425988415 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -283,6 +285,30 @@ mod tests { None, vec![3, 1, 4, 2, 0, 5],

[GitHub] [arrow] andygrove commented on a change in pull request #7193: ARROW-7924: [Rust] Add sort for float types

2020-05-15 Thread GitBox
andygrove commented on a change in pull request #7193: URL: https://github.com/apache/arrow/pull/7193#discussion_r425993804 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -283,6 +285,30 @@ mod tests { None, vec![3, 1, 4, 2, 0, 5],

[GitHub] [arrow] nevi-me commented on a change in pull request #7193: ARROW-7924: [Rust] Add sort for float types

2020-05-15 Thread GitBox
nevi-me commented on a change in pull request #7193: URL: https://github.com/apache/arrow/pull/7193#discussion_r425988415 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -283,6 +285,30 @@ mod tests { None, vec![3, 1, 4, 2, 0, 5],

[GitHub] [arrow] emkornfield commented on pull request #6425: ARROW-6111: [Java] Support LargeVarChar and LargeBinary types

2020-05-15 Thread GitBox
emkornfield commented on pull request #6425: URL: https://github.com/apache/arrow/pull/6425#issuecomment-629421269 @BryanCutler I believe the integration tests couple LargeList with LargeVarChar/LargeBinary, so both need to be implemented to enable the integration tests.

[GitHub] [arrow] BryanCutler commented on pull request #6425: ARROW-6111: [Java] Support LargeVarChar and LargeBinary types

2020-05-15 Thread GitBox
BryanCutler commented on pull request #6425: URL: https://github.com/apache/arrow/pull/6425#issuecomment-629419409 I think you should be removing the skip Java here

[GitHub] [arrow] andygrove commented on a change in pull request #7193: ARROW-7924: [Rust] Add sort for float types

2020-05-15 Thread GitBox
andygrove commented on a change in pull request #7193: URL: https://github.com/apache/arrow/pull/7193#discussion_r425981877 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -283,6 +285,30 @@ mod tests { None, vec![3, 1, 4, 2, 0, 5],

[GitHub] [arrow] nevi-me commented on a change in pull request #7193: ARROW-7924: [Rust] Add sort for float types

2020-05-15 Thread GitBox
nevi-me commented on a change in pull request #7193: URL: https://github.com/apache/arrow/pull/7193#discussion_r425981364 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -149,9 +151,9 @@ where .collect::>(); let mut nulls = null_indices; if

[GitHub] [arrow] andygrove commented on a change in pull request #7193: ARROW-7924: [Rust] Add sort for float types

2020-05-15 Thread GitBox
andygrove commented on a change in pull request #7193: URL: https://github.com/apache/arrow/pull/7193#discussion_r425980474 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -149,9 +151,9 @@ where .collect::>(); let mut nulls = null_indices; if

[GitHub] [arrow] maxburke commented on pull request #6770: ARROW-7842: [Rust] [Parquet] implement array_reader for list type columns

2020-05-15 Thread GitBox
maxburke commented on pull request #6770: URL: https://github.com/apache/arrow/pull/6770#issuecomment-629401330 (FWIW it seems that this build is broken because of the merge of ARROW-3827 This is an automated message from

[GitHub] [arrow] maxburke commented on pull request #6770: ARROW-7842: [Rust] [Parquet] implement array_reader for list type columns

2020-05-15 Thread GitBox
maxburke commented on pull request #6770: URL: https://github.com/apache/arrow/pull/6770#issuecomment-629397472 > Sorry for the late response @maxburke . I'll take a look at this today. I hate to keep poking but were you able to have a look at this? We're really hoping to get back

[GitHub] [arrow] nealrichardson commented on pull request #7146: ARROW-8757: [C++][Plasma] Write Plasma header in little-endian format

2020-05-15 Thread GitBox
nealrichardson commented on pull request #7146: URL: https://github.com/apache/arrow/pull/7146#issuecomment-629374066 Sorry, auto-rebase didn't work because there are changes to .github/workflows in master. IDK if the "C GLib & Ruby / AMD64 Windows MinGW 64 GLib & Ruby" failure is real or

[GitHub] [arrow] nealrichardson commented on pull request #7146: ARROW-8757: [C++][Plasma] Write Plasma header in little-endian format

2020-05-15 Thread GitBox
nealrichardson commented on pull request #7146: URL: https://github.com/apache/arrow/pull/7146#issuecomment-629370089 @github-actions rebase This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] nealrichardson closed pull request #7159: ARROW-8777: [Rust] Parquet.rs does not support reading fixed-size binary fields.

2020-05-15 Thread GitBox
nealrichardson closed pull request #7159: URL: https://github.com/apache/arrow/pull/7159 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] github-actions[bot] commented on pull request #7193: ARROW-7924: [Rust] Add sort for float types

2020-05-15 Thread GitBox
github-actions[bot] commented on pull request #7193: URL: https://github.com/apache/arrow/pull/7193#issuecomment-629364386 https://issues.apache.org/jira/browse/ARROW-7924 This is an automated message from the Apache Git

[GitHub] [arrow] nevi-me opened a new pull request #7193: ARROW-7924: [Rust] Add sort for float types

2020-05-15 Thread GitBox
nevi-me opened a new pull request #7193: URL: https://github.com/apache/arrow/pull/7193 This relaxes the trait bound of `std::cmp::Ord` to `std::cmp::PartialOrd` to enable sorting by floats This is an automated message from

[GitHub] [arrow] nevi-me closed pull request #7004: ARROW-3827: [Rust] Implement UnionArray Updated

2020-05-15 Thread GitBox
nevi-me closed pull request #7004: URL: https://github.com/apache/arrow/pull/7004 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] nealrichardson closed pull request #7184: ARROW-8734: [R] improve nightly build installation

2020-05-15 Thread GitBox
nealrichardson closed pull request #7184: URL: https://github.com/apache/arrow/pull/7184 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] andygrove commented on pull request #7004: ARROW-3827: [Rust] Implement UnionArray Updated

2020-05-15 Thread GitBox
andygrove commented on pull request #7004: URL: https://github.com/apache/arrow/pull/7004#issuecomment-629283277 @nevi-me Sorry, I forgot about this one. Please go ahead. This is an automated message from the Apache Git

[GitHub] [arrow] nevi-me commented on pull request #7004: ARROW-3827: [Rust] Implement UnionArray Updated

2020-05-15 Thread GitBox
nevi-me commented on pull request #7004: URL: https://github.com/apache/arrow/pull/7004#issuecomment-629277167 > @nevi-me @andygrove this is ready for re-review. @andygrove do you want to have a look, or can we merge this?

[GitHub] [arrow] maxburke commented on a change in pull request #7159: ARROW-8777: [Rust] Parquet.rs does not support reading fixed-size binary fields.

2020-05-15 Thread GitBox
maxburke commented on a change in pull request #7159: URL: https://github.com/apache/arrow/pull/7159#discussion_r425853878 ## File path: rust/parquet/src/arrow/array_reader.rs ## @@ -1042,16 +1079,22 @@ mod tests { ", $physical_type,

[GitHub] [arrow] nevi-me commented on a change in pull request #7159: ARROW-8777: [Rust] Parquet.rs does not support reading fixed-size binary fields.

2020-05-15 Thread GitBox
nevi-me commented on a change in pull request #7159: URL: https://github.com/apache/arrow/pull/7159#discussion_r425845566 ## File path: rust/parquet/src/arrow/array_reader.rs ## @@ -1042,16 +1079,22 @@ mod tests { ", $physical_type,

[GitHub] [arrow] andygrove closed pull request #7164: ARROW-8783: [Rust] [DataFusion] Add ParquetScan and CsvScan variants in LogicalPlan

2020-05-15 Thread GitBox
andygrove closed pull request #7164: URL: https://github.com/apache/arrow/pull/7164 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] andygrove commented on pull request #7186: ARROW-8808: [Rust] Fix divide by zero error in builder

2020-05-15 Thread GitBox
andygrove commented on pull request #7186: URL: https://github.com/apache/arrow/pull/7186#issuecomment-629269342 Thanks, I hadn't seen that. It might be faster to get this one merged since it is small. It looks like there are no reviews yet on #7159. I'm fine either way, but would like to

[GitHub] [arrow] andygrove closed pull request #7187: ARROW-8809: [Rust] Fix JSON schema bug

2020-05-15 Thread GitBox
andygrove closed pull request #7187: URL: https://github.com/apache/arrow/pull/7187 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] vertexclique commented on pull request #6898: ARROW-8399: [Rust] Extend memory alignments to include other architectures

2020-05-15 Thread GitBox
vertexclique commented on pull request #6898: URL: https://github.com/apache/arrow/pull/6898#issuecomment-629234482 Hi, @paddyhoran I've written extensive documentation and all corresponding values and their references inside this PR. Also rebased!

[GitHub] [arrow] wesm commented on pull request #7178: ARROW-8568: [C++] Fix decimal to decimal cast issues

2020-05-15 Thread GitBox
wesm commented on pull request #7178: URL: https://github.com/apache/arrow/pull/7178#issuecomment-629210514 No problem. I've been burning the midnight oil this week so it shouldn't delay too much longer This is an

[GitHub] [arrow] vertexclique commented on pull request #7061: ARROW-8629: [Rust] Eliminate indirection of zero sized allocations

2020-05-15 Thread GitBox
vertexclique commented on pull request #7061: URL: https://github.com/apache/arrow/pull/7061#issuecomment-629201947 @sunchao rebased. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] pitrou commented on pull request #7178: ARROW-8568: [C++] Fix decimal to decimal cast issues

2020-05-15 Thread GitBox
pitrou commented on pull request #7178: URL: https://github.com/apache/arrow/pull/7178#issuecomment-629197677 Woops, sorry, I had forgotten about the refactor. But, yeah, the changes are quite localized here. This is an

[GitHub] [arrow] github-actions[bot] commented on pull request #7192: ARROW-8815: [Dev][Release] Binary upload script should retry on unexpected bintray request error

2020-05-15 Thread GitBox
github-actions[bot] commented on pull request #7192: URL: https://github.com/apache/arrow/pull/7192#issuecomment-629184621 https://issues.apache.org/jira/browse/ARROW-8815 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #7191: ARROW-8814: [Dev][Release] Binary upload script keeps raising locale warnings

2020-05-15 Thread GitBox
github-actions[bot] commented on pull request #7191: URL: https://github.com/apache/arrow/pull/7191#issuecomment-629184622 https://issues.apache.org/jira/browse/ARROW-8814 This is an automated message from the Apache Git

[GitHub] [arrow] kszucs commented on a change in pull request #7192: ARROW-8815: [Dev][Release] Binary upload script should retry on unexpected bintray request error

2020-05-15 Thread GitBox
kszucs commented on a change in pull request #7192: URL: https://github.com/apache/arrow/pull/7192#discussion_r42574 ## File path: dev/release/binary-task.rb ## @@ -610,7 +610,7 @@ def download_url(url, output_path)

[GitHub] [arrow] kszucs commented on a change in pull request #7192: ARROW-8815: [Dev][Release] Binary upload script should retry on unexpected bintray request error

2020-05-15 Thread GitBox
kszucs commented on a change in pull request #7192: URL: https://github.com/apache/arrow/pull/7192#discussion_r42574 ## File path: dev/release/binary-task.rb ## @@ -610,7 +610,7 @@ def download_url(url, output_path)

[GitHub] [arrow] kszucs opened a new pull request #7192: ARROW-8815: [Dev][Release] Binary upload script should retry on unexpected bintray request error

2020-05-15 Thread GitBox
kszucs opened a new pull request #7192: URL: https://github.com/apache/arrow/pull/7192 During uploading the binaries to bintray the script exited multiple times because of unhandled HTTP errors. This is an automated message

[GitHub] [arrow] kszucs opened a new pull request #7191: ARROW-8814: [Dev][Release] Binary upload script keeps raising locale warnings

2020-05-15 Thread GitBox
kszucs opened a new pull request #7191: URL: https://github.com/apache/arrow/pull/7191 Makes the output readable. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] rongma1997 commented on pull request #7188: ARROW-8803: [Java] Row count should be set before loading buffers in VectorLoader

2020-05-15 Thread GitBox
rongma1997 commented on pull request #7188: URL: https://github.com/apache/arrow/pull/7188#issuecomment-629175106 Close this based on the discussions in jira. This is an automated message from the Apache Git Service. To

[GitHub] [arrow] rongma1997 closed pull request #7188: ARROW-8803: [Java] Row count should be set before loading buffers in VectorLoader

2020-05-15 Thread GitBox
rongma1997 closed pull request #7188: URL: https://github.com/apache/arrow/pull/7188 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] nevi-me commented on pull request #7186: ARROW-8808: [Rust] Fix divide by zero error in builder

2020-05-15 Thread GitBox
nevi-me commented on pull request #7186: URL: https://github.com/apache/arrow/pull/7186#issuecomment-629139299 @maxburke had already picked this up in #7159 (https://github.com/apache/arrow/pull/7159/files#diff-f2e30b8a413036fbb623c52d0ffd519dR723). Perhaps we could port the unit test

[GitHub] [arrow] rymurr commented on pull request #7100: ARROW-8696: [Java] Convert tests to maven failsafe

2020-05-15 Thread GitBox
rymurr commented on pull request #7100: URL: https://github.com/apache/arrow/pull/7100#issuecomment-629138257 > @rymurr could you add a section to the Readme with the maven command to run integration tests? Otherwise I think this should be mergeable. @kszucs do the machines the nightlies

[GitHub] [arrow] liyafan82 commented on pull request #6622: ARROW-8121: [Java] Enhance code style checking for Java code (add spaces after commas, semi-colons and type casts)

2020-05-15 Thread GitBox
liyafan82 commented on pull request #6622: URL: https://github.com/apache/arrow/pull/6622#issuecomment-629137341 > @liyafan82 sorry for the delay would you mind rebasing once more? I'll merge later tonight if I'm online or first thing tomorrow, so you won't need to do it again.

[GitHub] [arrow] pitrou commented on pull request #6811: [DO NOT MERGE] [Python] Reformat using autopep8

2020-05-15 Thread GitBox
pitrou commented on pull request #6811: URL: https://github.com/apache/arrow/pull/6811#issuecomment-629125249 I can update this PR and make it ready to merge. I think people agreed that having `autopep8` is better than nothing (well, at least the people who wanted a Python reformatter

[GitHub] [arrow] scampi commented on a change in pull request #6402: ARROW-7831: [Java] do not allocate a new offset buffer if the slice starts at 0 since the relative offset pointer would be unchange

2020-05-15 Thread GitBox
scampi commented on a change in pull request #6402: URL: https://github.com/apache/arrow/pull/6402#discussion_r425610823 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java ## @@ -740,10 +740,16 @@ private void

[GitHub] [arrow] projjal commented on pull request #5947: ARROW-7300: [C++][Gandiva] Implement functions to cast from strings to integers/floats

2020-05-15 Thread GitBox
projjal commented on pull request #5947: URL: https://github.com/apache/arrow/pull/5947#issuecomment-629051199 ping @praveenbingo This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] emkornfield commented on pull request #7188: ARROW-8803: [Java] Row count should be set before loading buffers in VectorLoader

2020-05-15 Thread GitBox
emkornfield commented on pull request #7188: URL: https://github.com/apache/arrow/pull/7188#issuecomment-629047852 master should be fixed now. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] emkornfield closed pull request #7190: ARROW-8811: [Java] Fix CI

2020-05-15 Thread GitBox
emkornfield closed pull request #7190: URL: https://github.com/apache/arrow/pull/7190 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go