kiszk commented on a change in pull request #7295:
URL: https://github.com/apache/arrow/pull/7295#discussion_r431566905
##
File path: cpp/src/gandiva/engine.cc
##
@@ -150,6 +152,27 @@ Status Engine::Make(const std::shared_ptr&
conf,
return Status::OK();
}
+static void
maxburke commented on a change in pull request #7291:
URL: https://github.com/apache/arrow/pull/7291#discussion_r431553463
##
File path: rust/parquet/src/arrow/array_reader.rs
##
@@ -609,23 +609,34 @@ where
{
let mut leaves = HashMap::<*const Type, usize>::new();
-
sunchao commented on pull request #7291:
URL: https://github.com/apache/arrow/pull/7291#issuecomment-635063404
Merged. Thanks @rdettai for the fix and @maxburke for reporting this!
This is an automated message from the
sunchao closed pull request #7291:
URL: https://github.com/apache/arrow/pull/7291
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
maxburke commented on pull request #7291:
URL: https://github.com/apache/arrow/pull/7291#issuecomment-635062239
@rdettai Your change works for me! Thank you so much for looking into this!
:smile:
This is an automated
liyafan82 commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-635050822
@BryanCutler @siddharthteotia @emkornfield I am aware that this PR is large,
and consumes lots of effort. So thanks a lot for your effort and good comments!
liyafan82 commented on a change in pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#discussion_r431542563
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorVisitor.java
##
@@ -90,6 +91,11 @@ public Void
liyafan82 commented on a change in pull request #7287:
URL: https://github.com/apache/arrow/pull/7287#discussion_r431540394
##
File path: cpp/build-support/trim-boost.sh
##
@@ -41,6 +41,8 @@ BOOST_LIBS="$BOOST_LIBS regex.hpp"
BOOST_LIBS="$BOOST_LIBS
kiszk edited a comment on pull request #7295:
URL: https://github.com/apache/arrow/pull/7295#issuecomment-635036852
Regarding the licence, I will add a link to the file at
https://github.com/llvm/llvm-project/blob/master/mlir/LICENSE.TXT.
Could you please let me know if we need to
kiszk commented on pull request #7295:
URL: https://github.com/apache/arrow/pull/7295#issuecomment-635036852
Regarding the licence, I will add a link to the file at
https://github.com/llvm/llvm-project/blob/master/mlir/LICENSE.TXT.
github-actions[bot] commented on pull request #7280:
URL: https://github.com/apache/arrow/pull/7280#issuecomment-635028483
Revision: a47ab63fab16246cac07c2ed7bed3050744d2144
Submitted crossbow builds: [ursa-labs/crossbow @
kou commented on pull request #7280:
URL: https://github.com/apache/arrow/pull/7280#issuecomment-635025560
@github-actions crossbow submit -g nightly
This is an automated message from the Apache Git Service.
To respond to
kou commented on pull request #7294:
URL: https://github.com/apache/arrow/pull/7294#issuecomment-635004181
@github-actions crossbow submit wheel-manylinux1-*
This is an automated message from the Apache Git Service.
To
kou commented on pull request #7294:
URL: https://github.com/apache/arrow/pull/7294#issuecomment-635002228
@github-actions crossbow submit -g wheel
This is an automated message from the Apache Git Service.
To respond to the
kou commented on pull request #7294:
URL: https://github.com/apache/arrow/pull/7294#issuecomment-634970128
@github-actions crossbow submit wheel-manylinux1-*
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #7294:
URL: https://github.com/apache/arrow/pull/7294#issuecomment-634967465
https://issues.apache.org/jira/browse/ARROW-8971
This is an automated message from the Apache Git
BryanCutler commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-634963132
merged to master, thanks @liyafan82 !
This is an automated message from the Apache Git Service.
To respond to
BryanCutler closed pull request #6425:
URL: https://github.com/apache/arrow/pull/6425
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
BryanCutler commented on a change in pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#discussion_r431461407
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorVisitor.java
##
@@ -90,6 +91,11 @@ public Void
sunchao commented on pull request #6935:
URL: https://github.com/apache/arrow/pull/6935#issuecomment-634961391
@rdettai looks like the fix is ready? I think we can just get the fix in
(probably today) instead of reverting the other one.
BinduAggarwal commented on a change in pull request #7294:
URL: https://github.com/apache/arrow/pull/7294#discussion_r431459925
##
File path: python/manylinux1/scripts/requirements.txt
##
@@ -23,12 +23,14 @@
# pip requirements for all cpythons
# NOTE: pip has GPG
kou commented on pull request #7294:
URL: https://github.com/apache/arrow/pull/7294#issuecomment-634958008
Could you open a new issue on
https://issues.apache.org/jira/projects/ARROW/issues/ and use the JIRA issue ID
(not pull request ID) in pull request title?
kou closed issue #7293:
URL: https://github.com/apache/arrow/issues/7293
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kou commented on a change in pull request #7294:
URL: https://github.com/apache/arrow/pull/7294#discussion_r431457963
##
File path: python/manylinux1/scripts/requirements.txt
##
@@ -23,12 +23,14 @@
# pip requirements for all cpythons
# NOTE: pip has GPG signatures; could
wesm commented on a change in pull request #7295:
URL: https://github.com/apache/arrow/pull/7295#discussion_r431454890
##
File path: cpp/src/gandiva/engine.cc
##
@@ -150,6 +152,27 @@ Status Engine::Make(const std::shared_ptr&
conf,
return Status::OK();
}
+static void
github-actions[bot] commented on pull request #7296:
URL: https://github.com/apache/arrow/pull/7296#issuecomment-634952786
https://issues.apache.org/jira/browse/ARROW-8793
This is an automated message from the Apache Git
wesm opened a new pull request #7296:
URL: https://github.com/apache/arrow/pull/7296
Local benchmarks suggest that there is 3-4 ns of overhead for manipulating
small bitmaps.
inline (argument is byte size of bitmap):
```
kou commented on a change in pull request #7284:
URL: https://github.com/apache/arrow/pull/7284#discussion_r431438314
##
File path: cpp/cmake_modules/DefineOptions.cmake
##
@@ -120,6 +120,8 @@ if("${CMAKE_SOURCE_DIR}" STREQUAL
"${CMAKE_CURRENT_SOURCE_DIR}")
wesm closed pull request #7277:
URL: https://github.com/apache/arrow/pull/7277
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
github-actions[bot] commented on pull request #7280:
URL: https://github.com/apache/arrow/pull/7280#issuecomment-634929177
Revision: dc97db6abe1291c8b3808b62c29808f04ca33c43
Submitted crossbow builds: [ursa-labs/crossbow @
kou commented on pull request #7280:
URL: https://github.com/apache/arrow/pull/7280#issuecomment-634928303
@github-actions crossbow submit -g nightly
This is an automated message from the Apache Git Service.
To respond to
nealrichardson commented on a change in pull request #7279:
URL: https://github.com/apache/arrow/pull/7279#discussion_r431423981
##
File path: r/src/expression.cpp
##
@@ -104,57 +104,9 @@ std::shared_ptr dataset___expr__is_valid(
// [[arrow::export]]
std::shared_ptr
bkietz commented on a change in pull request #7279:
URL: https://github.com/apache/arrow/pull/7279#discussion_r431417510
##
File path: r/src/compute.cpp
##
@@ -206,60 +206,91 @@ std::shared_ptr Table__FilterChunked(
return tab;
}
+template
+std::shared_ptr
nealrichardson commented on a change in pull request #7279:
URL: https://github.com/apache/arrow/pull/7279#discussion_r431404447
##
File path: r/R/scalar.R
##
@@ -0,0 +1,53 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
github-actions[bot] commented on pull request #7295:
URL: https://github.com/apache/arrow/pull/7295#issuecomment-634893457
https://issues.apache.org/jira/browse/ARROW-8968
This is an automated message from the Apache Git
kiszk commented on a change in pull request #7274:
URL: https://github.com/apache/arrow/pull/7274#discussion_r431387864
##
File path: CHANGELOG.md
##
@@ -866,7 +866,7 @@
* ARROW-5809 - [Rust] Dockerize (add to docker-compose) Rust Travis CI build
* ARROW-5831 - [Release]
kiszk opened a new pull request #7295:
URL: https://github.com/apache/arrow/pull/7295
This PR explicitly sets data layout for pre-compiled IR to `llvm:module`.
Without the PR, the following warning message is shown at link time of gandiva.
Most of this code comes from
itamarst commented on a change in pull request #7169:
URL: https://github.com/apache/arrow/pull/7169#discussion_r431376285
##
File path: python/pyarrow/tests/test_pandas.py
##
@@ -3965,8 +3964,32 @@ def test_timestamp_as_object():
np.datetime64('2050-05-03 15:42',
jorisvandenbossche commented on pull request #7169:
URL: https://github.com/apache/arrow/pull/7169#issuecomment-634876862
@itamarst sorry for the slow follow-up. I think I am OK with the current
semantics of the option
This
itamarst commented on pull request #7169:
URL: https://github.com/apache/arrow/pull/7169#issuecomment-634853818
@jorisvandenbossche are you happy with this as is, or do you want semantic
changes to the flag?
This is an
github-actions[bot] commented on pull request #7294:
URL: https://github.com/apache/arrow/pull/7294#issuecomment-634842663
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
BinduAggarwal opened a new pull request #7294:
URL: https://github.com/apache/arrow/pull/7294
This is for the fix of CVE issue, upgraded the pip version
CVE-2018-20225
An issue was discovered in pip (all versions) because it installs the
version with the highest version number, even
BinduAggarwal commented on issue #7293:
URL: https://github.com/apache/arrow/issues/7293#issuecomment-634825586
sure I will do it
This is an automated message from the Apache Git Service.
To respond to the message, please
fsaintjacques closed pull request #7286:
URL: https://github.com/apache/arrow/pull/7286
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
nealrichardson commented on issue #7293:
URL: https://github.com/apache/arrow/issues/7293#issuecomment-634814027
@BinduAggarwal would you be interested in opening a JIRA issue and a pull
request? Looks like the source of this requirements.txt file has been updated
as you describe:
BinduAggarwal opened a new issue #7293:
URL: https://github.com/apache/arrow/issues/7293
Could you please update the pip latest version 20.1
https://github.com/apache/arrow/blob/2688a62f8179f20c20c06a10fcd22fe8a714ae48/python/manylinux1/scripts/requirements.txt
CVE-2018-20225
nealrichardson commented on a change in pull request #7287:
URL: https://github.com/apache/arrow/pull/7287#discussion_r431282877
##
File path: cpp/build-support/trim-boost.sh
##
@@ -41,6 +41,8 @@ BOOST_LIBS="$BOOST_LIBS regex.hpp"
BOOST_LIBS="$BOOST_LIBS
nealrichardson commented on pull request #7287:
URL: https://github.com/apache/arrow/pull/7287#issuecomment-634786539
Yes, we will. Good test of the process we (hopefully) set up before.
This is an automated message from the
lidavidm commented on pull request #7277:
URL: https://github.com/apache/arrow/pull/7277#issuecomment-634783693
I've removed `std::move`. Sorry for the trouble.
This is an automated message from the Apache Git Service.
To
wesm commented on a change in pull request #7279:
URL: https://github.com/apache/arrow/pull/7279#discussion_r431269117
##
File path: r/src/compute.cpp
##
@@ -223,4 +205,66 @@ std::shared_ptr Table__FilterChunked(
}
return tab;
}
+
+arrow::Datum to_datum(SEXP x) {
kiszk edited a comment on pull request #7277:
URL: https://github.com/apache/arrow/pull/7277#issuecomment-634737470
Thanks, we still have build failure in another place at
https://travis-ci.org/github/apache/arrow/jobs/691713153#L1015
@lidavidm can we remove `std::move()` as a
bkietz commented on a change in pull request #7279:
URL: https://github.com/apache/arrow/pull/7279#discussion_r431273570
##
File path: r/src/compute.cpp
##
@@ -223,4 +205,66 @@ std::shared_ptr Table__FilterChunked(
}
return tab;
}
+
+arrow::Datum to_datum(SEXP x) {
fsaintjacques commented on pull request #7287:
URL: https://github.com/apache/arrow/pull/7287#issuecomment-634777086
@nealrichardson we might need a re-upload.
This is an automated message from the Apache Git Service.
To
bkietz commented on a change in pull request #7279:
URL: https://github.com/apache/arrow/pull/7279#discussion_r431266235
##
File path: r/src/compute.cpp
##
@@ -223,4 +205,66 @@ std::shared_ptr Table__FilterChunked(
}
return tab;
}
+
+arrow::Datum to_datum(SEXP x) {
+
bkietz commented on a change in pull request #7279:
URL: https://github.com/apache/arrow/pull/7279#discussion_r431263416
##
File path: r/src/compute.cpp
##
@@ -223,4 +205,66 @@ std::shared_ptr Table__FilterChunked(
}
return tab;
}
+
+arrow::Datum to_datum(SEXP x) {
+
nealrichardson commented on pull request #7279:
URL: https://github.com/apache/arrow/pull/7279#issuecomment-634755810
@github-actions autotune
This is an automated message from the Apache Git Service.
To respond to the
github-actions[bot] commented on pull request #7292:
URL: https://github.com/apache/arrow/pull/7292#issuecomment-634752661
https://issues.apache.org/jira/browse/ARROW-8471
This is an automated message from the Apache Git
bkietz opened a new pull request #7292:
URL: https://github.com/apache/arrow/pull/7292
Some 64 bit integer values are not representable as JSON numbers, so store
these as strings.
This is issue is a regression; original fix was #5267
rdettai commented on pull request #7291:
URL: https://github.com/apache/arrow/pull/7291#issuecomment-634741622
@maxburke this should definitively fix your issue ! Sorry for the
inconvenience. There are really very few safety nets on this codebase :-)
kiszk commented on pull request #7277:
URL: https://github.com/apache/arrow/pull/7277#issuecomment-634737470
Thanks, we still have build failure in another place at
https://travis-ci.org/github/apache/arrow/jobs/691713153#L1015
```
/arrow/cpp/src/arrow/flight/client.cc:391:50:
github-actions[bot] commented on pull request #7291:
URL: https://github.com/apache/arrow/pull/7291#issuecomment-634732266
https://issues.apache.org/jira/browse/ARROW-8455
This is an automated message from the Apache Git
rdettai opened a new pull request #7291:
URL: https://github.com/apache/arrow/pull/7291
This is a fix for the faulty https://github.com/apache/arrow/pull/6935
It addresses https://issues.apache.org/jira/browse/ARROW-8455
>Seen behavior: When reading a Parquet file into Arrow with
wesm commented on pull request #7258:
URL: https://github.com/apache/arrow/pull/7258#issuecomment-634725333
Could someone review this?
This is an automated message from the Apache Git Service.
To respond to the message,
github-actions[bot] commented on pull request #7290:
URL: https://github.com/apache/arrow/pull/7290#issuecomment-634652668
https://issues.apache.org/jira/browse/ARROW-1692
This is an automated message from the Apache Git
lidavidm commented on pull request #6656:
URL: https://github.com/apache/arrow/pull/6656#issuecomment-634650667
Sorry about that, for posterity this is being worked on in
https://github.com/apache/arrow/pull/7277.
This is
rymurr opened a new pull request #7290:
URL: https://github.com/apache/arrow/pull/7290
This fixes the integration tests for Union Arrays.
Both Dense and Sparse unions now work:
* validity buffer added to Sparse Union
* both Union types now track logical types rather than
hn5092 commented on pull request #7288:
URL: https://github.com/apache/arrow/pull/7288#issuecomment-634647561
retest this please!
This is an automated message from the Apache Git Service.
To respond to the message, please
lidavidm commented on a change in pull request #7277:
URL: https://github.com/apache/arrow/pull/7277#discussion_r431066490
##
File path: cpp/src/arrow/flight/server.cc
##
@@ -352,7 +352,7 @@ class DoExchangeMessageWriter : public FlightMessageWriter {
}
github-actions[bot] commented on pull request #7289:
URL: https://github.com/apache/arrow/pull/7289#issuecomment-634593683
https://issues.apache.org/jira/browse/ARROW-8948
This is an automated message from the Apache Git
rymurr opened a new pull request #7289:
URL: https://github.com/apache/arrow/pull/7289
This addresses the integration test error where Java cannot process
duplicate field names.
This extends StructVector and VectorSchemaRoot to support duplicate field
names.
cyb70289 commented on pull request #7285:
URL: https://github.com/apache/arrow/pull/7285#issuecomment-634555761
Before (apply only benchmark code)
```
BitmapEqualsWithoutOffset/8192195 ns 195 ns
3618366 bytes_per_second=39.1055G/s
github-actions[bot] commented on pull request #7288:
URL: https://github.com/apache/arrow/pull/7288#issuecomment-634551846
https://issues.apache.org/jira/browse/ARROW-8963
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7287:
URL: https://github.com/apache/arrow/pull/7287#issuecomment-634544583
https://issues.apache.org/jira/browse/ARROW-8771
This is an automated message from the Apache Git
hn5092 opened a new pull request #7288:
URL: https://github.com/apache/arrow/pull/7288
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
liyafan82 opened a new pull request #7287:
URL: https://github.com/apache/arrow/pull/7287
Some of our test source code requires the process.hpp file (and its
dependent libraries). Our current build support does not include these files,
causing build failures like:
`fatal error:
rdettai commented on pull request #6935:
URL: https://github.com/apache/arrow/pull/6935#issuecomment-634495368
@maxburke there is indeed an issue with struct fields. @sunchao I don't know
how you usually operate: should we reverse the merge then re-apply it with the
fix or create a new PR
kiszk commented on a change in pull request #7277:
URL: https://github.com/apache/arrow/pull/7277#discussion_r430857565
##
File path: cpp/src/arrow/flight/server.cc
##
@@ -352,7 +352,7 @@ class DoExchangeMessageWriter : public FlightMessageWriter {
}
github-actions[bot] commented on pull request #7286:
URL: https://github.com/apache/arrow/pull/7286#issuecomment-634463719
https://issues.apache.org/jira/browse/ARROW-8962
This is an automated message from the Apache Git
xhochy opened a new pull request #7286:
URL: https://github.com/apache/arrow/pull/7286
When linking the tests with `clang-4.0`, I get
```
Undefined symbols for architecture x86_64:
"arrow::internal::(anonymous
namespace)::StringToFloatConverterImpl::main_junk_value_",
liyafan82 commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-634447500
> Great job getting integration tests passing @liyafan82 ! I took a quick
look and LGTM, will do a more thorough pass hopefully tomorrow before merging.
@BryanCutler
80 matches
Mail list logo
