houqp commented on pull request #7324:
URL: https://github.com/apache/arrow/pull/7324#issuecomment-641742155
@nevi-me @andygrove rebased and ready for review
This is an automated message from the Apache Git Service.
To
houqp commented on a change in pull request #7324:
URL: https://github.com/apache/arrow/pull/7324#discussion_r437861027
##
File path: rust/arrow/src/array/builder.rs
##
@@ -1123,29 +1123,35 @@ fn append_binary_data(
}
}
-for array in data {
-//
emkornfield commented on pull request #7382:
URL: https://github.com/apache/arrow/pull/7382#issuecomment-641720988
noticed a few small nits. Somebody more familiar with Take should review
this.
This is an automated message
emkornfield commented on a change in pull request #7382:
URL: https://github.com/apache/arrow/pull/7382#discussion_r437859793
##
File path: cpp/src/arrow/util/bit_block_counter_test.cc
##
@@ -246,5 +246,28 @@ TEST(TestBinaryBitBlockCounter, NextAndWord) {
}
}
emkornfield commented on a change in pull request #7382:
URL: https://github.com/apache/arrow/pull/7382#discussion_r437859624
##
File path: cpp/src/arrow/util/int_util_test.cc
##
@@ -382,5 +386,102 @@ TEST(TransposeInts, Int8ToInt64) {
ASSERT_EQ(dest, std::vector({,
jedbrown commented on a change in pull request #7314:
URL: https://github.com/apache/arrow/pull/7314#discussion_r437844193
##
File path: cpp/src/arrow/compute/kernels/aggregate_basic_sse.cc
##
@@ -0,0 +1,355 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+//
github-actions[bot] commented on pull request #7393:
URL: https://github.com/apache/arrow/pull/7393#issuecomment-641686840
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
zhouyuan opened a new pull request #7393:
URL: https://github.com/apache/arrow/pull/7393
This patch fixes the hdfs options passing. With this patch Arrow can
pass kerberos_ticket and extra_conf on connecting with hdfs
Signed-off-by: Yuan Zhou
wesm commented on pull request #7373:
URL: https://github.com/apache/arrow/pull/7373#issuecomment-641684149
the Appveyor failures are ARROW-9085
This is an automated message from the Apache Git Service.
To respond to the
wesm commented on pull request #7390:
URL: https://github.com/apache/arrow/pull/7390#issuecomment-641681748
Finally got Appveyor to start a build
This is an automated message from the Apache Git Service.
To respond to the
cyb70289 commented on pull request #7373:
URL: https://github.com/apache/arrow/pull/7373#issuecomment-641675671
s390 ci failure is not related, it says "no space left on device".
appveyor ci failed with many zlib and lz4 runtime errors.
github-actions[bot] commented on pull request #7392:
URL: https://github.com/apache/arrow/pull/7392#issuecomment-641670556
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
sagnikc-dremio opened a new pull request #7392:
URL: https://github.com/apache/arrow/pull/7392
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
cyb70289 commented on a change in pull request #7373:
URL: https://github.com/apache/arrow/pull/7373#discussion_r437805418
##
File path: cpp/src/arrow/util/bitmap_ops.cc
##
@@ -298,52 +297,52 @@ void TransferBitmap(const uint8_t* data, int64_t offset,
int64_t length,
jianxind commented on a change in pull request #7314:
URL: https://github.com/apache/arrow/pull/7314#discussion_r437804878
##
File path: cpp/src/arrow/compute/kernels/aggregate_basic_sse.cc
##
@@ -0,0 +1,355 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+//
wesm commented on pull request #7390:
URL: https://github.com/apache/arrow/pull/7390#issuecomment-641657228
Ah appveyor didn't fire. I'll push a new build
This is an automated message from the Apache Git Service.
To respond
wesm commented on pull request #7390:
URL: https://github.com/apache/arrow/pull/7390#issuecomment-641657141
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kou commented on pull request #7391:
URL: https://github.com/apache/arrow/pull/7391#issuecomment-641651735
Thanks for the tip!
This is an automated message from the Apache Git Service.
To respond to the message, please log
kou commented on a change in pull request #7388:
URL: https://github.com/apache/arrow/pull/7388#discussion_r437795928
##
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##
@@ -1879,13 +1879,19 @@ macro(build_zstd)
add_dependencies(toolchain zstd_ep)
wesm commented on pull request #7389:
URL: https://github.com/apache/arrow/pull/7389#issuecomment-641650598
I didn't mean to open this PR
This is an automated message from the Apache Git Service.
To respond to the message,
github-actions[bot] commented on pull request #7391:
URL: https://github.com/apache/arrow/pull/7391#issuecomment-641650223
Revision: 2b9c3aed79d03b900d5e7ce627284dedf3be71d8
Submitted crossbow builds: [ursa-labs/crossbow @
kou commented on pull request #7388:
URL: https://github.com/apache/arrow/pull/7388#issuecomment-641650133
We need cmake-format 0.5.2:
https://github.com/apache/arrow/blob/master/dev/archery/requirements-lint.txt#L3
This is
nealrichardson commented on pull request #7391:
URL: https://github.com/apache/arrow/pull/7391#issuecomment-641650301
Just a heads up, homebrew nightlies are failing but on-demand (like you just
requested) should work, so if/when you merge this, don't blame yourself for the
nightly
github-actions[bot] commented on pull request #7391:
URL: https://github.com/apache/arrow/pull/7391#issuecomment-641650102
https://issues.apache.org/jira/browse/ARROW-9086
This is an automated message from the Apache Git
kou commented on pull request #7391:
URL: https://github.com/apache/arrow/pull/7391#issuecomment-641649747
@github-actions crossbow submit homebrew-cpp
This is an automated message from the Apache Git Service.
To respond to
kou opened a new pull request #7391:
URL: https://github.com/apache/arrow/pull/7391
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
emkornfield commented on a change in pull request #7389:
URL: https://github.com/apache/arrow/pull/7389#discussion_r437792823
##
File path: cpp/src/arrow/util/bit_block_counter_test.cc
##
@@ -246,5 +246,28 @@ TEST(TestBinaryBitBlockCounter, NextAndWord) {
}
}
veprbl commented on pull request #7388:
URL: https://github.com/apache/arrow/pull/7388#issuecomment-641642689
@kou Thanks a lot for format fix, I was unable to address that with
cmake-format 0.6.10
This is an automated
veprbl commented on a change in pull request #7388:
URL: https://github.com/apache/arrow/pull/7388#discussion_r437787687
##
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##
@@ -1879,13 +1879,19 @@ macro(build_zstd)
add_dependencies(toolchain zstd_ep)
github-actions[bot] commented on pull request #7390:
URL: https://github.com/apache/arrow/pull/7390#issuecomment-641637897
https://issues.apache.org/jira/browse/ARROW-9085
This is an automated message from the Apache Git
kou commented on a change in pull request #7388:
URL: https://github.com/apache/arrow/pull/7388#discussion_r437780818
##
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##
@@ -1879,13 +1879,19 @@ macro(build_zstd)
add_dependencies(toolchain zstd_ep)
wesm opened a new pull request #7390:
URL: https://github.com/apache/arrow/pull/7390
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
wesm closed pull request #7389:
URL: https://github.com/apache/arrow/pull/7389
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
wesm opened a new pull request #7389:
URL: https://github.com/apache/arrow/pull/7389
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
wesm commented on pull request #7281:
URL: https://github.com/apache/arrow/pull/7281#issuecomment-641630643
I opened https://issues.apache.org/jira/browse/ARROW-9085
This is an automated message from the Apache Git Service.
wesm commented on pull request #7382:
URL: https://github.com/apache/arrow/pull/7382#issuecomment-641630347
Appveyor is failing because of
https://github.com/apache/arrow/commit/b058cf0d1c26ad7984c104bb84322cc7dcc66f00
I opened https://issues.apache.org/jira/browse/ARROW-9085
github-actions[bot] commented on pull request #7388:
URL: https://github.com/apache/arrow/pull/7388#issuecomment-641629188
https://issues.apache.org/jira/browse/ARROW-9084
This is an automated message from the Apache Git
veprbl opened a new pull request #7388:
URL: https://github.com/apache/arrow/pull/7388
ZSTD::zstd target is expected to exist, but zstd exports
ZSTD::zstd_{shared,static}.
This is an automated message from the Apache Git
BryanCutler commented on pull request #7275:
URL: https://github.com/apache/arrow/pull/7275#issuecomment-641623134
I'm a little swamped right now, but I'll try to review sometime this week
This is an automated message from
eerhardt commented on a change in pull request #7158:
URL: https://github.com/apache/arrow/pull/7158#discussion_r437755214
##
File path: csharp/test/Apache.Arrow.Tests/ArrowBufferBitmapBuilderTests.cs
##
@@ -0,0 +1,496 @@
+// Licensed to the Apache Software Foundation (ASF)
wesm commented on pull request #7382:
URL: https://github.com/apache/arrow/pull/7382#issuecomment-641612120
I added a bunch more unit tests, I think I'm done with this aside from CI
fixes and will move on to working on Filter
brills commented on pull request #7386:
URL: https://github.com/apache/arrow/pull/7386#issuecomment-641612258
hmm. I'm not sure if I want to fix the clang-format error. is there a way to
suppress it?
This is an automated
github-actions[bot] commented on pull request #7387:
URL: https://github.com/apache/arrow/pull/7387#issuecomment-641610654
https://issues.apache.org/jira/browse/ARROW-5377
This is an automated message from the Apache Git
lidavidm opened a new pull request #7387:
URL: https://github.com/apache/arrow/pull/7387
As discussed in #7299, this makes IpcPayload and related functions public,
and adds `arrow::ipc::GetPayloadSize`. It also adds a synthetic benchmark
comparing it to `GetRecordBatchSize`. (Obviously, a
lidavidm commented on pull request #7224:
URL: https://github.com/apache/arrow/pull/7224#issuecomment-641603882
Rebased to fix conflicts.
This is an automated message from the Apache Git Service.
To respond to the message,
nealrichardson commented on pull request #7281:
URL: https://github.com/apache/arrow/pull/7281#issuecomment-641602964
Maybe so; odd that Appveyor appears not to have run on the last commit here.
It looks like the failures are compression related, and Ben's last commit seems
to be trying
nealrichardson commented on a change in pull request #7350:
URL: https://github.com/apache/arrow/pull/7350#discussion_r437744005
##
File path: README.md
##
@@ -32,16 +32,24 @@ set of technologies that enable big data systems to process
and move data fast.
Major components
nealrichardson commented on a change in pull request #7350:
URL: https://github.com/apache/arrow/pull/7350#discussion_r437744150
##
File path: README.md
##
@@ -32,16 +32,24 @@ set of technologies that enable big data systems to process
and move data fast.
Major components
wesm edited a comment on pull request #7281:
URL: https://github.com/apache/arrow/pull/7281#issuecomment-641545625
appveyor is broken on master, not sure if this patch caused it. I compiled
on Windows locally and couldn't reproduce so may be transient
wesm commented on pull request #7281:
URL: https://github.com/apache/arrow/pull/7281#issuecomment-641545625
appveyor is broken on master, not sure if this patch caused it
This is an automated message from the Apache Git
pitrou commented on a change in pull request #7350:
URL: https://github.com/apache/arrow/pull/7350#discussion_r437682326
##
File path: docs/source/status.rst
##
@@ -0,0 +1,199 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license
nealrichardson commented on a change in pull request #7350:
URL: https://github.com/apache/arrow/pull/7350#discussion_r437677327
##
File path: docs/source/status.rst
##
@@ -0,0 +1,199 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor
github-actions[bot] commented on pull request #7386:
URL: https://github.com/apache/arrow/pull/7386#issuecomment-641532000
https://issues.apache.org/jira/browse/ARROW-9071
This is an automated message from the Apache Git
brills opened a new pull request #7386:
URL: https://github.com/apache/arrow/pull/7386
The child array of a ListArray of nulls should have length 0.
This is an automated message from the Apache Git Service.
To respond to
nevi-me commented on a change in pull request #7350:
URL: https://github.com/apache/arrow/pull/7350#discussion_r437653776
##
File path: docs/source/status.rst
##
@@ -0,0 +1,199 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license
jhorstmann commented on a change in pull request #7350:
URL: https://github.com/apache/arrow/pull/7350#discussion_r437649659
##
File path: docs/source/status.rst
##
@@ -0,0 +1,199 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license
pitrou commented on a change in pull request #7350:
URL: https://github.com/apache/arrow/pull/7350#discussion_r437642153
##
File path: docs/source/status.rst
##
@@ -0,0 +1,199 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license
pitrou commented on a change in pull request #7350:
URL: https://github.com/apache/arrow/pull/7350#discussion_r437641586
##
File path: docs/source/status.rst
##
@@ -0,0 +1,199 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license
pitrou commented on a change in pull request #7350:
URL: https://github.com/apache/arrow/pull/7350#discussion_r437641887
##
File path: docs/source/status.rst
##
@@ -0,0 +1,199 @@
+.. Licensed to the Apache Software Foundation (ASF) under one
+.. or more contributor license
pitrou commented on a change in pull request #7350:
URL: https://github.com/apache/arrow/pull/7350#discussion_r437641052
##
File path: README.md
##
@@ -32,16 +32,24 @@ set of technologies that enable big data systems to process
and move data fast.
Major components of the
wesm commented on pull request #7378:
URL: https://github.com/apache/arrow/pull/7378#issuecomment-641498953
My patch #7382 should not conflict with this so no need to worry about
rebasing
This is an automated message from
bkietz closed pull request #7281:
URL: https://github.com/apache/arrow/pull/7281
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nealrichardson closed issue #7385:
URL: https://github.com/apache/arrow/issues/7385
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
nealrichardson commented on issue #7385:
URL: https://github.com/apache/arrow/issues/7385#issuecomment-641472127
This appears to be a feature of how `data.matrix()` interacts with
`bit64::integer64` class objects. Here's a reprex without involving `arrow`:
```
> df <-
nealrichardson commented on a change in pull request #7350:
URL: https://github.com/apache/arrow/pull/7350#discussion_r437592494
##
File path: README.md
##
@@ -32,16 +32,24 @@ set of technologies that enable big data systems to process
and move data fast.
Major components
chutchinson commented on a change in pull request #7158:
URL: https://github.com/apache/arrow/pull/7158#discussion_r437591301
##
File path: csharp/src/Apache.Arrow/ArrowBuffer.Builder.cs
##
@@ -80,27 +140,63 @@ public Builder AppendRange(IEnumerable values)
chutchinson commented on a change in pull request #7158:
URL: https://github.com/apache/arrow/pull/7158#discussion_r437589084
##
File path: csharp/src/Apache.Arrow/ArrowBuffer.Builder.cs
##
@@ -80,27 +140,59 @@ public Builder AppendRange(IEnumerable values)
pitrou closed pull request #7383:
URL: https://github.com/apache/arrow/pull/7383
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pitrou closed pull request #7349:
URL: https://github.com/apache/arrow/pull/7349
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kszucs edited a comment on pull request #6512:
URL: https://github.com/apache/arrow/pull/6512#issuecomment-641411592
## Docker permission issue on linux
By default root is used within the container, thus the volumes get written
as root.
The only way to create docker volumes
wesm commented on a change in pull request #7382:
URL: https://github.com/apache/arrow/pull/7382#discussion_r437580946
##
File path: cpp/src/arrow/compute/kernels/vector_take.cc
##
@@ -38,44 +55,715 @@ std::unique_ptr InitTake(KernelContext*,
const KernelInitArgs& args
wesm edited a comment on pull request #7382:
URL: https://github.com/apache/arrow/pull/7382#issuecomment-641433457
OK, I have added more unit tests for the boundchecking code and added more
rigorous unit testing for string/fixed-size-binary types in
vector_take_test.cc. I'm going to get
wesm removed a comment on pull request #6682:
URL: https://github.com/apache/arrow/pull/6682#issuecomment-641438247
Could you ask this question on JIRA or the mailing list?
This is an automated message from the Apache Git
wesm commented on pull request #6682:
URL: https://github.com/apache/arrow/pull/6682#issuecomment-641438247
Could you ask this question on JIRA or the mailing list?
This is an automated message from the Apache Git Service.
rymurr commented on pull request #6682:
URL: https://github.com/apache/arrow/pull/6682#issuecomment-641438223
Hey @CosimoLovascio this has been un-deprecated in
https://github.com/apache/arrow/pull/7224
This is an automated
rezaeir opened a new issue #7385:
URL: https://github.com/apache/arrow/issues/7385
I'm new with using the arrow pacakge. my code is as follows:
```
# Python
import pandas as pd
df = pd.DataFrame(dict(a=[1,2], b=[3,4]))
df.to_feather('test.feather')
```
then
wesm commented on pull request #7382:
URL: https://github.com/apache/arrow/pull/7382#issuecomment-641433457
OK, I have added more unit tests for the boundchecking code and added more
rigorous unit testing for string/fixed-size-binary types in
vector_take_test.cc. I'm going to get the test
CosimoLovascio commented on pull request #6682:
URL: https://github.com/apache/arrow/pull/6682#issuecomment-641414712
Hi! I'm using CallHeaders interface to add some headers in the method's
implementation `onBeforeSendingHeaders(CallHeaders outgoingHeaders)` (inside a
Middleware).
wesm commented on pull request #7350:
URL: https://github.com/apache/arrow/pull/7350#issuecomment-641422970
Will review today
This is an automated message from the Apache Git Service.
To respond to the message, please log on
eerhardt commented on pull request #7158:
URL: https://github.com/apache/arrow/pull/7158#issuecomment-641395044
@mr-smidge - thanks for your patience. I wanted to know that I haven't
forgotten about this - I've just been really swamped in my day job. I will try
to get to this in the next
pitrou commented on pull request #7126:
URL: https://github.com/apache/arrow/pull/7126#issuecomment-640652236
We could also ping the Thrift community about a possible reimplementation of
this. This may not be a very complicated function...
pitrou commented on pull request #7349:
URL: https://github.com/apache/arrow/pull/7349#issuecomment-641322746
> Recognizing append mode as a "write" mode seems to work:
You'll have to check that writing indeed appends at the end rather than e.g.
truncating.
More generally,
wesm commented on pull request #7299:
URL: https://github.com/apache/arrow/pull/7299#issuecomment-641320413
I don't have a problem with it
This is an automated message from the Apache Git Service.
To respond to the message,
kyle-mccarthy commented on a change in pull request #7371:
URL: https://github.com/apache/arrow/pull/7371#discussion_r437013853
##
File path: rust/datafusion/src/execution/table_impl.rs
##
@@ -131,6 +132,11 @@ impl Table for TableImpl {
) -> Result> {
kszucs commented on a change in pull request #7341:
URL: https://github.com/apache/arrow/pull/7341#discussion_r437361312
##
File path: cpp/src/arrow/compute/kernels/codegen_internal.h
##
@@ -337,25 +337,6 @@ void ScalarPrimitiveExecUnary(KernelContext* ctx, const
ExecBatch&
kszucs commented on a change in pull request #7364:
URL: https://github.com/apache/arrow/pull/7364#discussion_r436995841
##
File path: ci/scripts/cpp_test.sh
##
@@ -32,13 +32,36 @@ export
LD_LIBRARY_PATH=${ARROW_HOME}/${CMAKE_INSTALL_LIBDIR:-lib}:${LD_LIBRARY_P
# to retrieve
wesm commented on pull request #7126:
URL: https://github.com/apache/arrow/pull/7126#issuecomment-640648593
That's annoying. I have a feeling we may end up vendoring and applying small
patches to Thrift eventually (it's "only" 18 KLOC). We could discuss on the
mailing list
kszucs commented on pull request #7374:
URL: https://github.com/apache/arrow/pull/7374#issuecomment-641256271
> I want to object this mass change because of the same reason as [#6590
(comment)](https://github.com/apache/arrow/pull/6590#issuecomment-607668777) .
>
> There are many CI
wesm edited a comment on pull request #7356:
URL: https://github.com/apache/arrow/pull/7356#issuecomment-640673030
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
lidavidm closed pull request #7354:
URL: https://github.com/apache/arrow/pull/7354
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
github-actions[bot] commented on pull request #7381:
URL: https://github.com/apache/arrow/pull/7381#issuecomment-640911219
https://issues.apache.org/jira/browse/ARROW-9074
This is an automated message from the Apache Git
jianxind commented on pull request #7314:
URL: https://github.com/apache/arrow/pull/7314#issuecomment-641109277
Just find a document(https://dl.acm.org/doi/pdf/10.1145/3178433.3178435 PAGE
7, Table 6: Comparison of various SIMD wrappers.) Some SIMD
helper(simdpp/xsimd) has performance
pitrou commented on a change in pull request #7373:
URL: https://github.com/apache/arrow/pull/7373#discussion_r436733347
##
File path: cpp/src/arrow/util/bitmap_ops.cc
##
@@ -298,52 +297,52 @@ void TransferBitmap(const uint8_t* data, int64_t offset,
int64_t length,
auto
kou commented on pull request #7363:
URL: https://github.com/apache/arrow/pull/7363#issuecomment-640942671
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
cyb70289 commented on pull request #7373:
URL: https://github.com/apache/arrow/pull/7373#issuecomment-640996230
RTools CI failure looks not related
https://github.com/apache/arrow/pull/7373/checks?check_run_id=752286352#step:7:1077
`error: failed retrieving file
wesm commented on a change in pull request #7356:
URL: https://github.com/apache/arrow/pull/7356#discussion_r436764326
##
File path: cpp/src/arrow/util/bit_block_counter.h
##
@@ -19,37 +19,108 @@
#include
+#include "arrow/util/bit_util.h"
+#include
github-actions[bot] commented on pull request #7378:
URL: https://github.com/apache/arrow/pull/7378#issuecomment-640813632
https://issues.apache.org/jira/browse/ARROW-8866
This is an automated message from the Apache Git
kszucs commented on pull request #7341:
URL: https://github.com/apache/arrow/pull/7341#issuecomment-640911140
Nice! Thanks for upgrading it!
This is an automated message from the Apache Git Service.
To respond to the
kou commented on pull request #7374:
URL: https://github.com/apache/arrow/pull/7374#issuecomment-640863115
I want to object this mass change because of the same reason as
https://github.com/apache/arrow/pull/6590#issuecomment-607668777 .
There are many CI failures with this mass
github-actions[bot] commented on pull request #7281:
URL: https://github.com/apache/arrow/pull/7281#issuecomment-641010768
https://issues.apache.org/jira/browse/ARROW-9046
This is an automated message from the Apache Git
1 - 100 of 180 matches
Mail list logo
