[GitHub] [arrow] kou closed pull request #7431: ARROW-9116: [C++][FOLLOWUP] Add 0-length test for BaseBinaryArray::total_values_length

2020-06-13 Thread GitBox
kou closed pull request #7431: URL: https://github.com/apache/arrow/pull/7431 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] sergeyt commented on pull request #7400: ARROW-9088: [Rust] Make prettyprint optional

2020-06-13 Thread GitBox
sergeyt commented on pull request #7400: URL: https://github.com/apache/arrow/pull/7400#issuecomment-643713603 @houqp `prettytable-rs` depends on `term` which depends on `dirs` which is causes error. actually `dirs` has [a code for

[GitHub] [arrow] github-actions[bot] commented on pull request #7431: ARROW-9116: [C++][FOLLOWUP] Add 0-length test for BaseBinaryArray::total_values_length

2020-06-13 Thread GitBox
github-actions[bot] commented on pull request #7431: URL: https://github.com/apache/arrow/pull/7431#issuecomment-643710945 https://issues.apache.org/jira/browse/ARROW-9116 This is an automated message from the Apache Git

[GitHub] [arrow] wesm opened a new pull request #7431: ARROW-9116: [C++][FOLLOWUP] Add 0-length test for BaseBinaryArray::total_values_length

2020-06-13 Thread GitBox
wesm opened a new pull request #7431: URL: https://github.com/apache/arrow/pull/7431 This also protects against the offsets buffer being null. This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] github-actions[bot] commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows

2020-06-13 Thread GitBox
github-actions[bot] commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-643703705 https://issues.apache.org/jira/browse/ARROW-9126 This is an automated message from the Apache Git

[GitHub] [arrow] ctring opened a new pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows

2020-06-13 Thread GitBox
ctring opened a new pull request #7430: URL: https://github.com/apache/arrow/pull/7430 In Linux, the configuration step of Boost allows selecting a subset of the libraries being built using the `--with-libraries=` flag. However, this flag does not exist in the configure script on Windows,

[GitHub] [arrow] scampi commented on a change in pull request #6402: ARROW-7831: [Java] do not allocate a new offset buffer if the slice starts at 0 since the relative offset pointer would be unchange

2020-06-13 Thread GitBox
scampi commented on a change in pull request #6402: URL: https://github.com/apache/arrow/pull/6402#discussion_r439778366 ## File path: java/vector/src/test/java/org/apache/arrow/vector/TestValueVector.java ## @@ -886,6 +886,65 @@ public void testNullableFixedType4() { *

[GitHub] [arrow] scampi commented on a change in pull request #6402: ARROW-7831: [Java] do not allocate a new offset buffer if the slice starts at 0 since the relative offset pointer would be unchange

2020-06-13 Thread GitBox
scampi commented on a change in pull request #6402: URL: https://github.com/apache/arrow/pull/6402#discussion_r439780145 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java ## @@ -740,10 +740,16 @@ private void

[GitHub] [arrow] scampi commented on pull request #6402: ARROW-7831: [Java] do not allocate a new offset buffer if the slice starts at 0 since the relative offset pointer would be unchanged

2020-06-13 Thread GitBox
scampi commented on pull request #6402: URL: https://github.com/apache/arrow/pull/6402#issuecomment-643699840 @wesm Thanks all for the comments. Please have a look again. This is an automated message from the Apache Git

[GitHub] [arrow] scampi commented on a change in pull request #6402: ARROW-7831: [Java] do not allocate a new offset buffer if the slice starts at 0 since the relative offset pointer would be unchange

2020-06-13 Thread GitBox
scampi commented on a change in pull request #6402: URL: https://github.com/apache/arrow/pull/6402#discussion_r439780145 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java ## @@ -740,10 +740,16 @@ private void

[GitHub] [arrow] kou closed pull request #7426: ARROW-9116: [C++] Add BaseBinaryArray::total_values_length

2020-06-13 Thread GitBox
kou closed pull request #7426: URL: https://github.com/apache/arrow/pull/7426 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] scampi commented on a change in pull request #6402: ARROW-7831: [Java] do not allocate a new offset buffer if the slice starts at 0 since the relative offset pointer would be unchange

2020-06-13 Thread GitBox
scampi commented on a change in pull request #6402: URL: https://github.com/apache/arrow/pull/6402#discussion_r439778366 ## File path: java/vector/src/test/java/org/apache/arrow/vector/TestValueVector.java ## @@ -886,6 +886,65 @@ public void testNullableFixedType4() { *

[GitHub] [arrow] kou closed pull request #7429: ARROW-9125: [C++] Add missing include for arrow::internal::ZeroMemory() for Valgrind

2020-06-13 Thread GitBox
kou closed pull request #7429: URL: https://github.com/apache/arrow/pull/7429 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] kou commented on pull request #7429: ARROW-9125: [C++] Add missing include for arrow::internal::ZeroMemory() for Valgrind

2020-06-13 Thread GitBox
kou commented on pull request #7429: URL: https://github.com/apache/arrow/pull/7429#issuecomment-643698751 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] scampi commented on a change in pull request #6402: ARROW-7831: [Java] do not allocate a new offset buffer if the slice starts at 0 since the relative offset pointer would be unchange

2020-06-13 Thread GitBox
scampi commented on a change in pull request #6402: URL: https://github.com/apache/arrow/pull/6402#discussion_r439778366 ## File path: java/vector/src/test/java/org/apache/arrow/vector/TestValueVector.java ## @@ -886,6 +886,65 @@ public void testNullableFixedType4() { *

[GitHub] [arrow] scampi commented on a change in pull request #6402: ARROW-7831: [Java] do not allocate a new offset buffer if the slice starts at 0 since the relative offset pointer would be unchange

2020-06-13 Thread GitBox
scampi commented on a change in pull request #6402: URL: https://github.com/apache/arrow/pull/6402#discussion_r439778364 ## File path: java/vector/src/test/java/org/apache/arrow/vector/TestValueVector.java ## @@ -886,6 +886,65 @@ public void testNullableFixedType4() { *

[GitHub] [arrow] github-actions[bot] commented on pull request #7429: ARROW-9125: [C++] Add missing include for arrow::internal::ZeroMemory() for Valgrind

2020-06-13 Thread GitBox
github-actions[bot] commented on pull request #7429: URL: https://github.com/apache/arrow/pull/7429#issuecomment-643694502 https://issues.apache.org/jira/browse/ARROW-9125 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #7429: ARROW-9125: [C++] Add missing include for arrow::internal::ZeroMemory() for Valgrind

2020-06-13 Thread GitBox
github-actions[bot] commented on pull request #7429: URL: https://github.com/apache/arrow/pull/7429#issuecomment-643694452 Revision: 8245d4bead7f7c4656de1d11dd2abc98410d8c21 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] kou commented on pull request #7429: ARROW-9125: [C++] Add missing include for arrow::internal::ZeroMemory() for Valgrind

2020-06-13 Thread GitBox
kou commented on pull request #7429: URL: https://github.com/apache/arrow/pull/7429#issuecomment-643694248 @github-actions crossbow submit test-conda-cpp-valgrind This is an automated message from the Apache Git Service. To

[GitHub] [arrow] kou opened a new pull request #7429: ARROW-9125: [C++] Add missing include for arrow::internal::ZeroMemory() for Valgrind

2020-06-13 Thread GitBox
kou opened a new pull request #7429: URL: https://github.com/apache/arrow/pull/7429 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] kou closed pull request #7427: ARROW-9123: [Python][wheel] Use libzstd.a explicitly

2020-06-13 Thread GitBox
kou closed pull request #7427: URL: https://github.com/apache/arrow/pull/7427 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] kou commented on pull request #7427: ARROW-9123: [Python][wheel] Use libzstd.a explicitly

2020-06-13 Thread GitBox
kou commented on pull request #7427: URL: https://github.com/apache/arrow/pull/7427#issuecomment-643691429 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] github-actions[bot] commented on pull request #7428: ARROW-9124: [Rust][Datafusion] optimize DFParser::parse_sql to take query string as

2020-06-13 Thread GitBox
github-actions[bot] commented on pull request #7428: URL: https://github.com/apache/arrow/pull/7428#issuecomment-643685126 https://issues.apache.org/jira/browse/ARROW-9124 This is an automated message from the Apache Git

[GitHub] [arrow] houqp commented on pull request #7400: ARROW-9088: [Rust] Make prettyprint optional

2020-06-13 Thread GitBox
houqp commented on pull request #7400: URL: https://github.com/apache/arrow/pull/7400#issuecomment-643684644 It's odd that a pretty print library would be have target specific issues :P This is an automated message from the

[GitHub] [arrow] houqp opened a new pull request #7428: ARROW-9124: [Rust][Datafusion] optimize DFParser::parse_sql to take query string as

2020-06-13 Thread GitBox
houqp opened a new pull request #7428: URL: https://github.com/apache/arrow/pull/7428 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] github-actions[bot] commented on pull request #7427: ARROW-9123: [Python][wheel] Use libzstd.a explicitly

2020-06-13 Thread GitBox
github-actions[bot] commented on pull request #7427: URL: https://github.com/apache/arrow/pull/7427#issuecomment-643683947 https://issues.apache.org/jira/browse/ARROW-9123 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #7427: ARROW-9123: [Python][wheel] Use libzstd.a explicitly

2020-06-13 Thread GitBox
github-actions[bot] commented on pull request #7427: URL: https://github.com/apache/arrow/pull/7427#issuecomment-643683599 Revision: 145fe31bd773518dcc408e2b46a749d060f6a32a Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] kou commented on pull request #7427: ARROW-9123: [Python][wheel] Use libzstd.a explicitly

2020-06-13 Thread GitBox
kou commented on pull request #7427: URL: https://github.com/apache/arrow/pull/7427#issuecomment-643683436 @github-actions crossbow submit -g wheel This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] kou opened a new pull request #7427: ARROW-9123: [Python][wheel] Use libzstd.a explicitly

2020-06-13 Thread GitBox
kou opened a new pull request #7427: URL: https://github.com/apache/arrow/pull/7427 ARROW_ZSTD_USE_SHARED is introduced by ARROW-9084. We need to set ARROW_ZSTD_USE_SHARED=OFF explicitly to use static zstd library. This

[GitHub] [arrow] github-actions[bot] commented on pull request #7426: ARROW-9116: [C++] Add BaseBinaryArray::total_values_length

2020-06-13 Thread GitBox
github-actions[bot] commented on pull request #7426: URL: https://github.com/apache/arrow/pull/7426#issuecomment-643674572 https://issues.apache.org/jira/browse/ARROW-9116 This is an automated message from the Apache Git

[GitHub] [arrow] wesm opened a new pull request #7426: ARROW-9116: [C++] Add BaseBinaryArray::total_values_length

2020-06-13 Thread GitBox
wesm opened a new pull request #7426: URL: https://github.com/apache/arrow/pull/7426 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] wesm commented on a change in pull request #7418: ARROW-9115: [C++] Implementation of ascii_lower/ascii_upper by processing input data buffers in batch

2020-06-13 Thread GitBox
wesm commented on a change in pull request #7418: URL: https://github.com/apache/arrow/pull/7418#discussion_r439765677 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -37,26 +39,108 @@ struct AsciiLength { } }; -struct AsciiUpper { - // XXX: the

[GitHub] [arrow] wesm commented on a change in pull request #7417: ARROW-9079: [C++] Write benchmark for arithmetic kernels

2020-06-13 Thread GitBox
wesm commented on a change in pull request #7417: URL: https://github.com/apache/arrow/pull/7417#discussion_r439765330 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_benchmark.cc ## @@ -67,89 +68,35 @@ static void ArrayArrayKernel(benchmark::State& state) {

[GitHub] [arrow] wesm commented on pull request #7417: ARROW-9079: [C++] Write benchmark for arithmetic kernels

2020-06-13 Thread GitBox
wesm commented on pull request #7417: URL: https://github.com/apache/arrow/pull/7417#issuecomment-643671002 +1. I fixed a few lingering issues that jumped out at me, will merge this once build passes This is an automated

[GitHub] [arrow] wesm commented on a change in pull request #7417: ARROW-9079: [C++] Write benchmark for arithmetic kernels

2020-06-13 Thread GitBox
wesm commented on a change in pull request #7417: URL: https://github.com/apache/arrow/pull/7417#discussion_r439765195 ## File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_benchmark.cc ## @@ -0,0 +1,92 @@ +// Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [arrow] wesm closed issue #7425: feature request: google cloud storage [GCS] filesystem backend

2020-06-13 Thread GitBox
wesm closed issue #7425: URL: https://github.com/apache/arrow/issues/7425 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] wesm commented on issue #7425: feature request: google cloud storage [GCS] filesystem backend

2020-06-13 Thread GitBox
wesm commented on issue #7425: URL: https://github.com/apache/arrow/issues/7425#issuecomment-643669698 We track our granular roadmap on JIRA, here is the issue that's already open https://issues.apache.org/jira/browse/ARROW-1231

[GitHub] [arrow] bobcolner opened a new issue #7425: feature request: google cloud storage [GCS] filesystem backend

2020-06-13 Thread GitBox
bobcolner opened a new issue #7425: URL: https://github.com/apache/arrow/issues/7425 Hi, I'm new. Looking for the correct place to request a google cloud storage [GCS] filesystem backend? Thanks! This

[GitHub] [arrow] wesm commented on a change in pull request #7418: ARROW-9115: [C++] Implementation of ascii_lower/ascii_upper by processing input data buffers in batch

2020-06-13 Thread GitBox
wesm commented on a change in pull request #7418: URL: https://github.com/apache/arrow/pull/7418#discussion_r439755593 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -37,26 +39,108 @@ struct AsciiLength { } }; -struct AsciiUpper { - // XXX: the

[GitHub] [arrow] pierrebelzile commented on a change in pull request #7418: ARROW-9115: [C++] Implementation of ascii_lower/ascii_upper by processing input data buffers in batch

2020-06-13 Thread GitBox
pierrebelzile commented on a change in pull request #7418: URL: https://github.com/apache/arrow/pull/7418#discussion_r439754427 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -37,26 +39,108 @@ struct AsciiLength { } }; -struct AsciiUpper { - // XXX:

[GitHub] [arrow] wesm closed pull request #6806: ARROW-8312: [Java][Gandiva] support TreeNode in IN expression

2020-06-13 Thread GitBox
wesm closed pull request #6806: URL: https://github.com/apache/arrow/pull/6806 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] wesm commented on pull request #6806: ARROW-8312: [Java][Gandiva] support TreeNode in IN expression

2020-06-13 Thread GitBox
wesm commented on pull request #6806: URL: https://github.com/apache/arrow/pull/6806#issuecomment-643624781 Thank you This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] wesm commented on a change in pull request #7410: ARROW-971: [C++][Compute] IsValid, IsNull kernels

2020-06-13 Thread GitBox
wesm commented on a change in pull request #7410: URL: https://github.com/apache/arrow/pull/7410#discussion_r439739768 ## File path: cpp/src/arrow/compute/kernels/scalar_validity.cc ## @@ -0,0 +1,97 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more