[GitHub] [arrow] emkornfield commented on pull request #7578: ARROW-9264: [C++][Parquet] Refactor and modernize schema conversion code

2020-06-28 Thread GitBox
emkornfield commented on pull request #7578: URL: https://github.com/apache/arrow/pull/7578#issuecomment-650898648 resolved the change and redid the removal of the variable cleanup. This is an automated message from the

[GitHub] [arrow] wesm closed pull request #7547: ARROW-8950: [C++] Avoid HEAD when possible in S3 filesystem

2020-06-28 Thread GitBox
wesm closed pull request #7547: URL: https://github.com/apache/arrow/pull/7547 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] wesm commented on pull request #7578: ARROW-9264: [C++][Parquet] Refactor and modernize schema conversion code

2020-06-28 Thread GitBox
wesm commented on pull request #7578: URL: https://github.com/apache/arrow/pull/7578#issuecomment-650893956 Great, I'll review tomorrow. The PR I just merged https://github.com/apache/arrow/commit/cca2db1cfb12bb12a4c018dcf60796352b27f1e2 caused a small conflict so you may need to manually

[GitHub] [arrow] wesm closed pull request #7577: ARROW-8980: [Python] Ensure that ARROW:schema metadata key is scrubbed when converting Parquet schema back to Arrow schema

2020-06-28 Thread GitBox
wesm closed pull request #7577: URL: https://github.com/apache/arrow/pull/7577 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] wesm commented on pull request #7577: ARROW-8980: [Python] Ensure that ARROW:schema metadata key is scrubbed when converting Parquet schema back to Arrow schema

2020-06-28 Thread GitBox
wesm commented on pull request #7577: URL: https://github.com/apache/arrow/pull/7577#issuecomment-650893647 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] github-actions[bot] commented on pull request #7578: ARROW-9264: [C++][Parquet] Refactor and modernize schema conversion code

2020-06-28 Thread GitBox
github-actions[bot] commented on pull request #7578: URL: https://github.com/apache/arrow/pull/7578#issuecomment-650889205 https://issues.apache.org/jira/browse/ARROW-9264 This is an automated message from the Apache Git

[GitHub] [arrow] emkornfield commented on pull request #7578: ARROW-9264: [C++][Parquet] Refactor and modernize schema conversion code

2020-06-28 Thread GitBox
emkornfield commented on pull request #7578: URL: https://github.com/apache/arrow/pull/7578#issuecomment-650885965 CC @wesm This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] emkornfield opened a new pull request #7578: ARROW-9264: [C++][Parquet] Refactor and modernize schema conversion code

2020-06-28 Thread GitBox
emkornfield opened a new pull request #7578: URL: https://github.com/apache/arrow/pull/7578 Split this off from ARROW-8493 because enough code moved around to warrant a review without other functional changes. - Rename max_ to either current_ or removed entirely - During

[GitHub] [arrow] bkietz commented on pull request #7536: ARROW-8647: [C++][Python][Dataset] Allow partitioning fields to be inferred with dictionary type

2020-06-28 Thread GitBox
bkietz commented on pull request #7536: URL: https://github.com/apache/arrow/pull/7536#issuecomment-650885378 Int32 indices are now used whatever the dictionary size This is an automated message from the Apache Git Service.

[GitHub] [arrow] jianxind commented on pull request #7576: ARROW-9263: [C++] Promote compute aggregate benchmark size to 1M.

2020-06-28 Thread GitBox
jianxind commented on pull request #7576: URL: https://github.com/apache/arrow/pull/7576#issuecomment-650877595 > We should probably not share such parameters outside of the scope of a single benchmark executable, otherwise such changes make the benchmark results before/after not

[GitHub] [arrow] github-actions[bot] commented on pull request #7535: ARROW-9222: [Format][DONOTMERGE] Columnar.rst changes for removing validity bitmap from union types

2020-06-28 Thread GitBox
github-actions[bot] commented on pull request #7535: URL: https://github.com/apache/arrow/pull/7535#issuecomment-650876518 https://issues.apache.org/jira/browse/ARROW-9222 This is an automated message from the Apache Git

[GitHub] [arrow] wesm closed pull request #7574: ARROW-9233: [C++] Add NullType code paths for is_valid, is_null kernels

2020-06-28 Thread GitBox
wesm closed pull request #7574: URL: https://github.com/apache/arrow/pull/7574 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] wesm commented on pull request #7574: ARROW-9233: [C++] Add NullType code paths for is_valid, is_null kernels

2020-06-28 Thread GitBox
wesm commented on pull request #7574: URL: https://github.com/apache/arrow/pull/7574#issuecomment-650873889 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] github-actions[bot] commented on pull request #7577: ARROW-8980: [Python] Ensure that ARROW:schema metadata key is scrubbed when converting Parquet schema back to Arrow schema

2020-06-28 Thread GitBox
github-actions[bot] commented on pull request #7577: URL: https://github.com/apache/arrow/pull/7577#issuecomment-650872224 https://issues.apache.org/jira/browse/ARROW-8980 This is an automated message from the Apache Git

[GitHub] [arrow] wesm commented on pull request #7576: ARROW-9263: [C++] Promote RegressionSetArgs size to L2.

2020-06-28 Thread GitBox
wesm commented on pull request #7576: URL: https://github.com/apache/arrow/pull/7576#issuecomment-650871322 We should probably not share such parameters outside of the scope of a single benchmark executable, otherwise such changes make the benchmark results before/after not comparable

[GitHub] [arrow] wesm opened a new pull request #7577: ARROW-8980: [Python] Ensure that ARROW:schema metadata key is scrubbed when converting Parquet schema back to Arrow schema

2020-06-28 Thread GitBox
wesm opened a new pull request #7577: URL: https://github.com/apache/arrow/pull/7577 This was already being worked around in some unit tests... This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] wesm closed pull request #7575: ARROW-8671: [C++][FOLLOWUP] Fix ASAN/UBSAN bug found with IPC fuzz testing files

2020-06-28 Thread GitBox
wesm closed pull request #7575: URL: https://github.com/apache/arrow/pull/7575 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] wesm commented on pull request #7575: ARROW-8671: [C++][FOLLOWUP] Fix ASAN/UBSAN bug found with IPC fuzz testing files

2020-06-28 Thread GitBox
wesm commented on pull request #7575: URL: https://github.com/apache/arrow/pull/7575#issuecomment-650870541 +1, merging to fix master This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] wesm commented on pull request #7557: ARROW-9251: [C++] Relocate integration testing JSON code implementation to src/arrow/testing

2020-06-28 Thread GitBox
wesm commented on pull request #7557: URL: https://github.com/apache/arrow/pull/7557#issuecomment-650866076 +1. The ASAN/UBSAN failure is fixed by https://github.com/apache/arrow/pull/7575 This is an automated message from

[GitHub] [arrow] wesm closed pull request #7557: ARROW-9251: [C++] Relocate integration testing JSON code implementation to src/arrow/testing

2020-06-28 Thread GitBox
wesm closed pull request #7557: URL: https://github.com/apache/arrow/pull/7557 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] github-actions[bot] commented on pull request #7574: ARROW-9233: [C++] Add NullType code paths for is_valid, is_null kernels

2020-06-28 Thread GitBox
github-actions[bot] commented on pull request #7574: URL: https://github.com/apache/arrow/pull/7574#issuecomment-650865623 https://issues.apache.org/jira/browse/ARROW-9233 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #7575: ARROW-8671: [C++][FOLLOWUP] Fix ASAN/UBSAN bug found with IPC fuzz testing files

2020-06-28 Thread GitBox
github-actions[bot] commented on pull request #7575: URL: https://github.com/apache/arrow/pull/7575#issuecomment-650865625 https://issues.apache.org/jira/browse/ARROW-8671 This is an automated message from the Apache Git

[GitHub] [arrow] jianxind closed pull request #7314: ARROW-8996: [C++] AVX2/AVX512 runtime support for aggregate sum kernel

2020-06-28 Thread GitBox
jianxind closed pull request #7314: URL: https://github.com/apache/arrow/pull/7314 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] github-actions[bot] commented on pull request #7576: ARROW-9263: [C++] Promote RegressionSetArgs size to L2.

2020-06-28 Thread GitBox
github-actions[bot] commented on pull request #7576: URL: https://github.com/apache/arrow/pull/7576#issuecomment-650865622 https://issues.apache.org/jira/browse/ARROW-9263 This is an automated message from the Apache Git

[GitHub] [arrow] jianxind commented on pull request #7314: ARROW-8996: [C++] AVX2/AVX512 runtime support for aggregate sum kernel

2020-06-28 Thread GitBox
jianxind commented on pull request #7314: URL: https://github.com/apache/arrow/pull/7314#issuecomment-650865605 Close this one as reference of intrinsic. I will try to work out a new approach without intrinsic. This is an

[GitHub] [arrow] jianxind opened a new pull request #7576: ARROW-9263: [C++] Promote RegressionSetArgs size to L2.

2020-06-28 Thread GitBox
jianxind opened a new pull request #7576: URL: https://github.com/apache/arrow/pull/7576 The 0.01% null probability on L1 size(usually 32k) generate all true values for double/float type, set size to L2. Signed-off-by: Frank Du

[GitHub] [arrow] wesm opened a new pull request #7575: ARROW-8671: [C++][FOLLOWUP] Fix ASAN/UBSAN bug found with IPC fuzz testing files

2020-06-28 Thread GitBox
wesm opened a new pull request #7575: URL: https://github.com/apache/arrow/pull/7575 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] wesm opened a new pull request #7574: ARROW-9233: [C++] Add NullType code paths for is_valid, is_null kernels

2020-06-28 Thread GitBox
wesm opened a new pull request #7574: URL: https://github.com/apache/arrow/pull/7574 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] wesm commented on pull request #7571: ARROW-8671: [C++] Use new BodyCompression Flatbuffers member for IPC compression metadata

2020-06-28 Thread GitBox
wesm commented on pull request #7571: URL: https://github.com/apache/arrow/pull/7571#issuecomment-650857082 This has an ASAN/UBSAN failure. I will fix within an hour This is an automated message from the Apache Git Service.

[GitHub] [arrow] kou closed pull request #7573: ARROW-9262: [Packaging][Linux][CI] Use Ubuntu 18.04 to build ARM64 packages on Travis CI

2020-06-28 Thread GitBox
kou closed pull request #7573: URL: https://github.com/apache/arrow/pull/7573 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] kou commented on pull request #7573: ARROW-9262: [Packaging][Linux][CI] Use Ubuntu 18.04 to build ARM64 packages on Travis CI

2020-06-28 Thread GitBox
kou commented on pull request #7573: URL: https://github.com/apache/arrow/pull/7573#issuecomment-650837500 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] nealrichardson commented on a change in pull request #7514: ARROW-6235: [R] Implement conversion from arrow::BinaryArray to R character vector

2020-06-28 Thread GitBox
nealrichardson commented on a change in pull request #7514: URL: https://github.com/apache/arrow/pull/7514#discussion_r446706140 ## File path: r/src/array_from_vector.cpp ## @@ -918,6 +923,97 @@ class Time64Converter : public TimeConverter { } }; +template +class

[GitHub] [arrow] wesm closed pull request #7561: ARROW-9254: [C++] Split out CastNumberToNumberUnsafe function from scalar_cast_numeric, add data()/mutable_data() functions for accessing primitive sca

2020-06-28 Thread GitBox
wesm closed pull request #7561: URL: https://github.com/apache/arrow/pull/7561 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] wesm commented on pull request #7571: ARROW-8671: [C++] Use new BodyCompression Flatbuffers member for IPC compression metadata

2020-06-28 Thread GitBox
wesm commented on pull request #7571: URL: https://github.com/apache/arrow/pull/7571#issuecomment-650830163 Oops, I didn't mean to merge this patch, sorry! Please review it and I will address any code reviews as follow up

[GitHub] [arrow] wesm closed pull request #7571: ARROW-8671: [C++] Use new BodyCompression Flatbuffers member for IPC compression metadata

2020-06-28 Thread GitBox
wesm closed pull request #7571: URL: https://github.com/apache/arrow/pull/7571 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] wesm commented on pull request #7571: ARROW-8671: [C++] Use new BodyCompression Flatbuffers member for IPC compression metadata

2020-06-28 Thread GitBox
wesm commented on pull request #7571: URL: https://github.com/apache/arrow/pull/7571#issuecomment-650829722 I confirmed that I can read compressed files (including compressed dictionaries) generated from master This is an

[GitHub] [arrow] wesm commented on pull request #7561: ARROW-9254: [C++] Split out CastNumberToNumberUnsafe function from scalar_cast_numeric, add data()/mutable_data() functions for accessing primiti

2020-06-28 Thread GitBox
wesm commented on pull request #7561: URL: https://github.com/apache/arrow/pull/7561#issuecomment-650829682 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] wesm commented on pull request #7572: ARROW-9260: [CI] Fix non amd64 job failures with Ubuntu 14.04 and 20.04

2020-06-28 Thread GitBox
wesm commented on pull request #7572: URL: https://github.com/apache/arrow/pull/7572#issuecomment-650828492 Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] kszucs commented on pull request #7439: ARROW-4309: [Documentation] Add a docker-compose entry which builds the documentation with CUDA enabled

2020-06-28 Thread GitBox
kszucs commented on pull request #7439: URL: https://github.com/apache/arrow/pull/7439#issuecomment-650826896 Thanks @kou for fixing it! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] kou closed pull request #7572: ARROW-9260: [CI] Fix non amd64 job failures with Ubuntu 14.04 and 20.04

2020-06-28 Thread GitBox
kou closed pull request #7572: URL: https://github.com/apache/arrow/pull/7572 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] kou commented on pull request #7572: ARROW-9260: [CI] Fix non amd64 job failures with Ubuntu 14.04 and 20.04

2020-06-28 Thread GitBox
kou commented on pull request #7572: URL: https://github.com/apache/arrow/pull/7572#issuecomment-650825705 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] github-actions[bot] commented on pull request #7573: ARROW-9262: [Packaging][Linux][CI] Use Ubuntu 18.04 to build ARM64 packages on Travis CI

2020-06-28 Thread GitBox
github-actions[bot] commented on pull request #7573: URL: https://github.com/apache/arrow/pull/7573#issuecomment-650823047 Revision: ce166dbd01320d6f4cf3eba9f7c961e97dbba384 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] kou commented on pull request #7573: ARROW-9262: [Packaging][Linux][CI] Use Ubuntu 18.04 to build ARM64 packages on Travis CI

2020-06-28 Thread GitBox
kou commented on pull request #7573: URL: https://github.com/apache/arrow/pull/7573#issuecomment-650822793 @github-actions crossbow submit -g linux-arm64 This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #7573: ARROW-9262: [Packaging][Linux][CI] Use Ubuntu 18.04 to build ARM64 packages on Travis CI

2020-06-28 Thread GitBox
github-actions[bot] commented on pull request #7573: URL: https://github.com/apache/arrow/pull/7573#issuecomment-650822868 https://issues.apache.org/jira/browse/ARROW-9262 This is an automated message from the Apache Git

[GitHub] [arrow] kou opened a new pull request #7573: [Packaging][Linux][CI] Use Ubuntu 18.04 to build ARM64 packages on Travis CI

2020-06-28 Thread GitBox
kou opened a new pull request #7573: URL: https://github.com/apache/arrow/pull/7573 We got the following error with Ubuntu 20.04: gpg: Fatal: can't disable core dumps: Operation not permitted This is an automated

[GitHub] [arrow] kou commented on pull request #7439: ARROW-4309: [Documentation] Add a docker-compose entry which builds the documentation with CUDA enabled

2020-06-28 Thread GitBox
kou commented on pull request #7439: URL: https://github.com/apache/arrow/pull/7439#issuecomment-650822114 The Travis CI failures disabled by https://github.com/apache/arrow/pull/7552 is caused by this. The ARM64v8 CI failure disabled by https://github.com/apache/arrow/pull/7570 is

[GitHub] [arrow] github-actions[bot] commented on pull request #7572: ARROW-9260: [CI] Fix non amd64 job failures with Ubuntu 14.04 and 20.04

2020-06-28 Thread GitBox
github-actions[bot] commented on pull request #7572: URL: https://github.com/apache/arrow/pull/7572#issuecomment-650821692 https://issues.apache.org/jira/browse/ARROW-9260 This is an automated message from the Apache Git

[GitHub] [arrow] kou opened a new pull request #7572: ARROW-9260: [CI] Fix non amd64 job failures with Ubuntu 14.04 and 20.04

2020-06-28 Thread GitBox
kou opened a new pull request #7572: URL: https://github.com/apache/arrow/pull/7572 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] github-actions[bot] commented on pull request #7571: ARROW-8671: [C++] Use new BodyCompression Flatbuffers member for IPC compression metadata

2020-06-28 Thread GitBox
github-actions[bot] commented on pull request #7571: URL: https://github.com/apache/arrow/pull/7571#issuecomment-650809427 https://issues.apache.org/jira/browse/ARROW-8671 This is an automated message from the Apache Git

[GitHub] [arrow] wesm merged pull request #7570: ARROW-9260: [CI][TRIAGE] Disable self-hosted builds until ARM64v8 build can be fixed

2020-06-28 Thread GitBox
wesm merged pull request #7570: URL: https://github.com/apache/arrow/pull/7570 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] wesm commented on pull request #7570: ARROW-9260: [CI][TRIAGE] Disable self-hosted builds until ARM64v8 build can be fixed

2020-06-28 Thread GitBox
wesm commented on pull request #7570: URL: https://github.com/apache/arrow/pull/7570#issuecomment-650804456 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] github-actions[bot] commented on pull request #7570: ARROW-9260: [CI][TRIAGE] Disable self-hosted builds until ARM64v8 build can be fixed

2020-06-28 Thread GitBox
github-actions[bot] commented on pull request #7570: URL: https://github.com/apache/arrow/pull/7570#issuecomment-650804358 https://issues.apache.org/jira/browse/ARROW-9260 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #7569: ARROW-9152: [C++] Specialized implementation of filtering Binary/LargeBinary-based types

2020-06-28 Thread GitBox
github-actions[bot] commented on pull request #7569: URL: https://github.com/apache/arrow/pull/7569#issuecomment-650804359 https://issues.apache.org/jira/browse/ARROW-9152 This is an automated message from the Apache Git

[GitHub] [arrow] wesm opened a new pull request #7570: ARROW-9260: [CI][TRIAGE] Disable self-hosted builds until ARM64v8 build can be fixed

2020-06-28 Thread GitBox
wesm opened a new pull request #7570: URL: https://github.com/apache/arrow/pull/7570 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [arrow] wesm commented on pull request #7569: ARROW-9152: [C++] Specialized implementation of filtering Binary/LargeBinary-based types

2020-06-28 Thread GitBox
wesm commented on pull request #7569: URL: https://github.com/apache/arrow/pull/7569#issuecomment-650803803 Benchmarks on gcc-8 ``` benchmark baselinecontender change %

[GitHub] [arrow] wesm opened a new pull request #7569: ARROW-9152: [C++] Specialized implementation of filtering Binary/LargeBinary-based types

2020-06-28 Thread GitBox
wesm opened a new pull request #7569: URL: https://github.com/apache/arrow/pull/7569 Improve performance with streamlined implementation with bulk appends for the non-null/all-selected case. Benchmarks to follow This is an

[GitHub] [arrow] wesm commented on pull request #7560: ARROW-9252: [Integration] Factor out IPC integration tests into script, add back 0.14.1 "gold" files

2020-06-28 Thread GitBox
wesm commented on pull request #7560: URL: https://github.com/apache/arrow/pull/7560#issuecomment-650789278 Sure, that sounds good This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [arrow] emkornfield commented on pull request #7560: ARROW-9252: [Integration] Factor out IPC integration tests into script, add back 0.14.1 "gold" files

2020-06-28 Thread GitBox
emkornfield commented on pull request #7560: URL: https://github.com/apache/arrow/pull/7560#issuecomment-650789140 No, IIRC I think I hacked integration tests to generate smaller files then looped over them with one of the binaries. I can try to come up with something to update the json

[GitHub] [arrow] github-actions[bot] commented on pull request #7568: ARROW-9241: [C++] Add forward compatibility check for Decimal bit width

2020-06-28 Thread GitBox
github-actions[bot] commented on pull request #7568: URL: https://github.com/apache/arrow/pull/7568#issuecomment-650783849 https://issues.apache.org/jira/browse/ARROW-9241 This is an automated message from the Apache Git

[GitHub] [arrow] wesm opened a new pull request #7568: ARROW-9241: [C++] Add forward compatibility check for Decimal bit width

2020-06-28 Thread GitBox
wesm opened a new pull request #7568: URL: https://github.com/apache/arrow/pull/7568 Also updates the generated Flatbuffers bindings. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] github-actions[bot] commented on pull request #7567: ARROW-9259: [Format][DONOTMERGE] Add language indicating that unsigned dictionary indices are supported but that signed integers a

2020-06-28 Thread GitBox
github-actions[bot] commented on pull request #7567: URL: https://github.com/apache/arrow/pull/7567#issuecomment-650781105 https://issues.apache.org/jira/browse/ARROW-9259 This is an automated message from the Apache Git

[GitHub] [arrow] wesm opened a new pull request #7567: ARROW-9259: [Format][DONOTMERGE] Add language indicating that unsigned dictionary indices are supported but that signed integers are preferred

2020-06-28 Thread GitBox
wesm opened a new pull request #7567: URL: https://github.com/apache/arrow/pull/7567 This does not alter the format metadata in any way but has implications for the reference implementations (e.g. C++ currently rejects unsigned integer indices).

[GitHub] [arrow] github-actions[bot] commented on pull request #7566: ARROW-9258: [FORMAT][DONOTMERGE] Add V5 MetadataVersion to Schema.fbs

2020-06-28 Thread GitBox
github-actions[bot] commented on pull request #7566: URL: https://github.com/apache/arrow/pull/7566#issuecomment-650778344 https://issues.apache.org/jira/browse/ARROW-9258 This is an automated message from the Apache Git

[GitHub] [arrow] wesm opened a new pull request #7566: [FORMAT][DONOTMERGE] Add V5 MetadataVersion to Schema.fbs

2020-06-28 Thread GitBox
wesm opened a new pull request #7566: URL: https://github.com/apache/arrow/pull/7566 Per mailing list discussion This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[GitHub] [arrow] wesm commented on pull request #7560: ARROW-9252: [Integration] Factor out IPC integration tests into script, add back 0.14.1 "gold" files

2020-06-28 Thread GitBox
wesm commented on pull request #7560: URL: https://github.com/apache/arrow/pull/7560#issuecomment-650774989 @emkornfield looks like almost none of the 0.14.1 "gold" files can be read anymore because of the change to represent int64 values as strings. We should prepare a set of gold files

[GitHub] [arrow] wesm closed pull request #7558: ARROW-9250: [C++] Instantiate fewer templates in IsIn, Match kernel implementations

2020-06-28 Thread GitBox
wesm closed pull request #7558: URL: https://github.com/apache/arrow/pull/7558 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] wesm commented on pull request #7558: ARROW-9250: [C++] Instantiate fewer templates in IsIn, Match kernel implementations

2020-06-28 Thread GitBox
wesm commented on pull request #7558: URL: https://github.com/apache/arrow/pull/7558#issuecomment-650771972 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] wesm closed pull request #7562: ARROW-7273: [Python][C++][Parquet] Do not permit constructing a non-nullable null field in Python, catch this case in Arrow->Parquet schema conversion

2020-06-28 Thread GitBox
wesm closed pull request #7562: URL: https://github.com/apache/arrow/pull/7562 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] wesm commented on pull request #7562: ARROW-7273: [Python][C++][Parquet] Do not permit constructing a non-nullable null field in Python, catch this case in Arrow->Parquet schema conve

2020-06-28 Thread GitBox
wesm commented on pull request #7562: URL: https://github.com/apache/arrow/pull/7562#issuecomment-650771512 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] wesm closed pull request #7563: ARROW-8888: [Python] Do not use thread pool when converting pandas columns that are definitely zero-copyable

2020-06-28 Thread GitBox
wesm closed pull request #7563: URL: https://github.com/apache/arrow/pull/7563 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] wesm commented on pull request #7563: ARROW-8888: [Python] Do not use thread pool when converting pandas columns that are definitely zero-copyable

2020-06-28 Thread GitBox
wesm commented on pull request #7563: URL: https://github.com/apache/arrow/pull/7563#issuecomment-650771306 +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] liyafan82 commented on pull request #7347: ARROW-8230: [Java] Remove netty dependency from arrow-memory

2020-06-28 Thread GitBox
liyafan82 commented on pull request #7347: URL: https://github.com/apache/arrow/pull/7347#issuecomment-650739545 Mostly looks good to me. There are a few minor issues. Since it involves some fundamental classes, could you please make sure our integration tests pass? @rymurr

[GitHub] [arrow] liyafan82 commented on a change in pull request #7347: ARROW-8230: [Java] Remove netty dependency from arrow-memory

2020-06-28 Thread GitBox
liyafan82 commented on a change in pull request #7347: URL: https://github.com/apache/arrow/pull/7347#discussion_r446639368 ## File path: java/memory/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java ## @@ -95,4 +143,26 @@ public static long

[GitHub] [arrow] liyafan82 commented on a change in pull request #7347: ARROW-8230: [Java] Remove netty dependency from arrow-memory

2020-06-28 Thread GitBox
liyafan82 commented on a change in pull request #7347: URL: https://github.com/apache/arrow/pull/7347#discussion_r446626385 ## File path: java/memory/src/main/java/org/apache/arrow/memory/util/MemoryUtil.java ## @@ -78,6 +77,55 @@ public Object run() { Field

[GitHub] [arrow] liyafan82 commented on a change in pull request #7347: ARROW-8230: [Java] Remove netty dependency from arrow-memory

2020-06-28 Thread GitBox
liyafan82 commented on a change in pull request #7347: URL: https://github.com/apache/arrow/pull/7347#discussion_r446617744 ## File path: java/memory/src/main/java/org/apache/arrow/memory/rounding/DefaultRoundingPolicy.java ## @@ -17,33 +17,107 @@ package

[GitHub] [arrow] liyafan82 commented on a change in pull request #7347: ARROW-8230: [Java] Remove netty dependency from arrow-memory

2020-06-28 Thread GitBox
liyafan82 commented on a change in pull request #7347: URL: https://github.com/apache/arrow/pull/7347#discussion_r446617676 ## File path: java/memory/src/main/java/org/apache/arrow/memory/rounding/DefaultRoundingPolicy.java ## @@ -17,33 +17,107 @@ package

[GitHub] [arrow] kou closed pull request #7565: ARROW-9256: [C++] Incorrect variable name ARROW_CXX_FLAGS

2020-06-28 Thread GitBox
kou closed pull request #7565: URL: https://github.com/apache/arrow/pull/7565 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] liyafan82 commented on pull request #7544: ARROW-7285: [C++] ensure C++ implementation meets clarified dictionary spec

2020-06-28 Thread GitBox
liyafan82 commented on pull request #7544: URL: https://github.com/apache/arrow/pull/7544#issuecomment-650709228 @pitrou Thanks a lot for your attention. I think it is ready for review now. This is an automated message

[GitHub] [arrow] Ktakuya332C commented on a change in pull request #7565: ARROW-9256: [C++] Incorrect variable name ARROW_CXX_FLAGS

2020-06-28 Thread GitBox
Ktakuya332C commented on a change in pull request #7565: URL: https://github.com/apache/arrow/pull/7565#discussion_r446610914 ## File path: cpp/CMakeLists.txt ## @@ -472,7 +472,7 @@ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${ARROW_CXXFLAGS}") # For any C code, use the same

[GitHub] [arrow] kou commented on a change in pull request #7565: ARROW-9256: [C++] Incorrect variable name ARROW_CXX_FLAGS

2020-06-28 Thread GitBox
kou commented on a change in pull request #7565: URL: https://github.com/apache/arrow/pull/7565#discussion_r446609892 ## File path: cpp/CMakeLists.txt ## @@ -472,7 +472,7 @@ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} ${ARROW_CXXFLAGS}") # For any C code, use the same flags.

[GitHub] [arrow] github-actions[bot] commented on pull request #7565: ARROW-9256: [C++] Incorrect variable name ARROW_CXX_FLAGS

2020-06-28 Thread GitBox
github-actions[bot] commented on pull request #7565: URL: https://github.com/apache/arrow/pull/7565#issuecomment-650706362 https://issues.apache.org/jira/browse/ARROW-9256 This is an automated message from the Apache Git

[GitHub] [arrow] Ktakuya332C opened a new pull request #7565: ARROW-9256: [C++] Incorrect variable name ARROW_CXX_FLAGS

2020-06-28 Thread GitBox
Ktakuya332C opened a new pull request #7565: URL: https://github.com/apache/arrow/pull/7565 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above