github-actions[bot] commented on pull request #7672:
URL: https://github.com/apache/arrow/pull/7672#issuecomment-655295896
https://issues.apache.org/jira/browse/ARROW-9348
This is an automated message from the Apache Git
arw2019 opened a new pull request #7672:
URL: https://github.com/apache/arrow/pull/7672
This PR addresses https://issues.apache.org/jira/browse/ARROW-9348
This is an automated message from the Apache Git Service.
To respond
houqp commented on a change in pull request #7666:
URL: https://github.com/apache/arrow/pull/7666#discussion_r451278084
##
File path: rust/arrow/src/record_batch.rs
##
@@ -216,15 +216,28 @@ impl Into for RecordBatch {
}
}
-/// Definition of record batch reader.
+///
houqp commented on a change in pull request #7666:
URL: https://github.com/apache/arrow/pull/7666#discussion_r451273911
##
File path: rust/datafusion/src/datasource/datasource.rs
##
@@ -20,13 +20,13 @@
use std::sync::{Arc, Mutex};
use arrow::datatypes::Schema;
+use
houqp commented on a change in pull request #7666:
URL: https://github.com/apache/arrow/pull/7666#discussion_r451273265
##
File path: rust/arrow/src/record_batch.rs
##
@@ -216,15 +216,28 @@ impl Into for RecordBatch {
}
}
-/// Definition of record batch reader.
+///
praveenbingo closed pull request #7642:
URL: https://github.com/apache/arrow/pull/7642
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
stevengj edited a comment on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-655253087
> It seems utf8proc (incorrectly?) claims some undefined codepoints (e.g.
https://www.compart.com/en/unicode/U+08BE) are UTF8PROC_CATEGORY_LO (General
category Letter
stevengj edited a comment on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-655253087
> It seems utf8proc (incorrectly?) claims some undefined codepoints (e.g.
https://www.compart.com/en/unicode/U+08BE) are UTF8PROC_CATEGORY_LO (General
category Letter
stevengj edited a comment on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-655253087
[U+08BE](https://www.fileformat.info/info/unicode/char/08be/index.htm) was
defined in Unicode 13, and category Lo is correct. It sounds like you may be
looking at
stevengj edited a comment on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-655253087
[U+08BE](https://www.fileformat.info/info/unicode/char/08be/index.htm) was
defined in Unicode 13, and category Lo is correct. It sounds like you may be
looking at
stevengj commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-655253087
[U+08BE](https://www.fileformat.info/info/unicode/char/08be/index.htm) was
defined in Unicode 13, and category Lo is correct.
BryanCutler commented on pull request #7619:
URL: https://github.com/apache/arrow/pull/7619#issuecomment-655246147
On a related note, it seems like our netty version 4.1.27 is pretty old now,
~2 years, do you all think it would be good to upgrade this before the 1.0.0
release? It looks
BryanCutler commented on pull request #7619:
URL: https://github.com/apache/arrow/pull/7619#issuecomment-655244616
I agree that the recommended allocator should still be the netty one for
now, so I guess it wouldn't be good to bundle the unsafe allocator as a
possible default. I'm good
liyafan82 commented on pull request #7619:
URL: https://github.com/apache/arrow/pull/7619#issuecomment-655232313
> Looks fine for the most part, but I'm not really sure why we need to
separate `arrow-memory-core` and `arrow-memory-unsafe`? Couldn't those be
combined since it wouldn't add
liyafan82 commented on a change in pull request #7619:
URL: https://github.com/apache/arrow/pull/7619#discussion_r451235584
##
File path: java/memory/memory-core/pom.xml
##
@@ -0,0 +1,65 @@
+
+
+http://maven.apache.org/POM/4.0.0;
+
sagnikc-dremio commented on pull request #7641:
URL: https://github.com/apache/arrow/pull/7641#issuecomment-655228953
@pprudhvi @projjal Can you please review this change?
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7671:
URL: https://github.com/apache/arrow/pull/7671#issuecomment-655212330
https://issues.apache.org/jira/browse/ARROW-8344
This is an automated message from the Apache Git
jacques-n commented on pull request #7619:
URL: https://github.com/apache/arrow/pull/7619#issuecomment-655210526
> Looks fine for the most part, but I'm not really sure why we need to
separate `arrow-memory-core` and `arrow-memory-unsafe`? Couldn't those be
combined since it wouldn't add
mr-smidge commented on a change in pull request #7671:
URL: https://github.com/apache/arrow/pull/7671#discussion_r451216615
##
File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs
##
@@ -237,7 +329,9 @@ public ReadOnlySpan GetBytes(int index)
if
mr-smidge commented on a change in pull request #7671:
URL: https://github.com/apache/arrow/pull/7671#discussion_r451215646
##
File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs
##
@@ -173,11 +245,19 @@ public TBuilder Set(int index, byte value)
throw
mr-smidge commented on a change in pull request #7671:
URL: https://github.com/apache/arrow/pull/7671#discussion_r451215414
##
File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs
##
@@ -66,87 +66,158 @@ protected BuilderBase(IArrowType dataType)
mr-smidge commented on a change in pull request #7671:
URL: https://github.com/apache/arrow/pull/7671#discussion_r451214556
##
File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs
##
@@ -66,87 +66,158 @@ protected BuilderBase(IArrowType dataType)
mr-smidge opened a new pull request #7671:
URL: https://github.com/apache/arrow/pull/7671
This PR fixes a few bugs in `BinaryArray.Builder()`:
* Fixes the `Clear()` method, which previously would break all
subsequently-appended values (see JIRA ticket for examples).
* Makes the
kou closed pull request #7669:
URL: https://github.com/apache/arrow/pull/7669
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kou commented on pull request #7669:
URL: https://github.com/apache/arrow/pull/7669#issuecomment-655204658
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
wesm commented on issue #7663:
URL: https://github.com/apache/arrow/issues/7663#issuecomment-655197308
This isn't where we handle feature requests. There are some sorting-related
issues in JIRA; if you do not find one that describes the APIs are you are
looking for, could you open a new
wesm closed issue #7663:
URL: https://github.com/apache/arrow/issues/7663
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lidavidm commented on pull request #7664:
URL: https://github.com/apache/arrow/pull/7664#issuecomment-655193980
Just a high level comment: if I'm reading this right, V4 is still the
default metadata version and applications opt in to V5 when they want to
read/write unions. Am I
nickpoorman commented on pull request #7670:
URL: https://github.com/apache/arrow/pull/7670#issuecomment-655192799
@stuartcarnie @sbinet
This is an automated message from the Apache Git Service.
To respond to the message,
github-actions[bot] commented on pull request #7670:
URL: https://github.com/apache/arrow/pull/7670#issuecomment-655153093
https://issues.apache.org/jira/browse/ARROW-9365
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7669:
URL: https://github.com/apache/arrow/pull/7669#issuecomment-655153095
https://issues.apache.org/jira/browse/ARROW-9351
This is an automated message from the Apache Git
nickpoorman opened a new pull request #7670:
URL: https://github.com/apache/arrow/pull/7670
This PR adds the rest of the implemented typed array builders to the
NewBuilder function. I ran into needing this because `NewStructBuilder`
internally calls `NewBuilder`.
c-jamie commented on a change in pull request #7635:
URL: https://github.com/apache/arrow/pull/7635#discussion_r451159113
##
File path: cpp/src/arrow/compute/kernels/scalar_fill_null.cc
##
@@ -0,0 +1,223 @@
+
+// Licensed to the Apache Software Foundation (ASF) under one
+//
c-jamie commented on a change in pull request #7635:
URL: https://github.com/apache/arrow/pull/7635#discussion_r451159046
##
File path: cpp/src/arrow/compute/kernels/scalar_fill_null.cc
##
@@ -0,0 +1,223 @@
+
+// Licensed to the Apache Software Foundation (ASF) under one
+//
github-actions[bot] commented on pull request #7669:
URL: https://github.com/apache/arrow/pull/7669#issuecomment-655148194
Revision: 3d5cc704cda625df93aa045e17860fc5d5ea62d5
Submitted crossbow builds: [ursa-labs/crossbow @
kou commented on pull request #7669:
URL: https://github.com/apache/arrow/pull/7669#issuecomment-655147282
@github-actions crossbow submit test-ubuntu-18.04-cpp-cmake32
This is an automated message from the Apache Git
kou opened a new pull request #7669:
URL: https://github.com/apache/arrow/pull/7669
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
kou commented on a change in pull request #7589:
URL: https://github.com/apache/arrow/pull/7589#discussion_r451154810
##
File path: dev/release/post-09-docs.sh
##
@@ -42,20 +47,20 @@ popd
pushd "${ARROW_DIR}"
git checkout "${release_tag}"
Review comment:
Could you
BryanCutler commented on a change in pull request #7619:
URL: https://github.com/apache/arrow/pull/7619#discussion_r451102944
##
File path: java/adapter/orc/pom.xml
##
@@ -15,10 +15,16 @@
org.apache.arrow
-arrow-memory
-
github-actions[bot] commented on pull request #7668:
URL: https://github.com/apache/arrow/pull/7668#issuecomment-655124179
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then
nealrichardson closed pull request #7665:
URL: https://github.com/apache/arrow/pull/7665
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
github-actions[bot] commented on pull request #7658:
URL: https://github.com/apache/arrow/pull/7658#issuecomment-655121582
Revision: ad162848ecf90b691efa195cd53ce2787188dcb2
Submitted crossbow builds: [ursa-labs/crossbow @
kszucs commented on pull request #7658:
URL: https://github.com/apache/arrow/pull/7658#issuecomment-655120532
@github-actions crossbow submit -g wheel
This is an automated message from the Apache Git Service.
To respond to
nealrichardson opened a new pull request #7668:
URL: https://github.com/apache/arrow/pull/7668
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
kou closed pull request #7652:
URL: https://github.com/apache/arrow/pull/7652
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kou commented on pull request #7652:
URL: https://github.com/apache/arrow/pull/7652#issuecomment-655107335
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kou closed pull request #7649:
URL: https://github.com/apache/arrow/pull/7649
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kou commented on pull request #7649:
URL: https://github.com/apache/arrow/pull/7649#issuecomment-655105964
+1
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on pull request #7667:
URL: https://github.com/apache/arrow/pull/7667#issuecomment-655105632
https://issues.apache.org/jira/browse/ARROW-9339
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7666:
URL: https://github.com/apache/arrow/pull/7666#issuecomment-655105633
https://issues.apache.org/jira/browse/ARROW-8559
This is an automated message from the Apache Git
paddyhoran opened a new pull request #7667:
URL: https://github.com/apache/arrow/pull/7667
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
paddyhoran opened a new pull request #7666:
URL: https://github.com/apache/arrow/pull/7666
Most libraries that use `Arrow` are likely to want to define types that
produce `RecordBatch`'s. This PR defines the `RecordBatchReader` and
`SendableRecordBatchReader` traits and updates other
paddyhoran commented on pull request #7666:
URL: https://github.com/apache/arrow/pull/7666#issuecomment-655100102
cc @houqp
This is an automated message from the Apache Git Service.
To respond to the message, please log on
github-actions[bot] commented on pull request #7665:
URL: https://github.com/apache/arrow/pull/7665#issuecomment-655098668
Revision: c939366716a7a8cb255222588c750263297da720
Submitted crossbow builds: [ursa-labs/crossbow @
github-actions[bot] commented on pull request #7658:
URL: https://github.com/apache/arrow/pull/7658#issuecomment-655098011
Revision: ad162848ecf90b691efa195cd53ce2787188dcb2
Submitted crossbow builds: [ursa-labs/crossbow @
nealrichardson commented on pull request #7665:
URL: https://github.com/apache/arrow/pull/7665#issuecomment-655097392
@github-actions crossbow submit homebrew-cpp
This is an automated message from the Apache Git Service.
To
kszucs commented on pull request #7658:
URL: https://github.com/apache/arrow/pull/7658#issuecomment-655096717
@github-actions crossbow submit wheel-win-cp37m
This is an automated message from the Apache Git Service.
To
kszucs commented on a change in pull request #7658:
URL: https://github.com/apache/arrow/pull/7658#discussion_r451037044
##
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##
@@ -2069,7 +2069,7 @@ macro(build_utf8proc)
"-DCMAKE_INSTALL_PREFIX=${UTF8PROC_PREFIX}"
github-actions[bot] commented on pull request #7665:
URL: https://github.com/apache/arrow/pull/7665#issuecomment-655069200
https://issues.apache.org/jira/browse/ARROW-9360
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7665:
URL: https://github.com/apache/arrow/pull/7665#issuecomment-655068477
Revision: 23b6f0e3d5ad52dda308cf13352e4fa7f4a8a3d5
Submitted crossbow builds: [ursa-labs/crossbow @
nealrichardson commented on pull request #7665:
URL: https://github.com/apache/arrow/pull/7665#issuecomment-655067765
@github-actions crossbow submit homebrew-cpp
This is an automated message from the Apache Git Service.
To
nealrichardson opened a new pull request #7665:
URL: https://github.com/apache/arrow/pull/7665
After successfully building arrow, it then does
```
==> Upgrading 64 dependents:
ansible 2.9.6_1 -> 2.9.10, ansible 2.9.6_1 -> 2.9.10, ansible 2.9.6_1 ->
2.9.10, cairo 1.16.0_2 ->
github-actions[bot] commented on pull request #7664:
URL: https://github.com/apache/arrow/pull/7664#issuecomment-655061788
https://issues.apache.org/jira/browse/ARROW-9265
This is an automated message from the Apache Git
pitrou commented on pull request #7664:
URL: https://github.com/apache/arrow/pull/7664#issuecomment-655061168
Note that https://github.com/apache/arrow-testing/pull/35 needs to be merged
first.
This is an automated message
pitrou opened a new pull request #7664:
URL: https://github.com/apache/arrow/pull/7664
V4 Union arrays with top-level null slots are disallowed, though.
This is an automated message from the Apache Git Service.
To respond to
nealrichardson commented on pull request #7660:
URL: https://github.com/apache/arrow/pull/7660#issuecomment-655054010
Let me see if I understand the issues you're concerned with. We have some
inconsistency in how types are converted: `raw` -> `uint8`, but `uint8` ->
`integer`, for
pitrou commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-655036007
I am talking about the kernel name as well. "unicode" is non-descriptive.
This is an automated message from the
nealrichardson closed pull request #7648:
URL: https://github.com/apache/arrow/pull/7648
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
nealrichardson commented on pull request #7648:
URL: https://github.com/apache/arrow/pull/7648#issuecomment-655026342
Ok then I'll merge this and we can come back and improve it later.
This is an automated message from the
healiseu opened a new issue #7663:
URL: https://github.com/apache/arrow/issues/7663
Hi, I consider sorting a fundamental operation for any in-memory data
structures, including those of PyArrow.
It would be nice if pa.array, pa.table, etc had sorting methods but I did
not find
github-actions[bot] commented on pull request #7658:
URL: https://github.com/apache/arrow/pull/7658#issuecomment-655020811
Revision: 5970625fa8324681167e202beaf45ea1a24fc674
Submitted crossbow builds: [ursa-labs/crossbow @
kszucs commented on a change in pull request #7658:
URL: https://github.com/apache/arrow/pull/7658#discussion_r451037044
##
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##
@@ -2069,7 +2069,7 @@ macro(build_utf8proc)
"-DCMAKE_INSTALL_PREFIX=${UTF8PROC_PREFIX}"
kszucs commented on pull request #7658:
URL: https://github.com/apache/arrow/pull/7658#issuecomment-655019861
@github-actions crossbow submit wheel-win-cp37m
This is an automated message from the Apache Git Service.
To
sunchao commented on pull request #7176:
URL: https://github.com/apache/arrow/pull/7176#issuecomment-655010984
Sorry for the late response. Yes agree that API compatibility is not a big
concern here. I think the change is useful and my only concern is the new
constraint on how writer is
nealrichardson commented on pull request #7645:
URL: https://github.com/apache/arrow/pull/7645#issuecomment-655008360
Re: ChunkedArray print method, `git blame` says it was introduced in #5492.
I would guess that I added a custom method so that the printing wouldn't
explode off the screen
maartenbreddels commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-655006474
I am not talking about the C++ code, only the kernel name. UTF8 is just the
encoding, Unicode refers to the semantics of the kernel. But if utf16/32 if
excluded, I guess
github-actions[bot] commented on pull request #7662:
URL: https://github.com/apache/arrow/pull/7662#issuecomment-655006163
https://issues.apache.org/jira/browse/ARROW-9347
This is an automated message from the Apache Git
wesm commented on pull request #7648:
URL: https://github.com/apache/arrow/pull/7648#issuecomment-655004137
As long as the implementation details / semantics aren't exposed (they don't
seem to be), this seems sufficient to me to have the feature established, and
we an always return later
pitrou commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-655003555
> Are there plans to support utf16/32?
I think that should be out of scope. There's no Arrow data type for utf16
and utf32.
jorisvandenbossche opened a new pull request #7662:
URL: https://github.com/apache/arrow/pull/7662
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
pitrou commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-655003292
"utf8" is used everywhere, please keep it like this.
This is an automated message from the Apache Git Service.
To
maartenbreddels commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-655001506
If it is not off the table, I propose at least utf8->unicode renaming, to be
future compatible.
This is
xhochy commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-655000427
> Are there plans to support utf16/32? Seeing the code as it is now, it
would be trivial to add.
This would be a longer discussion. Personally I would vote "no" to limit the
maartenbreddels commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-654999617
Are there plans to support utf16/32? Seeing the code as it is now, it would
be trivial to add.
This is
pitrou commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-654999442
We should be consistent. We already have "utf8_lower" and "utf8_upper".
This is an automated message from the
nealrichardson commented on pull request #7648:
URL: https://github.com/apache/arrow/pull/7648#issuecomment-654999245
@wesm do you have an opinion on this?
This is an automated message from the Apache Git Service.
To respond
wesm commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-654998304
I think that having e.g. `string_lower_utf8` and `string_lower_ascii` is
fine, too.
This is an automated message
xhochy commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-654996646
I'm indifferent to `utf8_` vs `string_` (sometimes our codebase is too) but
other than that I fully agree to @wesm naming scheme.
wesm commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-654994900
OK, I would also like to solicit @xhochy's and @pitrou's preferences in the
function naming. I don't want to spend too much time on it, but as long as we
have a consistent naming
maartenbreddels commented on pull request #7656:
URL: https://github.com/apache/arrow/pull/7656#issuecomment-654991684
I wanted to focus on the other issues first, but I propose a change in
naming by this:
`__`, since all you care about is that it's a
function that operates on a
jorisvandenbossche commented on pull request #7623:
URL: https://github.com/apache/arrow/pull/7623#issuecomment-654981357
I think @bkietz is still taking a look today?
This is an automated message from the Apache Git
c-jamie commented on a change in pull request #7635:
URL: https://github.com/apache/arrow/pull/7635#discussion_r450989955
##
File path: cpp/src/arrow/compute/kernels/scalar_fill_null_test.cc
##
@@ -0,0 +1,137 @@
+// Licensed to the Apache Software Foundation (ASF) under one
c-jamie commented on a change in pull request #7635:
URL: https://github.com/apache/arrow/pull/7635#discussion_r450987544
##
File path: cpp/src/arrow/compute/kernels/scalar_fill_null_test.cc
##
@@ -0,0 +1,137 @@
+// Licensed to the Apache Software Foundation (ASF) under one
c-jamie commented on a change in pull request #7635:
URL: https://github.com/apache/arrow/pull/7635#discussion_r450987676
##
File path: cpp/src/arrow/compute/kernels/scalar_fill_null_test.cc
##
@@ -0,0 +1,137 @@
+// Licensed to the Apache Software Foundation (ASF) under one
c-jamie commented on a change in pull request #7635:
URL: https://github.com/apache/arrow/pull/7635#discussion_r450986992
##
File path: cpp/src/arrow/compute/kernels/scalar_fill_null.cc
##
@@ -0,0 +1,223 @@
+
+// Licensed to the Apache Software Foundation (ASF) under one
+//
c-jamie commented on a change in pull request #7635:
URL: https://github.com/apache/arrow/pull/7635#discussion_r450986751
##
File path: cpp/src/arrow/compute/kernels/scalar_fill_null.cc
##
@@ -0,0 +1,223 @@
+
+// Licensed to the Apache Software Foundation (ASF) under one
+//
c-jamie commented on a change in pull request #7635:
URL: https://github.com/apache/arrow/pull/7635#discussion_r450986449
##
File path: cpp/src/arrow/compute/api_scalar.cc
##
@@ -126,5 +126,24 @@ Result Compare(const Datum& left, const Datum&
right, CompareOptions opti
github-actions[bot] commented on pull request #7661:
URL: https://github.com/apache/arrow/pull/7661#issuecomment-654969459
https://issues.apache.org/jira/browse/ARROW-9020
This is an automated message from the Apache Git
wesm commented on pull request #7659:
URL: https://github.com/apache/arrow/pull/7659#issuecomment-654964007
@kszucs done
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
nealrichardson commented on pull request #7623:
URL: https://github.com/apache/arrow/pull/7623#issuecomment-654963305
CI is green. @jorisvandenbossche is this good to merge?
This is an automated message from the Apache Git
1 - 100 of 156 matches
Mail list logo
