[GitHub] [arrow] emkornfield commented on a change in pull request #7290: ARROW-1692: [Java] UnionArray round trip not working

2020-07-10 Thread GitBox
emkornfield commented on a change in pull request #7290: URL: https://github.com/apache/arrow/pull/7290#discussion_r453152953 ## File path: dev/archery/archery/integration/runner.py ## @@ -126,6 +126,8 @@ def _gold_tests(self, gold_dir): if f.name

[GitHub] [arrow] emkornfield commented on pull request #7604: ARROW-9223: [Python] Propagate timezone information in pandas conversion

2020-07-10 Thread GitBox
emkornfield commented on pull request #7604: URL: https://github.com/apache/arrow/pull/7604#issuecomment-656984423 > There is no way to deselect specific tests, afaik. You would have select all the other tests individually from that module, for example My preference, if it is ok

[GitHub] [arrow] jglaser commented on pull request #7711: ARROW-9415: [C++] Arrow does not compile on Power9

2020-07-10 Thread GitBox
jglaser commented on pull request #7711: URL: https://github.com/apache/arrow/pull/7711#issuecomment-656983089 should we leave this open until the upstream PR is merged, and make this a PR for the updated version? https://github.com/Cyan4973/xxHash/pull/426 @emkornfield Please

[GitHub] [arrow] emkornfield commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-10 Thread GitBox
emkornfield commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453150926 ## File path: cpp/src/parquet/arrow/schema.h ## @@ -163,24 +165,28 @@ struct PARQUET_EXPORT SchemaManifest { return it->second; } - bool

[GitHub] [arrow] emkornfield commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-10 Thread GitBox
emkornfield commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453150835 ## File path: cpp/src/parquet/arrow/schema.h ## @@ -163,24 +165,28 @@ struct PARQUET_EXPORT SchemaManifest { return it->second; } - bool

[GitHub] [arrow] jglaser commented on pull request #7711: ARROW-9415: [C++] Arrow does not compile on Power9

2020-07-10 Thread GitBox
jglaser commented on pull request #7711: URL: https://github.com/apache/arrow/pull/7711#issuecomment-656981267 oh, understood. I will submit to xxhash, then. Will take me some time to sort this out, though. This is an

[GitHub] [arrow] emkornfield commented on pull request #7711: ARROW-9415: [C++] Arrow does not compile on Power9

2020-07-10 Thread GitBox
emkornfield commented on pull request #7711: URL: https://github.com/apache/arrow/pull/7711#issuecomment-656980608 @jglaser thank you for the PR. Since this is a vendored library it would likely be better to make the PR upstream and then upgrade here once that is merged.

[GitHub] [arrow] emkornfield commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-10 Thread GitBox
emkornfield commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453150104 ## File path: cpp/src/parquet/arrow/reader.cc ## @@ -819,10 +812,7 @@ Status FileReaderImpl::ReadRowGroups(const std::vector& row_groups, // We

[GitHub] [arrow] emkornfield commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-10 Thread GitBox
emkornfield commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453150052 ## File path: cpp/src/parquet/arrow/reader.cc ## @@ -781,6 +770,9 @@ Status FileReaderImpl::GetRecordBatchReader(const std::vector& row_group_in

[GitHub] [arrow] emkornfield commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-10 Thread GitBox
emkornfield commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453149894 ## File path: cpp/src/parquet/arrow/reader.cc ## @@ -301,62 +302,50 @@ class FileReaderImpl : public FileReader { class RowGroupRecordBatchReader :

[GitHub] [arrow] emkornfield commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-10 Thread GitBox
emkornfield commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453149789 ## File path: cpp/src/parquet/arrow/reader.cc ## @@ -301,62 +302,50 @@ class FileReaderImpl : public FileReader { class RowGroupRecordBatchReader :

[GitHub] [arrow] emkornfield commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-10 Thread GitBox
emkornfield commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453149711 ## File path: cpp/src/parquet/arrow/reader.cc ## @@ -301,62 +302,50 @@ class FileReaderImpl : public FileReader { class RowGroupRecordBatchReader :

[GitHub] [arrow] emkornfield commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-10 Thread GitBox
emkornfield commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453149597 ## File path: cpp/src/parquet/arrow/reader.cc ## @@ -301,62 +302,50 @@ class FileReaderImpl : public FileReader { class RowGroupRecordBatchReader :

[GitHub] [arrow] emkornfield commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-10 Thread GitBox
emkornfield commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453149446 ## File path: cpp/src/parquet/arrow/reader.cc ## @@ -301,62 +302,50 @@ class FileReaderImpl : public FileReader { class RowGroupRecordBatchReader :

[GitHub] [arrow] emkornfield commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-10 Thread GitBox
emkornfield commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453149320 ## File path: cpp/src/parquet/arrow/arrow_schema_test.cc ## @@ -644,6 +649,78 @@ TEST_F(TestConvertParquetSchema, ParquetRepeatedNestedSchema) {

[GitHub] [arrow] github-actions[bot] commented on pull request #7711: ARROW-9415: [C++] Arrow does not compile on Power9

2020-07-10 Thread GitBox
github-actions[bot] commented on pull request #7711: URL: https://github.com/apache/arrow/pull/7711#issuecomment-656978794 https://issues.apache.org/jira/browse/ARROW-9415 This is an automated message from the Apache Git

[GitHub] [arrow] emkornfield commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-10 Thread GitBox
emkornfield commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453149152 ## File path: cpp/src/parquet/arrow/arrow_schema_test.cc ## @@ -644,6 +649,78 @@ TEST_F(TestConvertParquetSchema, ParquetRepeatedNestedSchema) {

[GitHub] [arrow] emkornfield commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-10 Thread GitBox
emkornfield commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453149053 ## File path: cpp/src/parquet/arrow/arrow_schema_test.cc ## @@ -644,6 +649,78 @@ TEST_F(TestConvertParquetSchema, ParquetRepeatedNestedSchema) {

[GitHub] [arrow] emkornfield commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-10 Thread GitBox
emkornfield commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453148949 ## File path: cpp/src/parquet/arrow/arrow_schema_test.cc ## @@ -644,6 +649,78 @@ TEST_F(TestConvertParquetSchema, ParquetRepeatedNestedSchema) {

[GitHub] [arrow] emkornfield commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-10 Thread GitBox
emkornfield commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453148787 ## File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc ## @@ -2877,11 +2877,22 @@ TEST(TestArrowReaderAdHoc,

[GitHub] [arrow] emkornfield commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-10 Thread GitBox
emkornfield commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453148755 ## File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc ## @@ -2877,11 +2877,22 @@ TEST(TestArrowReaderAdHoc,

[GitHub] [arrow] emkornfield commented on a change in pull request #7704: ARROW-9297: [C++][Parquet] Support chunked row groups in RowGroupRecordBatchReader

2020-07-10 Thread GitBox
emkornfield commented on a change in pull request #7704: URL: https://github.com/apache/arrow/pull/7704#discussion_r453148683 ## File path: cpp/src/parquet/arrow/arrow_reader_writer_test.cc ## @@ -2877,11 +2877,22 @@ TEST(TestArrowReaderAdHoc,

[GitHub] [arrow] github-actions[bot] commented on pull request #7711: fix P9 build

2020-07-10 Thread GitBox
github-actions[bot] commented on pull request #7711: URL: https://github.com/apache/arrow/pull/7711#issuecomment-656976907 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then

[GitHub] [arrow] jglaser opened a new pull request #7711: fix P9 build

2020-07-10 Thread GitBox
jglaser opened a new pull request #7711: URL: https://github.com/apache/arrow/pull/7711 Fix build on Power9 This small change addresses the following build error: ```[ 20%] Building CXX object src/arrow/CMakeFiles/arrow_objlib.dir/array/builder_nested.cc.o In file included

[GitHub] [arrow] scampi commented on a change in pull request #6402: ARROW-7831: [Java] do not allocate a new offset buffer if the slice starts at 0 since the relative offset pointer would be unchange

2020-07-10 Thread GitBox
scampi commented on a change in pull request #6402: URL: https://github.com/apache/arrow/pull/6402#discussion_r453139681 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BaseVariableWidthVector.java ## @@ -751,55 +757,57 @@ private void

[GitHub] [arrow] lidavidm commented on pull request #7702: ARROW-9395: [Python] allow configuring MetadataVersion

2020-07-10 Thread GitBox
lidavidm commented on pull request #7702: URL: https://github.com/apache/arrow/pull/7702#issuecomment-656950069 If that's https://github.com/apache/arrow/blob/master/ci/scripts/integration_spark.sh then I'll take a look when I get a chance, thanks.

[GitHub] [arrow] lidavidm commented on pull request #7685: ARROW-9362: [Java] Support reading/writing V4 MetadataVersion

2020-07-10 Thread GitBox
lidavidm commented on pull request #7685: URL: https://github.com/apache/arrow/pull/7685#issuecomment-656949942 > So is this ok to merge before #7290 ? This should be OK. It doesn't enable unions in the integration tests and prevents reading/writing unions with the old version. (Of

[GitHub] [arrow] BryanCutler commented on pull request #7702: ARROW-9395: [Python] allow configuring MetadataVersion

2020-07-10 Thread GitBox
BryanCutler commented on pull request #7702: URL: https://github.com/apache/arrow/pull/7702#issuecomment-656949654 Thanks for doing this @lidavidm ! I believe this will be necessary for a PySpark v2.4.x or v3.0.0 user that upgrades to PyArrow 1.0.0. It would be good to setup the spark

[GitHub] [arrow] houqp commented on pull request #7666: ARROW-8559: [Rust] Consolidate Record Batch reader traits in main arrow crate

2020-07-10 Thread GitBox
houqp commented on pull request #7666: URL: https://github.com/apache/arrow/pull/7666#issuecomment-656943172 +1 on unifying to Arc for the initial release given it's not on the hot path. It's better to start simple and optimize later. Arc's atomic reference counting tend to mess with

[GitHub] [arrow] BryanCutler commented on pull request #7685: ARROW-9362: [Java] Support reading/writing V4 MetadataVersion

2020-07-10 Thread GitBox
BryanCutler commented on pull request #7685: URL: https://github.com/apache/arrow/pull/7685#issuecomment-656940054 So is this ok to merge before #7290 ? This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] nealrichardson closed pull request #7660: ARROW-9291 [R]: Support fixed size binary/list types

2020-07-10 Thread GitBox
nealrichardson closed pull request #7660: URL: https://github.com/apache/arrow/pull/7660 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] github-actions[bot] commented on pull request #7710: ARROW-9413: [Rust] Disable cpm_nan clippy error

2020-07-10 Thread GitBox
github-actions[bot] commented on pull request #7710: URL: https://github.com/apache/arrow/pull/7710#issuecomment-656926979 https://issues.apache.org/jira/browse/ARROW-9413 This is an automated message from the Apache Git

[GitHub] [arrow] nevi-me commented on pull request #7710: ARROW-9413: [Rust] Disable cpm_nan clippy error

2020-07-10 Thread GitBox
nevi-me commented on pull request #7710: URL: https://github.com/apache/arrow/pull/7710#issuecomment-656924262 CC @houqp This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] nealrichardson closed pull request #7694: ARROW-9397: [R] Pass CC/CXX et al. to cmake when building libarrow in Linux build

2020-07-10 Thread GitBox
nealrichardson closed pull request #7694: URL: https://github.com/apache/arrow/pull/7694 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] nevi-me opened a new pull request #7710: ARROW-9413: [Rust] Disable cpm_nan clippy error

2020-07-10 Thread GitBox
nevi-me opened a new pull request #7710: URL: https://github.com/apache/arrow/pull/7710 Using the comparison recommended by clippy makes sorts with `NAN` undeterministic. We currently sort NAN separately to nulls, we couldcan resolve this separately

[GitHub] [arrow] wesm commented on pull request #7656: ARROW-9268: [C++] add string_is{alpnum,alpha...,upper} kernels

2020-07-10 Thread GitBox
wesm commented on pull request #7656: URL: https://github.com/apache/arrow/pull/7656#issuecomment-656921774 I googled a little bit about the compilation errors and it seems to be a gcc bug. I think that some of these kernels are going to have to be rewritten to use inline lambdas instead

[GitHub] [arrow] nealrichardson commented on pull request #7706: ARROW-9409: [CI][Crossbow] Nightly conda-r fails

2020-07-10 Thread GitBox
nealrichardson commented on pull request #7706: URL: https://github.com/apache/arrow/pull/7706#issuecomment-656921476 Also cc @xhochy. IDK how serious this is; I personally have never used this conda setup, and what would make more sense would be to test the actual conda recipe

[GitHub] [arrow] nealrichardson closed pull request #7707: ARROW-9410: [CI][Crossbow] Fix homebrew-cpp again

2020-07-10 Thread GitBox
nealrichardson closed pull request #7707: URL: https://github.com/apache/arrow/pull/7707 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] nevi-me commented on pull request #7693: ARROW-9391: [Rust] Padding added to arrays causes float32's to be incorrectly cast to float64 float64s in the case where a record batch only c

2020-07-10 Thread GitBox
nevi-me commented on pull request #7693: URL: https://github.com/apache/arrow/pull/7693#issuecomment-656917911 > @nevi-me When I was testing it we weren't seeing it while reading the record batch back directly; we had to complete the serialization to a byte stream and then read it back.

[GitHub] [arrow] wesm commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that stat

2020-07-10 Thread GitBox
wesm commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656914568 Thanks. I just opened https://issues.apache.org/jira/browse/ARROW-9412 This is an automated message from the Apache

[GitHub] [arrow] tobim commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that sta

2020-07-10 Thread GitBox
tobim commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656912930 I'm fine with that. I'll try to find some time for it tomorrow. This is an automated message from the Apache Git

[GitHub] [arrow] wesm closed pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that static lin

2020-07-10 Thread GitBox
wesm closed pull request #7696: URL: https://github.com/apache/arrow/pull/7696 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [arrow] github-actions[bot] commented on pull request #7694: ARROW-9397: [R] Pass CC/CXX et al. to cmake when building libarrow in Linux build

2020-07-10 Thread GitBox
github-actions[bot] commented on pull request #7694: URL: https://github.com/apache/arrow/pull/7694#issuecomment-656910317 Revision: a28dcda15e57f95cbad1007adce6b70e5af03eb9 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] nealrichardson commented on pull request #7694: ARROW-9397: [R] Pass CC/CXX et al. to cmake when building libarrow in Linux build

2020-07-10 Thread GitBox
nealrichardson commented on pull request #7694: URL: https://github.com/apache/arrow/pull/7694#issuecomment-656909712 This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] wesm commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that stat

2020-07-10 Thread GitBox
wesm commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656909818 +1. Let us address the `ARROW_STATIC_INSTALL_INTERFACE_LIBS` issue and associated testing as a follow up PR. This

[GitHub] [arrow] maxburke commented on pull request #7693: ARROW-9391: [Rust] Padding added to arrays causes float32's to be incorrectly cast to float64 float64s in the case where a record batch only

2020-07-10 Thread GitBox
maxburke commented on pull request #7693: URL: https://github.com/apache/arrow/pull/7693#issuecomment-656908743 @nevi-me When I was testing it we weren't seeing it while reading the record batch back directly; we had to complete the serialization to a byte stream and then read it back.

[GitHub] [arrow] wesm commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that stat

2020-07-10 Thread GitBox
wesm commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656907552 > This is not true. Sorry, my presumption was that when a system library is installed there is a shared library available. If there is both a shared and static library

[GitHub] [arrow] tobim commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that sta

2020-07-10 Thread GitBox
tobim commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656902745 > our build system does not select static libraries when using -DARROW_DEPENDENCY_SOURCE=SYSTEM This is not true. > only add static libraries to

[GitHub] [arrow] nevi-me closed pull request #7193: ARROW-7924: [Rust] Add sort for float types

2020-07-10 Thread GitBox
nevi-me closed pull request #7193: URL: https://github.com/apache/arrow/pull/7193 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] wesm commented on a change in pull request #7668: ARROW-6982: [R] Add bindings for compare and boolean kernels

2020-07-10 Thread GitBox
wesm commented on a change in pull request #7668: URL: https://github.com/apache/arrow/pull/7668#discussion_r453084856 ## File path: r/R/array.R ## @@ -269,6 +263,8 @@ filter_rows <- function(x, i, keep_na = TRUE, ...) { nrows <- x$num_rows %||% x$length() # Depends on

[GitHub] [arrow] sunchao commented on pull request #7176: ARROW-8796: [Rust] feat: Allow writers to use Vec

2020-07-10 Thread GitBox
sunchao commented on pull request #7176: URL: https://github.com/apache/arrow/pull/7176#issuecomment-656898683 Just took another look. If we are going with this, we can potentially make the API simpler. For instance, current it is: ```rust fn next_row_group( self) -> Result>;

[GitHub] [arrow] github-actions[bot] commented on pull request #7694: ARROW-9397: [R] Pass CC/CXX et al. to cmake when building libarrow in Linux build

2020-07-10 Thread GitBox
github-actions[bot] commented on pull request #7694: URL: https://github.com/apache/arrow/pull/7694#issuecomment-656898878 Revision: b455526af7db3d2849238dbf20fb2643396b6224 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] nealrichardson commented on pull request #7694: ARROW-9397: [R] Pass CC/CXX et al. to cmake when building libarrow in Linux build

2020-07-10 Thread GitBox
nealrichardson commented on pull request #7694: URL: https://github.com/apache/arrow/pull/7694#issuecomment-656898194 @github-actions crossbow submit *as-cran* This is an automated message from the Apache Git Service. To

[GitHub] [arrow] nealrichardson commented on pull request #7706: ARROW-9409: [CI][Crossbow] Nightly conda-r fails

2020-07-10 Thread GitBox
nealrichardson commented on pull request #7706: URL: https://github.com/apache/arrow/pull/7706#issuecomment-656897869 Ok I've worked around the decor issue but now there's what appears to be a legit failure, a segfault on the new dictionary integration test:

[GitHub] [arrow] nealrichardson commented on a change in pull request #7668: ARROW-6982: [R] Add bindings for compare and boolean kernels

2020-07-10 Thread GitBox
nealrichardson commented on a change in pull request #7668: URL: https://github.com/apache/arrow/pull/7668#discussion_r453082760 ## File path: r/R/array.R ## @@ -269,6 +263,8 @@ filter_rows <- function(x, i, keep_na = TRUE, ...) { nrows <- x$num_rows %||% x$length() #

[GitHub] [arrow] wesm commented on a change in pull request #7668: ARROW-6982: [R] Add bindings for compare and boolean kernels

2020-07-10 Thread GitBox
wesm commented on a change in pull request #7668: URL: https://github.com/apache/arrow/pull/7668#discussion_r453081425 ## File path: r/R/array.R ## @@ -269,6 +263,8 @@ filter_rows <- function(x, i, keep_na = TRUE, ...) { nrows <- x$num_rows %||% x$length() # Depends on

[GitHub] [arrow] github-actions[bot] commented on pull request #7709: ARROW-9411: [Rust] Update dependencies

2020-07-10 Thread GitBox
github-actions[bot] commented on pull request #7709: URL: https://github.com/apache/arrow/pull/7709#issuecomment-656894889 https://issues.apache.org/jira/browse/ARROW-9411 This is an automated message from the Apache Git

[GitHub] [arrow] wesm commented on a change in pull request #7668: ARROW-6982: [R] Add bindings for compare and boolean kernels

2020-07-10 Thread GitBox
wesm commented on a change in pull request #7668: URL: https://github.com/apache/arrow/pull/7668#discussion_r453079515 ## File path: r/R/array.R ## @@ -269,6 +263,8 @@ filter_rows <- function(x, i, keep_na = TRUE, ...) { nrows <- x$num_rows %||% x$length() # Depends on

[GitHub] [arrow] github-actions[bot] commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static libra

2020-07-10 Thread GitBox
github-actions[bot] commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656892388 Revision: f43ce4606996ed44980dba514c824786e70729d3 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] nevi-me opened a new pull request #7709: ARROW-9411: [Rust] Update dependencies

2020-07-10 Thread GitBox
nevi-me opened a new pull request #7709: URL: https://github.com/apache/arrow/pull/7709 This updates some dependencies like prost and rand. Helps reduce number of dependencies This is an automated message from the Apache

[GitHub] [arrow] wesm commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that stat

2020-07-10 Thread GitBox
wesm commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656891774 Fingers crossed that I've fixed the gRPC bundling problem and the Linux packages work this time This is an

[GitHub] [arrow] wesm commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that stat

2020-07-10 Thread GitBox
wesm commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656891639 @github-actions crossbow submit -g linux This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] wesm edited a comment on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so th

2020-07-10 Thread GitBox
wesm edited a comment on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656890077 > I still think that "-DARROW_DEPENDENCY_SOURCE=SYSTEM" should work with arrow-static. > For this case my opinion is that non-vendored dependencies should not be bundled.

[GitHub] [arrow] wesm commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that stat

2020-07-10 Thread GitBox
wesm commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656890077 > I still think that "-DARROW_DEPENDENCY_SOURCE=SYSTEM" should work with arrow-static. > For this case my opinion is that non-vendored dependencies should not be bundled.

[GitHub] [arrow] sunchao commented on pull request #7666: ARROW-8559: [Rust] Consolidate Record Batch reader traits in main arrow crate

2020-07-10 Thread GitBox
sunchao commented on pull request #7666: URL: https://github.com/apache/arrow/pull/7666#issuecomment-656889046 > The Rc version is used in a few places but again I don't think it's that important to use Rc over Arc. Agreed. I don't see any performance implication for this, as

[GitHub] [arrow] jeroen commented on pull request #7694: ARROW-9397: [R] Pass CC/CXX et al. to cmake when building libarrow in Linux build

2020-07-10 Thread GitBox
jeroen commented on pull request #7694: URL: https://github.com/apache/arrow/pull/7694#issuecomment-656888136 Not from the configure step I think. These are all `make` variables so the native way to build embedded libs is to pass these down when invoking a sub-make, like so:

[GitHub] [arrow] tobim commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that sta

2020-07-10 Thread GitBox
tobim commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656887788 > Re: system dependencies and static build, is https://issues.apache.org/jira/browse/ARROW-6312 related? I encountered this issue in

[GitHub] [arrow] nealrichardson commented on pull request #7694: ARROW-9397: [R] Pass CC/CXX et al. to cmake when building libarrow in Linux build

2020-07-10 Thread GitBox
nealrichardson commented on pull request #7694: URL: https://github.com/apache/arrow/pull/7694#issuecomment-656884857 Is there a way to get that config without shelling out at all? This is an automated message from the

[GitHub] [arrow] jeroen commented on pull request #7694: ARROW-9397: [R] Pass CC/CXX et al. to cmake when building libarrow in Linux build

2020-07-10 Thread GitBox
jeroen commented on pull request #7694: URL: https://github.com/apache/arrow/pull/7694#issuecomment-656883822 You have a bug here because your version of `R_CMD_config` takes R from the PATH but that may not be the correct R. Some machines have many versions of R. It may be safer to

[GitHub] [arrow] nealrichardson commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so

2020-07-10 Thread GitBox
nealrichardson commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656882522 Re: system dependencies and static build, is https://issues.apache.org/jira/browse/ARROW-6312 related? I encountered this issue in

[GitHub] [arrow] github-actions[bot] commented on pull request #7708: ARROW-9292: [Doc] Remove Rust from feature matrix

2020-07-10 Thread GitBox
github-actions[bot] commented on pull request #7708: URL: https://github.com/apache/arrow/pull/7708#issuecomment-656882517 https://issues.apache.org/jira/browse/ARROW-9292 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #7707: ARROW-9410: [CI][Crossbow] Fix homebrew-cpp again

2020-07-10 Thread GitBox
github-actions[bot] commented on pull request #7707: URL: https://github.com/apache/arrow/pull/7707#issuecomment-656882518 https://issues.apache.org/jira/browse/ARROW-9410 This is an automated message from the Apache Git

[GitHub] [arrow] nevi-me opened a new pull request #7708: ARROW-9292: [Doc] Remove Rust from feature matrix

2020-07-10 Thread GitBox
nevi-me opened a new pull request #7708: URL: https://github.com/apache/arrow/pull/7708 We currently have problems with Rust integration testing, so I'm temporarily removing them from the documentation This is an automated

[GitHub] [arrow] github-actions[bot] commented on pull request #7706: ARROW-9409: [CI][Crossbow] Nightly conda-r fails

2020-07-10 Thread GitBox
github-actions[bot] commented on pull request #7706: URL: https://github.com/apache/arrow/pull/7706#issuecomment-656881900 Revision: 002a43e4dd7504c9911d458d8f05f6aecf1a564f Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] tobim commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that sta

2020-07-10 Thread GitBox
tobim commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656880866 > We can't put the Arrow toolchain libraries in INTERFACE_LINK_LIBRARIES because they will be unrecognized by the third party project. I still think that

[GitHub] [arrow] nealrichardson commented on pull request #7706: ARROW-9409: [CI][Crossbow] Nightly conda-r fails

2020-07-10 Thread GitBox
nealrichardson commented on pull request #7706: URL: https://github.com/apache/arrow/pull/7706#issuecomment-656881146 @github-actions crossbow submit *conda-r* This is an automated message from the Apache Git Service. To

[GitHub] [arrow] github-actions[bot] commented on pull request #7707: ARROW-9410: [CI][Crossbow] Fix homebrew-cpp again

2020-07-10 Thread GitBox
github-actions[bot] commented on pull request #7707: URL: https://github.com/apache/arrow/pull/7707#issuecomment-656880263 Revision: 04f80607d70cd4a7c892512a14a76e145de50486 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] nealrichardson commented on pull request #7707: ARROW-9410: [CI][Crossbow] Fix homebrew-cpp again

2020-07-10 Thread GitBox
nealrichardson commented on pull request #7707: URL: https://github.com/apache/arrow/pull/7707#issuecomment-656879577 @github-actions crossbow submit homebrew-cpp This is an automated message from the Apache Git Service. To

[GitHub] [arrow] nealrichardson opened a new pull request #7707: ARROW-9410: [CI][Crossbow] Fix homebrew-cpp again

2020-07-10 Thread GitBox
nealrichardson opened a new pull request #7707: URL: https://github.com/apache/arrow/pull/7707 Pulls some changes to the formula from upstream This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] github-actions[bot] commented on pull request #7706: ARROW-9409: [CI][Crossbow] Nightly conda-r fails

2020-07-10 Thread GitBox
github-actions[bot] commented on pull request #7706: URL: https://github.com/apache/arrow/pull/7706#issuecomment-656876659 https://issues.apache.org/jira/browse/ARROW-9409 This is an automated message from the Apache Git

[GitHub] [arrow] github-actions[bot] commented on pull request #7706: ARROW-9409: [CI][Crossbow] Nightly conda-r fails

2020-07-10 Thread GitBox
github-actions[bot] commented on pull request #7706: URL: https://github.com/apache/arrow/pull/7706#issuecomment-656873001 Revision: 1647387c4eaabe5ab13515be04d88abab7c9e137 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] nealrichardson commented on pull request #7706: ARROW-9409: [CI][Crossbow] Nightly conda-r fails

2020-07-10 Thread GitBox
nealrichardson commented on pull request #7706: URL: https://github.com/apache/arrow/pull/7706#issuecomment-656872355 @github-actions crossbow submit *conda-r* This is an automated message from the Apache Git Service. To

[GitHub] [arrow] nealrichardson opened a new pull request #7706: ARROW-9409: [CI][Crossbow] Nightly conda-r fails

2020-07-10 Thread GitBox
nealrichardson opened a new pull request #7706: URL: https://github.com/apache/arrow/pull/7706 It's annoying that we need to declare these separately This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] github-actions[bot] commented on pull request #7705: ARROW-9408: [Integration] Fix Windows numpy datagen issues

2020-07-10 Thread GitBox
github-actions[bot] commented on pull request #7705: URL: https://github.com/apache/arrow/pull/7705#issuecomment-656871192 https://issues.apache.org/jira/browse/ARROW-9408 This is an automated message from the Apache Git

[GitHub] [arrow] bkietz commented on a change in pull request #7695: ARROW-8989: [C++][Doc] Document available compute functions

2020-07-10 Thread GitBox
bkietz commented on a change in pull request #7695: URL: https://github.com/apache/arrow/pull/7695#discussion_r453046448 ## File path: docs/source/cpp/compute.rst ## @@ -0,0 +1,419 @@ +.. Licensed to the Apache Software Foundation (ASF) under one +.. or more contributor

[GitHub] [arrow] wesm commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that stat

2020-07-10 Thread GitBox
wesm commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656869168 The one test failure is spurious ``` pyarrow/tests/test_fs.py:1285: _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _

[GitHub] [arrow] nevi-me opened a new pull request #7705: ARROW-9408: [Integration] Fix Windows numpy datagen issues

2020-07-10 Thread GitBox
nevi-me opened a new pull request #7705: URL: https://github.com/apache/arrow/pull/7705 We found that the integer range check when generating integration data doesn't work in Windows because the default C integers that numpy uses are 32-bit by default in Windows. This fixes that

[GitHub] [arrow] eerhardt closed pull request #7657: ARROW-8886: [C#] Resize to negative length no longer permitted

2020-07-10 Thread GitBox
eerhardt closed pull request #7657: URL: https://github.com/apache/arrow/pull/7657 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [arrow] eerhardt commented on a change in pull request #7671: ARROW-8344: [C#] Bug-fixes to binary array plus other improvements

2020-07-10 Thread GitBox
eerhardt commented on a change in pull request #7671: URL: https://github.com/apache/arrow/pull/7671#discussion_r453045241 ## File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs ## @@ -66,87 +66,158 @@ protected BuilderBase(IArrowType dataType)

[GitHub] [arrow] nevi-me commented on pull request #7693: ARROW-9391: [Rust] Padding added to arrays causes float32's to be incorrectly cast to float64 float64s in the case where a record batch only c

2020-07-10 Thread GitBox
nevi-me commented on pull request #7693: URL: https://github.com/apache/arrow/pull/7693#issuecomment-656859641 Hey @maxburke, I think I understand the gist of the problem, but do you need to create the `ParquetBufWriter` struct to test this? Wouldn't writing a single record batch with the

[GitHub] [arrow] github-actions[bot] commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static libra

2020-07-10 Thread GitBox
github-actions[bot] commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656858894 Revision: 1f24b9e60587f1b42ee0a8d903e7cc9fc051 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] wesm commented on pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library so that stat

2020-07-10 Thread GitBox
wesm commented on pull request #7696: URL: https://github.com/apache/arrow/pull/7696#issuecomment-656858004 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [arrow] paddyhoran commented on a change in pull request #7666: ARROW-8559: [Rust] Consolidate Record Batch reader traits in main arrow crate

2020-07-10 Thread GitBox
paddyhoran commented on a change in pull request #7666: URL: https://github.com/apache/arrow/pull/7666#discussion_r453044078 ## File path: rust/datafusion/src/execution/physical_plan/common.rs ## @@ -47,12 +47,12 @@ impl RecordBatchIterator { } } -impl BatchIterator

[GitHub] [arrow] wesm commented on a change in pull request #7696: ARROW-7605: [C++] Create and install "dependency bundle" static library including jemalloc, mimalloc, and any BUNDLED static library

2020-07-10 Thread GitBox
wesm commented on a change in pull request #7696: URL: https://github.com/apache/arrow/pull/7696#discussion_r453043649 ## File path: cpp/examples/minimal_build/CMakeLists.txt ## @@ -19,10 +19,31 @@ cmake_minimum_required(VERSION 3.0) project(ArrowMinimalExample)

[GitHub] [arrow] paddyhoran commented on pull request #7666: ARROW-8559: [Rust] Consolidate Record Batch reader traits in main arrow crate

2020-07-10 Thread GitBox
paddyhoran commented on pull request #7666: URL: https://github.com/apache/arrow/pull/7666#issuecomment-656856701 > I think the `schema` method is already returning a `Arc`, where is the `Rc` being used? IMHO if it is not too difficult to do we should consolidate on a single trait now

[GitHub] [arrow] eerhardt commented on a change in pull request #7671: ARROW-8344: [C#] Bug-fixes to binary array plus other improvements

2020-07-10 Thread GitBox
eerhardt commented on a change in pull request #7671: URL: https://github.com/apache/arrow/pull/7671#discussion_r453042194 ## File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs ## @@ -237,7 +329,9 @@ public ReadOnlySpan GetBytes(int index) if

[GitHub] [arrow] eerhardt commented on a change in pull request #7671: ARROW-8344: [C#] Bug-fixes to binary array plus other improvements

2020-07-10 Thread GitBox
eerhardt commented on a change in pull request #7671: URL: https://github.com/apache/arrow/pull/7671#discussion_r453038089 ## File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs ## @@ -66,87 +66,158 @@ protected BuilderBase(IArrowType dataType)

[GitHub] [arrow] nealrichardson closed pull request #7703: ARROW-9355 [R]: Fix -Wimplicit-int-float-conversion

2020-07-10 Thread GitBox
nealrichardson closed pull request #7703: URL: https://github.com/apache/arrow/pull/7703 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [arrow] github-actions[bot] commented on pull request #7694: ARROW-9397: [R] Pass CC/CXX et al. to cmake when building libarrow in Linux build

2020-07-10 Thread GitBox
github-actions[bot] commented on pull request #7694: URL: https://github.com/apache/arrow/pull/7694#issuecomment-656837525 https://issues.apache.org/jira/browse/ARROW-9397 This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson commented on pull request #7703: ARROW-9355 [R]: Fix -Wimplicit-int-float-conversion

2020-07-10 Thread GitBox
nealrichardson commented on pull request #7703: URL: https://github.com/apache/arrow/pull/7703#issuecomment-656832748 @github-actions autotune everything This is an automated message from the Apache Git Service. To respond

  1   2   >