github-actions[bot] commented on pull request #9993:
URL: https://github.com/apache/arrow/pull/9993#issuecomment-817501699
https://issues.apache.org/jira/browse/ARROW-12317
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
houqp commented on pull request #9993:
URL: https://github.com/apache/arrow/pull/9993#issuecomment-817501688
cc @alamb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
houqp opened a new pull request #9993:
URL: https://github.com/apache/arrow/pull/9993
This PR adds support for Time and Date date types in Rust arrow JSON writer
module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
domoritz opened a new pull request #9992:
URL: https://github.com/apache/arrow/pull/9992
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
github-actions[bot] commented on pull request #9992:
URL: https://github.com/apache/arrow/pull/9992#issuecomment-817468361
https://issues.apache.org/jira/browse/ARROW-12269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mathyingzhou edited a comment on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-817451185
@pitrou I completely revamped adapter_util.cc and switched to
arrow::ArrayDataVisitor. That is, all comments have been addressed. Please
review.
By the way I
msathis commented on pull request #9987:
URL: https://github.com/apache/arrow/pull/9987#issuecomment-817460796
```
curl --request GET \
--url http://localhost:50050/executors \
--header 'Accept: application/json'
```
@andygrove The above curl should work. Added small
emkornfield commented on pull request #9986:
URL: https://github.com/apache/arrow/pull/9986#issuecomment-817456063
@andygrove were you synced to the latest version, i tried to update the
merge tool to also work with minor PRs.
--
This is an automated message from the Apache Git Service.
emkornfield commented on pull request #7214:
URL: https://github.com/apache/arrow/pull/7214#issuecomment-817454551
I don't know why @pprudhvi closed it. There seemed to be a stall in the
coversation with @jacques-n if you would like to resurrect it please go ahead.
--
This is an
mathyingzhou commented on pull request #8648:
URL: https://github.com/apache/arrow/pull/8648#issuecomment-817451185
@pitrou I completely revamped adapter_util.cc and switched to
arrow::ArrayDataVisitor. That is, all comments have been addressed. Please
review.
--
This is an automated
liyafan82 commented on pull request #9964:
URL: https://github.com/apache/arrow/pull/9964#issuecomment-817430701
> Looks good!
>
> IMHO, does this PR change the signature of API a bit? Hopefully, the
change does not affect existing code practically.
@kiszk Thanks for your
andygrove commented on pull request #9987:
URL: https://github.com/apache/arrow/pull/9987#issuecomment-817401449
Hi @msathis and thanks for creating the PR. I pulled your branch and tried
testing this locally but couldn't get it to work. I'm probably doing something
wrong. It would be
codecov-io commented on pull request #9991:
URL: https://github.com/apache/arrow/pull/9991#issuecomment-817384523
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9991?src=pr=h1) Report
> Merging
[#9991](https://codecov.io/gh/apache/arrow/pull/9991?src=pr=desc) (a96fd26)
into
andygrove closed pull request #9990:
URL: https://github.com/apache/arrow/pull/9990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
github-actions[bot] commented on pull request #9991:
URL: https://github.com/apache/arrow/pull/9991#issuecomment-817382555
https://issues.apache.org/jira/browse/ARROW-12335
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
andygrove opened a new pull request #9991:
URL: https://github.com/apache/arrow/pull/9991
Tests fail. Ballista does not handle the new `RepartitionExec` that
DataFusion is inserting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
github-actions[bot] commented on pull request #9990:
URL: https://github.com/apache/arrow/pull/9990#issuecomment-817378904
https://issues.apache.org/jira/browse/ARROW-12313
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
andygrove opened a new pull request #9990:
URL: https://github.com/apache/arrow/pull/9990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
andygrove merged pull request #9986:
URL: https://github.com/apache/arrow/pull/9986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
kou commented on pull request #9989:
URL: https://github.com/apache/arrow/pull/9989#issuecomment-817372936
Good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For
kou merged pull request #9989:
URL: https://github.com/apache/arrow/pull/9989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
kou closed pull request #9983:
URL: https://github.com/apache/arrow/pull/9983
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
kou commented on pull request #9986:
URL: https://github.com/apache/arrow/pull/9986#issuecomment-817369647
We can use the "Squash and merge" button in PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
domoritz commented on a change in pull request #9988:
URL: https://github.com/apache/arrow/pull/9988#discussion_r611241493
##
File path: js/tsconfig.json
##
@@ -6,6 +6,7 @@
},
"compilerOptions": {
"target": "ESNEXT",
-"module": "commonjs"
+"module":
domoritz commented on a change in pull request #9988:
URL: https://github.com/apache/arrow/pull/9988#discussion_r611241493
##
File path: js/tsconfig.json
##
@@ -6,6 +6,7 @@
},
"compilerOptions": {
"target": "ESNEXT",
-"module": "commonjs"
+"module":
github-actions[bot] commented on pull request #9988:
URL: https://github.com/apache/arrow/pull/9988#issuecomment-817367323
https://issues.apache.org/jira/browse/ARROW-12333
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
domoritz opened a new pull request #9989:
URL: https://github.com/apache/arrow/pull/9989
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
msathis edited a comment on pull request #9987:
URL: https://github.com/apache/arrow/pull/9987#issuecomment-817354924
https://user-images.githubusercontent.com/2977899/114317329-2a421080-9b25-11eb-90ae-4161476b3d8c.png;>
@andygrove Please review when you find time :)
--
This is an
github-actions[bot] commented on pull request #9988:
URL: https://github.com/apache/arrow/pull/9988#issuecomment-817366444
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/master/.github/CONTRIBUTING.md#Minor-Fixes).
Could
domoritz opened a new pull request #9988:
URL: https://github.com/apache/arrow/pull/9988
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
domoritz commented on pull request #9961:
URL: https://github.com/apache/arrow/pull/9961#issuecomment-817366232
I didn't mean not having bundles. I mean that the bundle will default to
es2015. The es5 bundle wouldn't be as optimal anymore but the es5 bundles don't
seem to get much traffic
trxcllnt commented on pull request #9961:
URL: https://github.com/apache/arrow/pull/9961#issuecomment-817365840
@domoritz people definitely use it in jsfiddles/notebooks etc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kou closed pull request #9938:
URL: https://github.com/apache/arrow/pull/9938
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
msathis commented on pull request #9987:
URL: https://github.com/apache/arrow/pull/9987#issuecomment-817354924
https://user-images.githubusercontent.com/2977899/114317329-2a421080-9b25-11eb-90ae-4161476b3d8c.png;>
--
This is an automated message from the Apache Git Service.
To
github-actions[bot] commented on pull request #9987:
URL: https://github.com/apache/arrow/pull/9987#issuecomment-817354732
https://issues.apache.org/jira/browse/ARROW-12332
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
github-actions[bot] commented on pull request #9987:
URL: https://github.com/apache/arrow/pull/9987#issuecomment-817354014
Thanks for opening a pull request!
If this is not a [minor
PR](https://github.com/apache/arrow/blob/master/.github/CONTRIBUTING.md#Minor-Fixes).
Could
msathis opened a new pull request #9987:
URL: https://github.com/apache/arrow/pull/9987
Implements GET /executors. We can additional endpoints going forward.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
trxcllnt commented on a change in pull request #9962:
URL: https://github.com/apache/arrow/pull/9962#discussion_r611226795
##
File path: js/src/util/bit.ts
##
@@ -64,16 +64,51 @@ export function packBools(values: Iterable) {
}
/** @ignore */
-export function*
trxcllnt commented on a change in pull request #9962:
URL: https://github.com/apache/arrow/pull/9962#discussion_r611226724
##
File path: js/src/util/bit.ts
##
@@ -64,16 +64,51 @@ export function packBools(values: Iterable) {
}
/** @ignore */
-export function*
houqp commented on pull request #9968:
URL: https://github.com/apache/arrow/pull/9968#issuecomment-817347780
The caller would need to obtain the response schema first, in most cases,
the schema should be static. In case of API responses, it would be part of the
API spec.
I would
domoritz commented on pull request #9961:
URL: https://github.com/apache/arrow/pull/9961#issuecomment-817342595
I wonder, would it make sense to remove closure compiler if we only use it
for es5 and es5 isn't the default bundle anymore? Is the benefit for users big
enough to warrant the
andygrove commented on pull request #9986:
URL: https://github.com/apache/arrow/pull/9986#issuecomment-817337302
How do we merge PRs that have no JIRA? The `merge_arrow_pr` script fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
andygrove commented on pull request #9986:
URL: https://github.com/apache/arrow/pull/9986#issuecomment-817332981
@jorgecarleitao @alamb Is this all that is required?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
andygrove opened a new pull request #9986:
URL: https://github.com/apache/arrow/pull/9986
I did not create a JIRA for this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
andygrove closed pull request #9979:
URL: https://github.com/apache/arrow/pull/9979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service,
andygrove commented on pull request #9979:
URL: https://github.com/apache/arrow/pull/9979#issuecomment-817332160
I confirmed that CI ran the build and tests for Ballista so will go ahead
and merge this.
--
This is an automated message from the Apache Git Service.
To respond to the
andygrove commented on pull request #9979:
URL: https://github.com/apache/arrow/pull/9979#issuecomment-817330050
I modified this PR to build without default features, just so we can enable
CI quickly. I filed https://issues.apache.org/jira/browse/ARROW-12331 for the
follow-up work for
nealrichardson commented on pull request #9975:
URL: https://github.com/apache/arrow/pull/9975#issuecomment-817325048
> I'm open to suggestions
Maybe add a comment to this effect so that whenever we remove support for
gcc < 4.9, we can remove this? Or could you even use an `#ifdef`
domoritz commented on a change in pull request #9962:
URL: https://github.com/apache/arrow/pull/9962#discussion_r611202891
##
File path: js/src/util/bit.ts
##
@@ -64,16 +64,52 @@ export function packBools(values: Iterable) {
}
/** @ignore */
-export function*
kiszk opened a new pull request #9985:
URL: https://github.com/apache/arrow/pull/9985
This PR restores values at `counters` column of Archery benchmark. #9140
always suppressed values at `counters` column regardless `--no-counter`. In
addition, this PR stores `counters` value into json
github-actions[bot] commented on pull request #9985:
URL: https://github.com/apache/arrow/pull/9985#issuecomment-817322813
https://issues.apache.org/jira/browse/ARROW-12330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
Dandandan edited a comment on pull request #9970:
URL: https://github.com/apache/arrow/pull/9970#issuecomment-817317167
> > What are the exact use cases for summing timestamps? When does it make
sense?
>
> @Dandandan that is an excellent question. I will freely admit I was just
Dandandan commented on pull request #9970:
URL: https://github.com/apache/arrow/pull/9970#issuecomment-817317167
> > What are the exact use cases for summing timestamps? When does it make
sense?
>
> @Dandandan that is an excellent question. I will freely admit I was just
heads down
Dandandan commented on pull request #9979:
URL: https://github.com/apache/arrow/pull/9979#issuecomment-817315885
Thanks @mjp41 I think that's a great option.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
roee88 commented on a change in pull request #9631:
URL: https://github.com/apache/arrow/pull/9631#discussion_r611172212
##
File path: cpp/src/parquet/encryption/encryption.h
##
@@ -70,6 +70,26 @@ class PARQUET_EXPORT StringKeyIdRetriever : public
DecryptionKeyRetriever {
roee88 commented on a change in pull request #9631:
URL: https://github.com/apache/arrow/pull/9631#discussion_r611172212
##
File path: cpp/src/parquet/encryption/encryption.h
##
@@ -70,6 +70,26 @@ class PARQUET_EXPORT StringKeyIdRetriever : public
DecryptionKeyRetriever {
alamb commented on pull request #9970:
URL: https://github.com/apache/arrow/pull/9970#issuecomment-817279890
> What are the exact use cases for summing timestamps? When does it make
sense?
@Dandandan that is an excellent question. I will freely admit I was just
heads down trying
alamb closed pull request #9968:
URL: https://github.com/apache/arrow/pull/9968
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please
alamb commented on pull request #9968:
URL: https://github.com/apache/arrow/pull/9968#issuecomment-817277440
> I am thinking of adding an option to return these type of values as
numbers instead of human readable strings for better ser/de performance, what
do you think about that?
mjp41 commented on pull request #9979:
URL: https://github.com/apache/arrow/pull/9979#issuecomment-817267751
This came up for another project, and they added support for building
snmalloc-[rs/sys] without cmake:
> build_cc: use of cc crate instead of cmake (cmake still default) as
60 matches
Mail list logo
