[GitHub] [arrow] nealrichardson commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
nealrichardson commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r415887520 ## File path: cpp/src/arrow/dataset/file_csv.h ## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] fsaintjacques edited a comment on pull request #6645: ARROW-8074: [Dataset][Python] FileFragments from Buffers

2020-04-27 Thread GitBox
fsaintjacques edited a comment on pull request #6645: URL: https://github.com/apache/arrow/pull/6645#issuecomment-619957568 I'll close this for now, ARROW-8318 will remove this limitation and FileSystemDataset will be created from a list of FileFragment, which themselves can be created

[GitHub] [arrow] fsaintjacques commented on pull request #6645: ARROW-8074: [Dataset][Python] FileFragments from Buffers

2020-04-27 Thread GitBox
fsaintjacques commented on pull request #6645: URL: https://github.com/apache/arrow/pull/6645#issuecomment-619957568 I'll close this for now, ARROW-8318 will remove this limitation and FileSystemDataset will be created from a list of FileFragment, which themselves can be created from

[GitHub] [arrow] yonidavidson commented on pull request #6731: [WIP] ARROW-8601: [Go][Flight] Added implementation of FlightDataWriter

2020-04-27 Thread GitBox
yonidavidson commented on pull request #6731: URL: https://github.com/apache/arrow/pull/6731#issuecomment-620017093 Hi All, I am working on https://github.com/353solutions/carrow/tree/issue/46-flight . This is a Go project that wraps the C++ one but wanted everyone to know that it's

[GitHub] [arrow] fsaintjacques commented on pull request #7001: ARROW-8602: [C++][CMake] Fix ws2_32 link issue when cross-compiling on Linux

2020-04-27 Thread GitBox
fsaintjacques commented on pull request #7001: URL: https://github.com/apache/arrow/pull/7001#issuecomment-619964385 @davidanthoff feel free to create an account on JIRA so that I can assign you the ticket https://issues.apache.org/jira/browse/ARROW-8602

[GitHub] [arrow] nevi-me edited a comment on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly

2020-04-28 Thread GitBox
nevi-me edited a comment on pull request #7024: URL: https://github.com/apache/arrow/pull/7024#issuecomment-620649009 @andygrove the failure doesn't make sense to me. On my machine, the relevant file is formatted correctly. @jorisvandenbossche we'll fix the lint CI failure here.

[GitHub] [arrow] sunchao commented on pull request #6949: ARROW-7681: [Rust] Explicitly seeking a BufReader will discard the internal buffer (2)

2020-04-28 Thread GitBox
sunchao commented on pull request #6949: URL: https://github.com/apache/arrow/pull/6949#issuecomment-620730498 Oops. Sorry my bad. Thanks @nevi-me ! This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] bkietz commented on a change in pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-28 Thread GitBox
bkietz commented on a change in pull request #7026: URL: https://github.com/apache/arrow/pull/7026#discussion_r416746022 ## File path: python/pyarrow/_dataset.pyx ## @@ -41,6 +42,167 @@ def _forbid_instantiation(klass, subclasses_instead=True): raise TypeError(msg)

[GitHub] [arrow] nevi-me commented on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly

2020-04-28 Thread GitBox
nevi-me commented on pull request #7024: URL: https://github.com/apache/arrow/pull/7024#issuecomment-620739497 Thanks @markhildreth, I didn't see that the branch wasn't rebased into master. We should be fine now. This is an

[GitHub] [arrow] bkietz commented on a change in pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-28 Thread GitBox
bkietz commented on a change in pull request #7026: URL: https://github.com/apache/arrow/pull/7026#discussion_r416761725 ## File path: python/pyarrow/tests/test_dataset.py ## @@ -218,33 +216,21 @@ def test_filesystem_dataset(mockfs): # validation of required arguments

[GitHub] [arrow] bkietz commented on a change in pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-28 Thread GitBox
bkietz commented on a change in pull request #7026: URL: https://github.com/apache/arrow/pull/7026#discussion_r416761581 ## File path: python/pyarrow/tests/test_dataset.py ## @@ -373,141 +357,70 @@ def test_partitioning(): assert expr.equals(expected) -def

[GitHub] [arrow] nevi-me commented on pull request #7049: ARROW-8617: [Rust] Avoid loading simd_load_set_invalid which doesn't exist on aarch64

2020-04-28 Thread GitBox
nevi-me commented on pull request #7049: URL: https://github.com/apache/arrow/pull/7049#issuecomment-620756163 > Would you mind fixing the lint error also please (I know you didn't introduce this)? We're fixing the lint error in #7024

[GitHub] [arrow] bkietz commented on a change in pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-28 Thread GitBox
bkietz commented on a change in pull request #7026: URL: https://github.com/apache/arrow/pull/7026#discussion_r416750345 ## File path: python/pyarrow/_dataset.pyx ## @@ -41,6 +42,167 @@ def _forbid_instantiation(klass, subclasses_instead=True): raise TypeError(msg)

[GitHub] [arrow] bkietz commented on a change in pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-28 Thread GitBox
bkietz commented on a change in pull request #7026: URL: https://github.com/apache/arrow/pull/7026#discussion_r416760152 ## File path: python/pyarrow/_dataset.pyx ## @@ -118,21 +280,15 @@ cdef class Dataset: --- fragments : iterator of Fragment

[GitHub] [arrow] markhildreth edited a comment on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly

2020-04-28 Thread GitBox
markhildreth edited a comment on pull request #7024: URL: https://github.com/apache/arrow/pull/7024#issuecomment-620692002 @nevi-me I don't have access to the failure you linked to (on domain `git.data-engine.co.za`), but if you mean the failure showing up in CI, there was a change

[GitHub] [arrow] bkietz commented on pull request #7048: ARROW-8609: [C++] fix orc jni crash

2020-04-28 Thread GitBox
bkietz commented on pull request #7048: URL: https://github.com/apache/arrow/pull/7048#issuecomment-620726828 @github-actions autotune everything This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] rtyler commented on pull request #7049: [Rust] Avoid loading simd_load_set_invalid which doesn't exist on aarch64

2020-04-28 Thread GitBox
rtyler commented on pull request #7049: URL: https://github.com/apache/arrow/pull/7049#issuecomment-620733044 https://issues.apache.org/jira/browse/ARROW-8617 This is an automated message from the Apache Git Service. To

[GitHub] [arrow] bkietz commented on a change in pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-28 Thread GitBox
bkietz commented on a change in pull request #7026: URL: https://github.com/apache/arrow/pull/7026#discussion_r416795870 ## File path: python/pyarrow/tests/test_dataset.py ## @@ -373,125 +354,51 @@ def test_partitioning(): assert expr.equals(expected) -def

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-28 Thread GitBox
jorisvandenbossche commented on a change in pull request #7026: URL: https://github.com/apache/arrow/pull/7026#discussion_r416810213 ## File path: python/pyarrow/tests/test_dataset.py ## @@ -373,125 +354,51 @@ def test_partitioning(): assert expr.equals(expected) -def

[GitHub] [arrow] bkietz commented on a change in pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-28 Thread GitBox
bkietz commented on a change in pull request #7026: URL: https://github.com/apache/arrow/pull/7026#discussion_r416758776 ## File path: python/pyarrow/_dataset.pyx ## @@ -41,6 +42,167 @@ def _forbid_instantiation(klass, subclasses_instead=True): raise TypeError(msg)

[GitHub] [arrow] markhildreth edited a comment on pull request #7024: ARROW-8573: [Rust] Upgrade Rust to 1.44 nightly

2020-04-28 Thread GitBox
markhildreth edited a comment on pull request #7024: URL: https://github.com/apache/arrow/pull/7024#issuecomment-620692002 @nevi-me there was a change (https://github.com/apache/arrow/commit/d094631bbb780bc686bebd9a87a0b3e4aa7e0ff0) to that file on master checked in after this branch was

[GitHub] [arrow] jorisvandenbossche commented on issue #7056: AttributeError: module 'pyarrow' has no attribute 'py_buffer'

2020-04-28 Thread GitBox
jorisvandenbossche commented on issue #7056: URL: https://github.com/apache/arrow/issues/7056#issuecomment-620762221 What version did you install? Can you show the output of either `pip list` or `conda list` ? And can you show the full error traceback?

[GitHub] [arrow] paddyhoran commented on pull request #7049: [Rust] Avoid loading simd_load_set_invalid which doesn't exist on aarch64

2020-04-28 Thread GitBox
paddyhoran commented on pull request #7049: URL: https://github.com/apache/arrow/pull/7049#issuecomment-620734617 Would you mind fixing the lint error also please (I know you didn't introduce this)? This is an automated

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-28 Thread GitBox
jorisvandenbossche commented on a change in pull request #7026: URL: https://github.com/apache/arrow/pull/7026#discussion_r416791585 ## File path: python/pyarrow/tests/test_dataset.py ## @@ -373,125 +354,51 @@ def test_partitioning(): assert expr.equals(expected) -def

[GitHub] [arrow] nealrichardson commented on issue #7055: RedHat R Install with no Internet Access

2020-04-28 Thread GitBox
nealrichardson commented on issue #7055: URL: https://github.com/apache/arrow/issues/7055#issuecomment-620764866 What does `pkg-config --version` return? (cf. https://github.com/apache/arrow/blob/master/r/configure#L71) If you don't have `pkg-config` installed, try installing it. If

[GitHub] [arrow] chrish42 commented on pull request #7025: ARROW-2260: [C++][Plasma] Use Gflags for command-line parsing

2020-04-28 Thread GitBox
chrish42 commented on pull request #7025: URL: https://github.com/apache/arrow/pull/7025#issuecomment-620771984 Hmm. The dev / lint failure is from `arrow/rust/parquet/src/util/io.rs`, which I didn't touch... 樂 This is an

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r416049921 ## File path: csharp/src/Apache.Arrow/Arrays/ArrayData.cs ## @@ -84,7 +84,7 @@ public ArrayData Slice(int offset, int length) length =

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r415971988 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r415958451 ## File path: cpp/src/arrow/dataset/file_csv.h ## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r415971888 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] pitrou commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
pitrou commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r415949596 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r415958451 ## File path: cpp/src/arrow/dataset/file_csv.h ## @@ -0,0 +1,52 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] sunchao commented on pull request #6949: ARROW-7681: [Rust] Explicitly seeking a BufReader will discard the internal buffer (2)

2020-04-27 Thread GitBox
sunchao commented on pull request #6949: URL: https://github.com/apache/arrow/pull/6949#issuecomment-620113014 Merged. Thanks @rdettai ! This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r416050847 ## File path: csharp/src/Apache.Arrow/Arrays/PrimitiveArrayBuilder.cs ## @@ -99,43 +105,63 @@ public abstract class PrimitiveArrayBuilder : IArrowArrayBu

[GitHub] [arrow] github-actions[bot] commented on pull request #7046: ARROW-8606: [CI] Don't trigger all builds on a change to any file in ci/

2020-04-27 Thread GitBox
github-actions[bot] commented on pull request #7046: URL: https://github.com/apache/arrow/pull/7046#issuecomment-620134352 https://issues.apache.org/jira/browse/ARROW-8606 This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson opened a new pull request #7046: ARROW-8606: [CI] Don't trigger all builds on a change to any file in ci/

2020-04-27 Thread GitBox
nealrichardson opened a new pull request #7046: URL: https://github.com/apache/arrow/pull/7046 If I edit an R build script, we shouldn't be running JS and Go builds. This is an automated message from the Apache Git Service.

[GitHub] [arrow] fsaintjacques commented on a change in pull request #6979: ARROW-7800 [Python] implement iter_batches() method for ParquetFile and ParquetReader

2020-04-27 Thread GitBox
fsaintjacques commented on a change in pull request #6979: URL: https://github.com/apache/arrow/pull/6979#discussion_r416018166 ## File path: python/pyarrow/_parquet.pyx ## @@ -1083,6 +1084,50 @@ cdef class ParquetReader: def set_use_threads(self, bint use_threads):

[GitHub] [arrow] fsaintjacques commented on a change in pull request #6979: ARROW-7800 [Python] implement iter_batches() method for ParquetFile and ParquetReader

2020-04-27 Thread GitBox
fsaintjacques commented on a change in pull request #6979: URL: https://github.com/apache/arrow/pull/6979#discussion_r416028395 ## File path: python/pyarrow/parquet.py ## @@ -310,6 +310,44 @@ def read_row_groups(self, row_groups, columns=None, use_threads=True,

[GitHub] [arrow] fsaintjacques commented on a change in pull request #6979: ARROW-7800 [Python] implement iter_batches() method for ParquetFile and ParquetReader

2020-04-27 Thread GitBox
fsaintjacques commented on a change in pull request #6979: URL: https://github.com/apache/arrow/pull/6979#discussion_r416027477 ## File path: python/pyarrow/_parquet.pyx ## @@ -1077,6 +1078,54 @@ cdef class ParquetReader: def set_use_threads(self, bint use_threads):

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r415955058 ## File path: csharp/src/Apache.Arrow/Apache.Arrow.csproj ## @@ -4,7 +4,7 @@ netstandard1.3;netcoreapp2.1 true

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r415963714 ## File path: csharp/Directory.Build.props ## @@ -21,6 +21,12 @@ $(CSharpDir)ApacheArrow.snk + + Review comment: This was

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r415981809 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] eerhardt commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
eerhardt commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r416111304 ## File path: csharp/src/Apache.Arrow/Arrays/PrimitiveArrayBuilder.cs ## @@ -162,8 +188,8 @@ public TBuilder Swap(int i, int j) public TArray

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r416115777 ## File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs ## @@ -73,61 +80,88 @@ public TArray Build(MemoryAllocator allocator = default) {

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r416116593 ## File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs ## @@ -48,21 +48,28 @@ public BinaryArray(ArrowTypeId typeId, ArrayData data)

[GitHub] [arrow] BryanCutler commented on pull request #6323: ARROW-7610: [Java] Finish support for 64 bit int allocations

2020-04-27 Thread GitBox
BryanCutler commented on pull request #6323: URL: https://github.com/apache/arrow/pull/6323#issuecomment-620174537 test failure is unrelated, merged to master. Thanks @liyafan82 ! This is an automated message from the Apache

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r416092312 ## File path: csharp/src/Apache.Arrow/Arrays/BooleanArray.cs ## @@ -24,25 +24,38 @@ public class BooleanArray: Array { public class Builder

[GitHub] [arrow] bkietz commented on a change in pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7026: URL: https://github.com/apache/arrow/pull/7026#discussion_r416092830 ## File path: python/pyarrow/_dataset.pyx ## @@ -269,20 +454,21 @@ cdef class FileSystemDataset(Dataset): cdef: CFileSystemDataset*

[GitHub] [arrow] chrish42 commented on a change in pull request #7025: ARROW-2260: [C++][Plasma] Use Gflags for command-line parsing

2020-04-27 Thread GitBox
chrish42 commented on a change in pull request #7025: URL: https://github.com/apache/arrow/pull/7025#discussion_r416057944 ## File path: cpp/src/plasma/store.cc ## @@ -1207,65 +1211,77 @@ void StartServer(char* socket_name, std::string plasma_directory, bool hugepages

[GitHub] [arrow] pitrou commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
pitrou commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r416099536 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] bkietz commented on pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-27 Thread GitBox
bkietz commented on pull request #7026: URL: https://github.com/apache/arrow/pull/7026#issuecomment-620196068 @kszucs @jorisvandenbossche PTAL This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] nealrichardson opened a new pull request #7047: ARROW-8607: [R][CI] Unbreak builds following R 4.0 release

2020-04-27 Thread GitBox
nealrichardson opened a new pull request #7047: URL: https://github.com/apache/arrow/pull/7047 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [arrow] nealrichardson commented on pull request #7047: ARROW-8607: [R][CI] Unbreak builds following R 4.0 release

2020-04-27 Thread GitBox
nealrichardson commented on pull request #7047: URL: https://github.com/apache/arrow/pull/7047#issuecomment-620233527 @github-actions crossbow submit -g r This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r416155042 ## File path: csharp/src/Apache.Arrow/Arrays/BooleanArray.cs ## @@ -153,17 +182,25 @@ private void CheckIndex(int index) new[] {

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r416165482 ## File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs ## @@ -48,21 +48,28 @@ public BinaryArray(ArrowTypeId typeId, ArrayData data)

[GitHub] [arrow] wesm commented on pull request #6154: ARROW-7531: [C++] Reduce header cost

2020-04-27 Thread GitBox
wesm commented on pull request #6154: URL: https://github.com/apache/arrow/pull/6154#issuecomment-620248207 There's a lot of good changes here. I agree that starting fresh and making smaller PRs is the path forward. I'm going to close this for now if that's OK

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r416115591 ## File path: csharp/test/Apache.Arrow.Tests/ArrayBuilderTests.cs ## @@ -149,8 +180,8 @@ public void ProducesExpectedArray()

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r416150841 ## File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs ## @@ -73,61 +80,88 @@ public TArray Build(MemoryAllocator allocator = default) {

[GitHub] [arrow] wesm commented on a change in pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

2020-04-27 Thread GitBox
wesm commented on a change in pull request #7030: URL: https://github.com/apache/arrow/pull/7030#discussion_r416073397 ## File path: cpp/src/jni/dataset/proto/Types.proto ## @@ -0,0 +1,149 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r416090623 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r416110664 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] nealrichardson commented on pull request #7046: ARROW-8606: [CI] Don't trigger all builds on a change to any file in ci/

2020-04-27 Thread GitBox
nealrichardson commented on pull request #7046: URL: https://github.com/apache/arrow/pull/7046#issuecomment-620222893 Rust lint failure is clearly not related. This is an automated message from the Apache Git Service. To

[GitHub] [arrow] wesm commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
wesm commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r416152095 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] wesm commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
wesm commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r416152095 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r416089870 ## File path: csharp/src/Apache.Arrow/Arrays/PrimitiveArrayBuilder.cs ## @@ -162,8 +188,8 @@ public TBuilder Swap(int i, int j) public TArray

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r416097760 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] github-actions[bot] commented on pull request #7047: ARROW-8607: [R][CI] Unbreak builds following R 4.0 release

2020-04-27 Thread GitBox
github-actions[bot] commented on pull request #7047: URL: https://github.com/apache/arrow/pull/7047#issuecomment-620234261 Revision: ee605c39e96f6750e72f1b2d10b929ebffee4015 Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] wesm commented on pull request #7021: Wrap docker-compose commands with archery

2020-04-27 Thread GitBox
wesm commented on pull request #7021: URL: https://github.com/apache/arrow/pull/7021#issuecomment-620234647 > it's pretty straightforward to use docker-compose to reproduce these builds locally I see both sides of this -- with some builds requiring 3 or more `docker-compose build`

[GitHub] [arrow] zgramana commented on a change in pull request #7032: ARROW-6603, ARROW-5708, ARROW-5634: [C#] Adds ArrayBuilder API to support writing null values + BooleanArray null support

2020-04-27 Thread GitBox
zgramana commented on a change in pull request #7032: URL: https://github.com/apache/arrow/pull/7032#discussion_r416154898 ## File path: csharp/src/Apache.Arrow/Arrays/BinaryArray.cs ## @@ -73,61 +80,88 @@ public TArray Build(MemoryAllocator allocator = default) {

[GitHub] [arrow] github-actions[bot] commented on pull request #7047: ARROW-8607: [R][CI] Unbreak builds following R 4.0 release

2020-04-27 Thread GitBox
github-actions[bot] commented on pull request #7047: URL: https://github.com/apache/arrow/pull/7047#issuecomment-620239462 https://issues.apache.org/jira/browse/ARROW-8607 This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson commented on pull request #7026: ARROW-7391: [C++][Dataset] Remove Expression subclasses from bindings

2020-04-27 Thread GitBox
nealrichardson commented on pull request #7026: URL: https://github.com/apache/arrow/pull/7026#issuecomment-620245767 @github-actions autotune everything This is an automated message from the Apache Git Service. To respond

[GitHub] [arrow] pitrou commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-27 Thread GitBox
pitrou commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r416093398 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] kou commented on a change in pull request #7051: ARROW-8612: [GLib] Add GArrowReadOptions and GArrowWriteOptions

2020-04-28 Thread GitBox
kou commented on a change in pull request #7051: URL: https://github.com/apache/arrow/pull/7051#discussion_r416912678 ## File path: c_glib/test/test-write-options.rb ## @@ -0,0 +1,114 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor

[GitHub] [arrow] tobim commented on pull request #6220: ARROW-7605: [C++] Bundle private jemalloc symbols into static library libarrow.a

2020-04-28 Thread GitBox
tobim commented on pull request #6220: URL: https://github.com/apache/arrow/pull/6220#issuecomment-620860363 Bundling jemalloc into `libarrow.a` is probably the right course, but altering the generated archive in a way that CMake doesn't understand complicates the target export quite a

[GitHub] [arrow] wangyuchen opened a new issue #7058: Offline installation on Linux

2020-04-28 Thread GitBox
wangyuchen opened a new issue #7058: URL: https://github.com/apache/arrow/issues/7058 https://github.com/apache/arrow/blob/d1f757339c24ff06e1d39f878323878be64e0369/r/tools/linuxlibs.R#L39-L47 I think there might be a bug in this utility function. In the installation script for

[GitHub] [arrow] wesm commented on pull request #6220: ARROW-7605: [C++] Bundle private jemalloc symbols into static library libarrow.a

2020-04-28 Thread GitBox
wesm commented on pull request #6220: URL: https://github.com/apache/arrow/pull/6220#issuecomment-620883286 @tobim you're welcome to propose an alternative solution and demonstrate how third party applications would be expected to statically link. Since we have install both CMake targets

[GitHub] [arrow] bkietz commented on a change in pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-28 Thread GitBox
bkietz commented on a change in pull request #7033: URL: https://github.com/apache/arrow/pull/7033#discussion_r416941674 ## File path: cpp/src/arrow/dataset/file_csv.cc ## @@ -0,0 +1,99 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] nealrichardson commented on pull request #7039: ARROW-8513: [Python] Expose Take with Table input in Python

2020-04-28 Thread GitBox
nealrichardson commented on pull request #7039: URL: https://github.com/apache/arrow/pull/7039#issuecomment-620829780 Hi @gramirezespinoza, would you mind creating an Apache JIRA account (free and fast) so that I can assign the issue to you?

[GitHub] [arrow] paddyhoran commented on pull request #7049: ARROW-8617: [Rust] Avoid loading simd_load_set_invalid which doesn't exist on aarch64

2020-04-28 Thread GitBox
paddyhoran commented on pull request #7049: URL: https://github.com/apache/arrow/pull/7049#issuecomment-620820630 I'm going to merge this. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] paddyhoran opened a new pull request #7057: ARROW-8616: [Rust] Turn explicit SIMD off by default

2020-04-28 Thread GitBox
paddyhoran opened a new pull request #7057: URL: https://github.com/apache/arrow/pull/7057 We will be removing explicit SIMD in #7037, this PR removes it from the default features in preparation of removing it completely.

[GitHub] [arrow] github-actions[bot] commented on pull request #7057: ARROW-8616: [Rust] Turn explicit SIMD off by default

2020-04-28 Thread GitBox
github-actions[bot] commented on pull request #7057: URL: https://github.com/apache/arrow/pull/7057#issuecomment-620831240 https://issues.apache.org/jira/browse/ARROW-8616 This is an automated message from the Apache Git

[GitHub] [arrow] nealrichardson commented on pull request #7033: ARROW-7759: [C++][Dataset] Add CsvFileFormat

2020-04-28 Thread GitBox
nealrichardson commented on pull request #7033: URL: https://github.com/apache/arrow/pull/7033#issuecomment-620831482 @github-actions rebase This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] wesm commented on issue #7056: AttributeError: module 'pyarrow' has no attribute 'py_buffer'

2020-04-28 Thread GitBox
wesm commented on issue #7056: URL: https://github.com/apache/arrow/issues/7056#issuecomment-620885319 You have a module in your project called `pyarrow.py`. Try calling the file something else and it will work. Closing this

[GitHub] [arrow] emkornfield commented on pull request #7025: ARROW-2260: [C++][Plasma] Use Gflags for command-line parsing

2020-04-28 Thread GitBox
emkornfield commented on pull request #7025: URL: https://github.com/apache/arrow/pull/7025#issuecomment-620986493 @chrish42 do you have a JIRA account setup, I'd like to assign the JIRA to you for book-keeping purposes.

[GitHub] [arrow] emkornfield commented on a change in pull request #7012: ARROW-8555: [FlightRPC][Java] implement DoExchange

2020-04-28 Thread GitBox
emkornfield commented on a change in pull request #7012: URL: https://github.com/apache/arrow/pull/7012#discussion_r417067307 ## File path: java/flight/flight-core/src/main/java/org/apache/arrow/flight/ArrowMessage.java ## @@ -154,6 +154,20 @@ public

[GitHub] [arrow] bnicholl commented on issue #7056: AttributeError: module 'pyarrow' has no attribute 'py_buffer'

2020-04-28 Thread GitBox
bnicholl commented on issue #7056: URL: https://github.com/apache/arrow/issues/7056#issuecomment-620879766 Full error traceback: ``` runfile('/home/boomiuser/s3_connect.py', wdir='/home/boomiuser') Using TensorFlow backend. Traceback (most recent call last): File

[GitHub] [arrow] wesm commented on issue #7058: Offline installation on Linux

2020-04-28 Thread GitBox
wesm commented on issue #7058: URL: https://github.com/apache/arrow/issues/7058#issuecomment-620885873 Can you please open a JIRA issue? This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] wesm commented on pull request #7025: ARROW-2260: [C++][Plasma] Use Gflags for command-line parsing

2020-04-28 Thread GitBox
wesm commented on pull request #7025: URL: https://github.com/apache/arrow/pull/7025#issuecomment-620886116 @chrish42 you can ignore the Rust lint failures until the Rust nightly linting issues are resolved This is an

[GitHub] [arrow] github-actions[bot] commented on pull request #7059: Allow the parquet crate to be compiled on aarch64 platforms

2020-04-28 Thread GitBox
github-actions[bot] commented on pull request #7059: URL: https://github.com/apache/arrow/pull/7059#issuecomment-620983012 Thanks for opening a pull request! Could you open an issue for this pull request on JIRA? https://issues.apache.org/jira/browse/ARROW Then

[GitHub] [arrow] emkornfield commented on pull request #7025: ARROW-2260: [C++][Plasma] Use Gflags for command-line parsing

2020-04-28 Thread GitBox
emkornfield commented on pull request #7025: URL: https://github.com/apache/arrow/pull/7025#issuecomment-620985725 This seems like a strictly cleaner code, so I'll merge. Thanks @chrish42 This is an automated message from

[GitHub] [arrow] emkornfield commented on pull request #6956: ARROW-8481: [Java] Provide an allocation manager based on Unsafe API

2020-04-28 Thread GitBox
emkornfield commented on pull request #6956: URL: https://github.com/apache/arrow/pull/6956#issuecomment-620988584 @BryanCutler I think you had opinions on this from the original PR do you mind taking a look? This is an

[GitHub] [arrow] emkornfield commented on a change in pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

2020-04-28 Thread GitBox
emkornfield commented on a change in pull request #7030: URL: https://github.com/apache/arrow/pull/7030#discussion_r417074805 ## File path: java/dataset/src/main/java/org/apache/arrow/dataset/scanner/ScanTask.java ## @@ -0,0 +1,42 @@ +/* + * Licensed to the Apache Software

[GitHub] [arrow] emkornfield commented on a change in pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

2020-04-28 Thread GitBox
emkornfield commented on a change in pull request #7030: URL: https://github.com/apache/arrow/pull/7030#discussion_r417074480 ## File path: cpp/src/jni/dataset/jni_wrapper.cpp ## @@ -0,0 +1,577 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] rtyler opened a new pull request #7059: Allow the parquet crate to be compiled on aarch64 platforms

2020-04-28 Thread GitBox
rtyler opened a new pull request #7059: URL: https://github.com/apache/arrow/pull/7059 The following compile error shows up on aarch64 because the body of `hash_` was `#cfg`'d to basically empty. ``` error[E0308]: mismatched types -->

[GitHub] [arrow] emkornfield commented on a change in pull request #7029: ARROW-8579 [C++] Add AVX512 SIMD for spaced decoding and encoding.

2020-04-28 Thread GitBox
emkornfield commented on a change in pull request #7029: URL: https://github.com/apache/arrow/pull/7029#discussion_r417059483 ## File path: cpp/src/arrow/util/spaced.h ## @@ -0,0 +1,266 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more contributor

[GitHub] [arrow] lidavidm commented on pull request #6744: PARQUET-1820: [C++] pre-buffer specified columns of row group

2020-04-28 Thread GitBox
lidavidm commented on pull request #6744: URL: https://github.com/apache/arrow/pull/6744#issuecomment-620922987 One thing for consideration: we've been looking at using this with buffering multiple files in memory. (This way, any unexpected latency in I/O for subsequent files gets hidden

[GitHub] [arrow] zhztheplayer commented on a change in pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

2020-04-28 Thread GitBox
zhztheplayer commented on a change in pull request #7030: URL: https://github.com/apache/arrow/pull/7030#discussion_r417034247 ## File path: cpp/src/jni/dataset/proto/Types.proto ## @@ -0,0 +1,149 @@ +// Licensed to the Apache Software Foundation (ASF) under one +// or more

[GitHub] [arrow] fsaintjacques commented on pull request #7052: ARROW-5572, ARROW-5310, ARROW-5666: [Python] ParquetDataset tests for new implementation

2020-04-28 Thread GitBox
fsaintjacques commented on pull request #7052: URL: https://github.com/apache/arrow/pull/7052#issuecomment-620963970 I'll let you rebase with the other. This is an automated message from the Apache Git Service. To respond to

[GitHub] [arrow] github-actions[bot] commented on pull request #7041: ARROW-8584: [C++] Fix ORC link order

2020-04-25 Thread GitBox
github-actions[bot] commented on pull request #7041: URL: https://github.com/apache/arrow/pull/7041#issuecomment-619456125 Revision: 3e57660bbcb5002a8c53146754146fc7c92b1ead Submitted crossbow builds: [ursa-labs/crossbow @

[GitHub] [arrow] kou opened a new pull request #7041: ARROW-8584: [C++] Fix ORC link order

2020-04-25 Thread GitBox
kou opened a new pull request #7041: URL: https://github.com/apache/arrow/pull/7041 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

<    1   2   3   4   5   6   7   8   9   10   >