emkornfield commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415231929
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
emkornfield commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r415221009
##
File path: cpp/src/parquet/level_conversion_test.cc
##
@@ -0,0 +1,162 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
emkornfield commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r415221052
##
File path: cpp/cmake_modules/SetupCxxFlags.cmake
##
@@ -40,12 +40,13 @@ if(ARROW_CPU_FLAG STREQUAL "x86")
set(CXX_SUPPORTS_SSE4_2 TRUE)
emkornfield commented on pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#issuecomment-619488093
@pitrou I think I addressed your comments. One of them that went stale was
the complexity for "AppendWord", I tried to remove parts that did not seem to
affect performance
tianchen92 commented on a change in pull request #6912:
URL: https://github.com/apache/arrow/pull/6912#discussion_r415229312
##
File path:
java/vector/src/main/java/org/apache/arrow/vector/complex/NonNullableStructVector.java
##
@@ -320,6 +322,20 @@ public int hashCode(int
tianchen92 commented on a change in pull request #6912:
URL: https://github.com/apache/arrow/pull/6912#discussion_r415229163
##
File path: java/vector/src/main/java/org/apache/arrow/vector/ValueVector.java
##
@@ -283,4 +283,10 @@
* @return the name of the vector.
*/
emkornfield commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415229227
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
jianxind commented on pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#issuecomment-619501029
> Just curious if you see and impact on parquet-arrow-reader-writer
benchmarks? That is the ultimate goal of the speedup.
No impact, I checked all items for
tianchen92 opened a new pull request #6912:
URL: https://github.com/apache/arrow/pull/6912
Related to [ARROW-8020](https://issues.apache.org/jira/browse/ARROW-8020).
In C++ side, we already have array validate functionality but no similar
functionality in Java side.
This issue is
emkornfield commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r414295562
##
File path: cpp/cmake_modules/SetupCxxFlags.cmake
##
@@ -40,12 +40,13 @@ if(ARROW_CPU_FLAG STREQUAL "x86")
set(CXX_SUPPORTS_SSE4_2 TRUE)
emkornfield commented on a change in pull request #6954:
URL: https://github.com/apache/arrow/pull/6954#discussion_r415228325
##
File path: cpp/src/arrow/util/simd.h
##
@@ -17,6 +17,24 @@
#pragma once
+#ifdef _MSC_VER
+// MSVC x86_64/arm64
+
+#if defined(_M_AMD64) ||
emkornfield commented on a change in pull request #6954:
URL: https://github.com/apache/arrow/pull/6954#discussion_r415226340
##
File path: cpp/src/arrow/util/hash_util.h
##
@@ -27,39 +27,27 @@
#include "arrow/util/logging.h"
#include "arrow/util/macros.h"
-#include
jianxind commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415246739
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
emkornfield commented on a change in pull request #6954:
URL: https://github.com/apache/arrow/pull/6954#discussion_r415226495
##
File path: cpp/src/arrow/util/hash_util.h
##
@@ -27,39 +27,27 @@
#include "arrow/util/logging.h"
#include "arrow/util/macros.h"
-#include
emkornfield commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415230291
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
zhztheplayer commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r415256413
##
File path: cpp/src/jni/dataset/concurrent_map.h
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
emkornfield commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415230959
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
emkornfield commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415231122
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
emkornfield commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415231200
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
emkornfield commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415229405
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
emkornfield commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r415229405
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor
zhztheplayer commented on a change in pull request #7030:
URL: https://github.com/apache/arrow/pull/7030#discussion_r415256413
##
File path: cpp/src/jni/dataset/concurrent_map.h
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more
sunchao commented on a change in pull request #6935:
URL: https://github.com/apache/arrow/pull/6935#discussion_r414738189
##
File path: rust/parquet/src/column/reader.rs
##
@@ -190,15 +190,12 @@ impl ColumnReaderImpl {
(self.num_buffered_values -
BryanCutler commented on a change in pull request #6323:
URL: https://github.com/apache/arrow/pull/6323#discussion_r414695756
##
File path:
java/memory/src/main/java/org/apache/arrow/memory/NettyAllocationManager.java
##
@@ -17,48 +17,97 @@
package org.apache.arrow.memory;
nealrichardson commented on pull request #7028:
URL: https://github.com/apache/arrow/pull/7028#issuecomment-619074972
I'm not worried about security risks in this particular case. If someone
random person wants to rebase my PR on apache/arrow@master, great! Now I don't
have to! While I
nevi-me commented on a change in pull request #6306:
URL: https://github.com/apache/arrow/pull/6306#discussion_r414662522
##
File path: rust/arrow/src/compute/kernels/sort.rs
##
@@ -0,0 +1,671 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
nevi-me commented on a change in pull request #6306:
URL: https://github.com/apache/arrow/pull/6306#discussion_r414663303
##
File path: rust/arrow/src/compute/kernels/sort.rs
##
@@ -0,0 +1,671 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more
nealrichardson commented on a change in pull request #7026:
URL: https://github.com/apache/arrow/pull/7026#discussion_r414680234
##
File path: r/src/expression.cpp
##
@@ -21,99 +21,97 @@
// [[arrow::export]]
std::shared_ptr dataset___expr__field_ref(std::string name) {
-
kiszk commented on a change in pull request #7029:
URL: https://github.com/apache/arrow/pull/7029#discussion_r414739332
##
File path: cpp/src/arrow/util/spaced.h
##
@@ -0,0 +1,266 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
sunchao commented on a change in pull request #6935:
URL: https://github.com/apache/arrow/pull/6935#discussion_r414738189
##
File path: rust/parquet/src/column/reader.rs
##
@@ -190,15 +190,12 @@ impl ColumnReaderImpl {
(self.num_buffered_values -
sunchao commented on pull request #6949:
URL: https://github.com/apache/arrow/pull/6949#issuecomment-619140531
> It's the reader (file handle) that is passed to it that should be thread
safe
Is [file](https://doc.rust-lang.org/std/fs/struct.File.html) thread-safe?
it's not obvious
pitrou opened a new pull request #7031:
URL: https://github.com/apache/arrow/pull/7031
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
fsaintjacques commented on pull request #7022:
URL: https://github.com/apache/arrow/pull/7022#issuecomment-619186142
I'd say just plain HTTP, as @lidavidm pointed in his comment, this is a
network attribute.
This is an
andygrove commented on pull request #7018:
URL: https://github.com/apache/arrow/pull/7018#issuecomment-619202633
Let's see what others say on this. Personally, I think it would be better
for build.rs to automatically prepend the ASF license header because there is
the risk of someone
github-actions[bot] commented on pull request #7033:
URL: https://github.com/apache/arrow/pull/7033#issuecomment-619195315
https://issues.apache.org/jira/browse/ARROW-7759
This is an automated message from the Apache Git
Zhen-hao opened a new issue #7034:
URL: https://github.com/apache/arrow/issues/7034
Hi there,
this is more a question than a bug request.
I am using NixOS 20.03 and couldn't get the arrow library in R to see the
arrow C++ library.
Even when I install the library from R
nealrichardson commented on pull request #7033:
URL: https://github.com/apache/arrow/pull/7033#issuecomment-619213038
@github-actions rebase
This is an automated message from the Apache Git Service.
To respond to the
nealrichardson commented on pull request #6879:
URL: https://github.com/apache/arrow/pull/6879#issuecomment-619212781
@github-actions rebase
This is an automated message from the Apache Git Service.
To respond to the
markhildreth opened a new pull request #7035:
URL: https://github.com/apache/arrow/pull/7035
Fixes [ARROW-8590](https://issues.apache.org/jira/browse/ARROW-8590)
This builds on #6972, and thus should be merged after that PR is merged.
markhildreth commented on pull request #6972:
URL: https://github.com/apache/arrow/pull/6972#issuecomment-619215502
Created [follow-up JIRA
task](https://issues.apache.org/jira/browse/ARROW-8590).
This is an automated
vertexclique opened a new pull request #7036:
URL: https://github.com/apache/arrow/pull/7036
This PR enables reverse lookup for already built dict.
This is an automated message from the Apache Git Service.
To respond to the
zgramana opened a new pull request #7032:
URL: https://github.com/apache/arrow/pull/7032
Takes an alternative approach to completing
[ARROW-6603](https://issues.apache.org/jira/browse/ARROW-6603) that is in-line
with the current API and with other Arrow implementations. More
mayuropensource commented on pull request #7022:
URL: https://github.com/apache/arrow/pull/7022#issuecomment-619184138
@fsaintjacques, I can try to put together a python script using boto to
determine the S3 metrics. Will that work for you?
nealrichardson commented on issue #7034:
URL: https://github.com/apache/arrow/issues/7034#issuecomment-619210756
We don't do any testing on NixOS, so it's not surprising that it doesn't
just work.
http://arrow.apache.org/docs/r/articles/install.html describes how
dependencies are
github-actions[bot] commented on pull request #7031:
URL: https://github.com/apache/arrow/pull/7031#issuecomment-619156566
https://issues.apache.org/jira/browse/ARROW-8587
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7032:
URL: https://github.com/apache/arrow/pull/7032#issuecomment-619164076
https://issues.apache.org/jira/browse/ARROW-6603
This is an automated message from the Apache Git
nevi-me commented on pull request #7024:
URL: https://github.com/apache/arrow/pull/7024#issuecomment-619189091
@paddyhoran we might have to try a different nightly, as sometimes a day's
version might have no rustfmt. The change I made in that PR installs a nightly
version, I don't know
bkietz opened a new pull request #7033:
URL: https://github.com/apache/arrow/pull/7033
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
github-actions[bot] commented on pull request #7035:
URL: https://github.com/apache/arrow/pull/7035#issuecomment-619219686
https://issues.apache.org/jira/browse/ARROW-8590
This is an automated message from the Apache Git
github-actions[bot] commented on pull request #7036:
URL: https://github.com/apache/arrow/pull/7036#issuecomment-619219685
https://issues.apache.org/jira/browse/ARROW-8591
This is an automated message from the Apache Git
zgramana commented on pull request #6121:
URL: https://github.com/apache/arrow/pull/6121#issuecomment-619162558
@eerhardt I've just submitted https://github.com/apache/arrow/pull/7032 for
review/discussion
This is an
durch opened a new pull request #7042:
URL: https://github.com/apache/arrow/pull/7042
+ Pedantic fixes to `unsafe`
+ Changes to function arguments to pass in references or values as
appropriate
+ Refactor pointer arithmetic to use `usize` instead of `isize` casting
+ Ignore
github-actions[bot] commented on pull request #7042:
URL: https://github.com/apache/arrow/pull/7042#issuecomment-619599024
https://issues.apache.org/jira/browse/ARROW-8597
This is an automated message from the Apache Git
github-actions[bot] commented on issue #7014:
URL: https://github.com/apache/arrow/pull/7014#issuecomment-617881461
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you
kiszk commented on issue #6954:
URL: https://github.com/apache/arrow/pull/6954#issuecomment-617854855
Is the function `Armv8CrcHashParallel` uses somewhere? Sorry if I overlook
it.
This is an automated message from the
kiszk edited a comment on issue #6954:
URL: https://github.com/apache/arrow/pull/6954#issuecomment-617854855
Is the function `Armv8CrcHashParallel` used somewhere? Sorry if I overlook
it.
This is an automated message from
kszucs commented on issue #7000:
URL: https://github.com/apache/arrow/pull/7000#issuecomment-617868408
@ursabot build
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mindhash opened a new pull request #7014:
URL: https://github.com/apache/arrow/pull/7014
Hello team,
This minor change makes newBuilder() public to reduce verbosity in upstream.
To give you example, I am working on a parquet read / write into Arrow
Record batch where the parquet
pitrou commented on a change in pull request #6954:
URL: https://github.com/apache/arrow/pull/6954#discussion_r413092039
##
File path: cpp/src/arrow/util/hash_util.h
##
@@ -27,39 +27,27 @@
#include "arrow/util/logging.h"
#include "arrow/util/macros.h"
-#include
davidanthoff commented on a change in pull request #7001:
URL: https://github.com/apache/arrow/pull/7001#discussion_r412497174
##
File path: cpp/cmake_modules/FindThrift.cmake
##
@@ -100,7 +100,7 @@ if(Thrift_FOUND OR THRIFT_FOUND)
kszucs commented on issue #6883:
URL: https://github.com/apache/arrow/pull/6883#issuecomment-617350272
The release is out, we can close this PR.
This is an automated message from the Apache Git Service.
To respond to the
kou commented on a change in pull request #7001:
URL: https://github.com/apache/arrow/pull/7001#discussion_r412492656
##
File path: cpp/cmake_modules/FindThrift.cmake
##
@@ -100,7 +100,7 @@ if(Thrift_FOUND OR THRIFT_FOUND)
fsaintjacques commented on a change in pull request #7000:
URL: https://github.com/apache/arrow/pull/7000#discussion_r412407398
##
File path: cpp/src/arrow/dataset/dataset.cc
##
@@ -72,36 +78,15 @@ Result> Dataset::NewScan() {
return NewScan(std::make_shared());
}
-bool
wesm commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r412474320
##
File path: cpp/src/parquet/file_reader.h
##
@@ -117,6 +117,15 @@ class PARQUET_EXPORT ParquetFileReader {
// Returns the file metadata. Only one
github-actions[bot] commented on issue #7005:
URL: https://github.com/apache/arrow/pull/7005#issuecomment-617456224
https://issues.apache.org/jira/browse/ARROW-8550
This is an automated message from the Apache Git Service.
bkietz commented on a change in pull request #7000:
URL: https://github.com/apache/arrow/pull/7000#discussion_r412252930
##
File path: cpp/src/arrow/dataset/dataset.h
##
@@ -84,13 +82,12 @@ class ARROW_DS_EXPORT Fragment {
class ARROW_DS_EXPORT InMemoryFragment : public
github-actions[bot] commented on issue #7004:
URL: https://github.com/apache/arrow/pull/7004#issuecomment-617398778
https://issues.apache.org/jira/browse/ARROW-3827
This is an automated message from the Apache Git Service.
paddyhoran commented on issue #6306:
URL: https://github.com/apache/arrow/pull/6306#issuecomment-617402123
@nevi-me this needs a rebase now. Once you do that, I'll take a look so we
can get this merged.
This is an
working-estimate opened a new issue #7003:
URL: https://github.com/apache/arrow/issues/7003
I have tried versions 0.15.1, 0.16.0, 0.17.0. Same error on all. I've seen
in other issues that co-installations of tensorflow and numpy might be causing
issues. I have tensorflow==1.14.0 and
fsaintjacques commented on a change in pull request #7000:
URL: https://github.com/apache/arrow/pull/7000#discussion_r412452967
##
File path: python/pyarrow/tests/test_dataset.py
##
@@ -671,41 +669,29 @@ def test_fragments(tempdir):
f = fragments[0]
# file's schema
davidanthoff commented on a change in pull request #7001:
URL: https://github.com/apache/arrow/pull/7001#discussion_r412497174
##
File path: cpp/cmake_modules/FindThrift.cmake
##
@@ -100,7 +100,7 @@ if(Thrift_FOUND OR THRIFT_FOUND)
github-actions[bot] commented on issue #6995:
URL: https://github.com/apache/arrow/pull/6995#issuecomment-617445300
Revision: e7dbd9c977b765e618a40e997039be773c9f16bf
Submitted crossbow builds: [ursa-labs/crossbow @
paddyhoran commented on a change in pull request #6980:
URL: https://github.com/apache/arrow/pull/6980#discussion_r412473292
##
File path: rust/arrow/src/array/builder.rs
##
@@ -236,6 +251,14 @@ impl BufferBuilderTrait for
BufferBuilder {
wesm commented on a change in pull request #6744:
URL: https://github.com/apache/arrow/pull/6744#discussion_r412465641
##
File path: cpp/src/parquet/properties.h
##
@@ -56,10 +60,32 @@ class PARQUET_EXPORT ReaderProperties {
bool is_buffered_stream_enabled() const {
nealrichardson commented on issue #6995:
URL: https://github.com/apache/arrow/pull/6995#issuecomment-617444872
@github-actions crossbow submit -g r
This is an automated message from the Apache Git Service.
To respond to the
davidanthoff commented on issue #7001:
URL: https://github.com/apache/arrow/pull/7001#issuecomment-617365369
> How does BinaryBuilder compile Windows binaries on Linux? Using MinGW?
Yes, it uses MinGW for Windows, but then it also cross-compiles to lots of
other platforms. The PR
paddyhoran commented on issue #6209:
URL: https://github.com/apache/arrow/pull/6209#issuecomment-617389640
Closing and I'll open a new PR.
This is an automated message from the Apache Git Service.
To respond to the message,
github-actions[bot] commented on issue #6995:
URL: https://github.com/apache/arrow/pull/6995#issuecomment-617442386
https://issues.apache.org/jira/browse/ARROW-8549
This is an automated message from the Apache Git Service.
andygrove commented on a change in pull request #6770:
URL: https://github.com/apache/arrow/pull/6770#discussion_r413404215
##
File path: rust/datafusion/src/utils.rs
##
@@ -74,6 +74,29 @@ macro_rules! make_string {
}};
}
+macro_rules! make_string_from_list {
+
andygrove commented on a change in pull request #6770:
URL: https://github.com/apache/arrow/pull/6770#discussion_r413404556
##
File path: rust/datafusion/src/utils.rs
##
@@ -120,6 +143,7 @@ pub fn array_value_to_string(column: array::ArrayRef, row:
usize) -> Result {
andygrove commented on a change in pull request #7004:
URL: https://github.com/apache/arrow/pull/7004#discussion_r413408444
##
File path: rust/arrow/src/array/mod.rs
##
@@ -85,6 +85,7 @@ mod array;
mod builder;
mod data;
mod equal;
+mod union;
Review comment:
I
andygrove commented on a change in pull request #7004:
URL: https://github.com/apache/arrow/pull/7004#discussion_r413408241
##
File path: rust/arrow/src/array/equal.rs
##
@@ -1046,6 +1062,30 @@ impl PartialEq for Value {
}
}
+impl JsonEqual for UnionArray {
+fn
andygrove commented on issue #6972:
URL: https://github.com/apache/arrow/pull/6972#issuecomment-618100341
Thanks @markhildreth for the detailed write-up in the JIRA! I've started
looking through this.
I'm not sure I understand all the points you made yet, but if there is a way
to
wesm commented on issue #5947:
URL: https://github.com/apache/arrow/pull/5947#issuecomment-618107435
@praveenbingo @projjal would you be able to take a look now?
This is an automated message from the Apache Git Service.
To
fsaintjacques commented on issue #7011:
URL: https://github.com/apache/arrow/pull/7011#issuecomment-61869
I understood that @bkietz added an entry for this, maybe it doesn't have the
benchmark enabled?
This is an
wesm commented on issue #7011:
URL: https://github.com/apache/arrow/pull/7011#issuecomment-618111873
manylinux1 uses gcc 4.8 but does not build the benchmarks.
This is an automated message from the Apache Git Service.
To
houqp commented on issue #7009:
URL: https://github.com/apache/arrow/pull/7009#issuecomment-618158794
@nevi-me rebased and tests are passing now :)
This is an automated message from the Apache Git Service.
To respond to the
andygrove commented on a change in pull request #6770:
URL: https://github.com/apache/arrow/pull/6770#discussion_r413403760
##
File path: rust/datafusion/src/utils.rs
##
@@ -74,6 +74,29 @@ macro_rules! make_string {
}};
}
+macro_rules! make_string_from_list {
+
andygrove commented on a change in pull request #6770:
URL: https://github.com/apache/arrow/pull/6770#discussion_r413403453
##
File path: rust/datafusion/src/logicalplan.rs
##
@@ -828,8 +828,8 @@ mod tests {
.build()?;
let expected = "Projection: #id\
-
andygrove commented on issue #4140:
URL: https://github.com/apache/arrow/pull/4140#issuecomment-618098211
@bryantbiggs I will take a look at the release tag issue this weekend.
This is an automated message from the Apache
fsaintjacques commented on issue #7000:
URL: https://github.com/apache/arrow/pull/7000#issuecomment-618110604
Addressed most comments and updated followup ticket with what's missing.
PTAL and merge quickly so we can unblock the blocked tickets :)
xuancong84 opened a new issue #7017:
URL: https://github.com/apache/arrow/issues/7017
Dear developers, I realize that complex numbers in Numpy arrays and Pandas
dataframe/series can be serialized, but complex numbers in Python structures
(e.g., `[1, 2.5, 3+1.j, np.nan]`) cannot be
kou commented on issue #6996:
URL: https://github.com/apache/arrow/pull/6996#issuecomment-618066972
Could you make a JIRA?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mcassels commented on issue #6770:
URL: https://github.com/apache/arrow/pull/6770#issuecomment-618082896
@andygrove @nevi-me do you have any thoughts on this?
This is an automated message from the Apache Git Service.
To
wesm commented on issue #7011:
URL: https://github.com/apache/arrow/pull/7011#issuecomment-618102656
Another gcc 4.8 issue here. We may need a more comprehensive build that also
builds the benchmark executables
This is an
fsaintjacques commented on a change in pull request #6985:
URL: https://github.com/apache/arrow/pull/6985#discussion_r413428461
##
File path: cpp/src/arrow/util/bit_util.h
##
@@ -43,13 +43,18 @@
#if defined(_MSC_VER)
#include
+#include
#pragma intrinsic(_BitScanReverse)
andygrove commented on a change in pull request #7004:
URL: https://github.com/apache/arrow/pull/7004#discussion_r413407658
##
File path: rust/arrow/src/array/equal.rs
##
@@ -692,6 +692,22 @@ impl ArrayEqual for StructArray {
}
}
+impl ArrayEqual for UnionArray {
+
andygrove commented on a change in pull request #7004:
URL: https://github.com/apache/arrow/pull/7004#discussion_r413407264
##
File path: rust/arrow/src/array/equal.rs
##
@@ -692,6 +692,22 @@ impl ArrayEqual for StructArray {
}
}
+impl ArrayEqual for UnionArray {
+
github-actions[bot] commented on issue #7014:
URL: https://github.com/apache/arrow/pull/7014#issuecomment-618187424
https://issues.apache.org/jira/browse/ARROW-8563
This is an automated message from the Apache Git Service.
tustvold commented on a change in pull request #6980:
URL: https://github.com/apache/arrow/pull/6980#discussion_r412736972
##
File path: rust/arrow/src/array/builder.rs
##
@@ -236,6 +251,14 @@ impl BufferBuilderTrait for
BufferBuilder {
301 - 400 of 172163 matches
Mail list logo