[GitHub] [arrow] emkornfield commented on pull request #7188: ARROW-8803: [Java] Row count should be set before loading buffers in VectorLoader
emkornfield commented on pull request #7188: URL: https://github.com/apache/arrow/pull/7188#issuecomment-629047852 master should be fixed now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7188: ARROW-8803: [Java] Row count should be set before loading buffers in VectorLoader
emkornfield commented on pull request #7188: URL: https://github.com/apache/arrow/pull/7188#issuecomment-629032828 No it looks like a broke some things merging PRs This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] emkornfield commented on pull request #7188: ARROW-8803: [Java] Row count should be set before loading buffers in VectorLoader
emkornfield commented on pull request #7188: URL: https://github.com/apache/arrow/pull/7188#issuecomment-629010817 Thanks for the PR @rongma1997. I'm not clear if the failure in ORC is caused by this change. could you try rebasing? I'm also not sure how I feel about moving the setRowCount around without a complete implementation for compressed buffers (i.e. I don't know if something else will need to change). At least a unit test showing why this is needed would be worthwhile. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
