[GitHub] [arrow] kou commented on a change in pull request #6512: ARROW-8430: [CI] Configure self-hosted runners for Github Actions

2020-06-16 Thread GitBox 


kou commented on a change in pull request #6512:
URL: https://github.com/apache/arrow/pull/6512#discussion_r441156336



##
File path: ci/docker/ubuntu-14.04-cpp.dockerfile
##
@@ -68,7 +68,7 @@ ENV ARROW_BUILD_TESTS=ON \
 ARROW_WITH_BROTLI=ON \
 ARROW_WITH_BZ2=ON \
 ARROW_WITH_LZ4=ON \
-ARROW_WITH_OPENSSL=OFF \
+PARQUET_REQUIRE_ENCRYPTION=OFF \

Review comment:
   Could you sort in alphabetical order?

##
File path: ci/scripts/cpp_build.sh
##
@@ -127,7 +127,11 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
   ${CMAKE_ARGS} \
   ${source_dir}
 
-time cmake --build . --target install
+if [ ! -z "${CPP_MAKE_PARALLELISM}" ]; then
+  time cmake --build . --target install -- -j${CPP_MAKE_PARALLELISM}

Review comment:
   Does `CMAKE_BUILD_PARALLEL_LEVEL` not work with Ubuntu 20.04?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kou commented on a change in pull request #6512: ARROW-8430: [CI] Configure self-hosted runners for Github Actions [WIP][skip ci]

2020-06-10 Thread GitBox 


kou commented on a change in pull request #6512:
URL: https://github.com/apache/arrow/pull/6512#discussion_r438429415



##
File path: .github/workflows/cpp_cron.yml
##
@@ -95,12 +95,13 @@ jobs:
   - name: Setup Python
 uses: actions/setup-python@v1
 with:
-  python-version: 3.8
+  python-version: 3.6

Review comment:
   Can we revert this?

##
File path: .github/workflows/cpp_cron.yml
##
@@ -95,12 +95,13 @@ jobs:
   - name: Setup Python
 uses: actions/setup-python@v1
 with:
-  python-version: 3.8
+  python-version: 3.6
+  - name: Setup Core Pattern
+run: sudo sysctl -w kernel.core_pattern="core.%e.%p"

Review comment:
   Can we revert this?

##
File path: ci/scripts/cpp_build.sh
##
@@ -127,7 +127,11 @@ cmake -G "${CMAKE_GENERATOR:-Ninja}" \
   ${CMAKE_ARGS} \
   ${source_dir}
 
-time cmake --build . --target install
+if [ ! -z "${CPP_MAKE_PARALLELISM}" ]; then
+  time cmake --build . --target install -- -j${CPP_MAKE_PARALLELISM}

Review comment:
   We can use the `CMAKE_BUILD_PARALLEL_LEVEL` environment variable here: 
https://cmake.org/cmake/help/latest/envvar/CMAKE_BUILD_PARALLEL_LEVEL.html

##
File path: .github/workflows/cpp_cron.yml
##
@@ -122,10 +123,8 @@ jobs:
 with:
   fetch-depth: 0
   - name: Fetch Submodules and Tags
-shell: bash

Review comment:
   Can we revert this?

##
File path: .github/workflows/cpp.yml
##
@@ -92,6 +92,67 @@ jobs:
 continue-on-error: true
 run: archery docker push ${{ matrix.image }}
 
+  docker-arm:
+# NOTE: this job is specific for self-hosted runners
+# CACHING: don't use the cache plugin because of various permission
+#  issues and keep the cached docker volumes permanently on the
+#  host
+# PYTHON: no distrubutions are build for arm machines by the github
+# actions team, so python>3.6 must be preinstalled on the self
+# hosted machines
+name: ${{ matrix.title }}
+runs-on: ${{ matrix.runner }}
+# if: ${{ !contains(github.event.pull_request.title, 'WIP') && 
github.repository == 'apache/arrow' }}
+defaults:
+  # to use certain environment variables are set by .bashrc an interactive
+  # bash shell must be used
+  run:
+shell: bash -i {0}

Review comment:
   How about using `env: ...` instead of `bash -i`?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org