[GitHub] [arrow] kou commented on pull request #7449: ARROW-9133: [C++] Add utf8_upper and utf8_lower

2020-06-24 Thread GitBox 


kou commented on pull request #7449:
URL: https://github.com/apache/arrow/pull/7449#issuecomment-649090497


   Rebased.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kou commented on pull request #7449: ARROW-9133: [C++] Add utf8_upper and utf8_lower

2020-06-24 Thread GitBox 


kou commented on pull request #7449:
URL: https://github.com/apache/arrow/pull/7449#issuecomment-649065240


   Oh, sorry.
   It seems that I saw wrong CI jobs.
   The link problem has been fixed by the workaround.
   
   I'll cherry pick the workaround to https://github.com/apache/arrow/pull/7452 
and merge it.
   Then I'll rebase this branch.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kou commented on pull request #7449: ARROW-9133: [C++] Add utf8_upper and utf8_lower

2020-06-23 Thread GitBox 


kou commented on pull request #7449:
URL: https://github.com/apache/arrow/pull/7449#issuecomment-648518023


   I've added a workaround we already used: 
https://github.com/apache/arrow/pull/7449/commits/782499f8641da4a23d86125bcc812546107f2ce5
   
   But it doesn't solve this yet.
   
   I'm trying reproducing this on my local environment.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kou commented on pull request #7449: ARROW-9133: [C++] Add utf8_upper and utf8_lower

2020-06-22 Thread GitBox 


kou commented on pull request #7449:
URL: https://github.com/apache/arrow/pull/7449#issuecomment-647834815


   The change doesn't add `UTF8PROC_STATIC` definition...



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kou commented on pull request #7449: ARROW-9133: [C++] Add utf8_upper and utf8_lower

2020-06-22 Thread GitBox 


kou commented on pull request #7449:
URL: https://github.com/apache/arrow/pull/7449#issuecomment-647791287


   Ah, we need the `UTF8PROC_STATIC` definition.
   
   Does this work?
   
   ```diff
   diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake 
b/cpp/cmake_modules/ThirdpartyToolchain.cmake
   index 5ab29cf2c..aa2bbf0dd 100644
   --- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
   +++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
   @@ -2060,7 +2060,9 @@ macro(build_utf8proc)
  set_target_properties(utf8proc::utf8proc
PROPERTIES IMPORTED_LOCATION 
"${UTF8PROC_STATIC_LIB}"
   INTERFACE_INCLUDE_DIRECTORIES
   -   "${UTF8PROC_PREFIX}/include")
   +   "${UTF8PROC_PREFIX}/include"
   +   INTERFACE_COMPILER_DEFINITIONS
   +   "UTF8PROC_STATIC")

  add_dependencies(toolchain utf8proc_ep)
  add_dependencies(utf8proc::utf8proc utf8proc_ep)
   ```



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org