[GitHub] [arrow] kszucs commented on a change in pull request #7497: ARROW-8149: [C++/Python] Enable CUDA Support in conda recipes

2020-06-22 Thread GitBox


kszucs commented on a change in pull request #7497:
URL: https://github.com/apache/arrow/pull/7497#discussion_r443447582



##
File path: dev/tasks/conda-recipes/arrow-cpp/meta.yaml
##
@@ -1,124 +1,237 @@
+{% set version = ARROW_VERSION %}
+{% set number = "6" %}
+{% set cuda_enabled = cuda_compiler_version is not undefined and 
cuda_compiler_version == '9.2' %}
+{% set build_ext_version = "1.0.0" %}
+{% set build_ext = "cuda" if cuda_enabled else "cpu" %}
+{% set build_string = "py{}h{}_{}_{}".format(CONDA_PY, PKG_HASH, number, 
build_ext) %}
+{% set proc_build_number = "1" %}
+
 package:
-  name: arrow-cpp
-  version: {{ ARROW_VERSION }}
+  name: arrow-cpp-ext
+  version: {{ version }}
 
 source:
   path: ../../../../
 
 build:
-  build:
-  number: 0
-  skip: true  # [win and vc<14]
+  number: {{ number }}
+  skip: true  # [cuda_compiler_version not in (undefined, "None", "9.2")]
   run_exports:
-- {{ pin_subpackage("arrow-cpp", max_pin="x.x") }}
+- {{ pin_subpackage("arrow-cpp", max_pin="x.x.x") }}
+
+outputs:
+  - name: arrow-cpp-proc

Review comment:
   Are we going to have this packages upstream as well? Is this going to 
work like:
   
   ```bash
   conda install arrow-cpp-proc=cuda
   ```
   
   I'm not that familiar with conda meta packages, is `-proc` a common naming 
convention?
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] kszucs commented on a change in pull request #7497: ARROW-8149: [C++/Python] Enable CUDA Support in conda recipes

2020-06-22 Thread GitBox


kszucs commented on a change in pull request #7497:
URL: https://github.com/apache/arrow/pull/7497#discussion_r443444034



##
File path: dev/tasks/conda-recipes/arrow-cpp/build-pyarrow.sh
##
@@ -16,10 +16,26 @@ export PYARROW_WITH_ORC=1
 export PYARROW_WITH_PARQUET=1
 export PYARROW_WITH_PLASMA=1
 export PYARROW_WITH_S3=1
+BUILD_EXT_FLAGS=""
+
+# Enable CUDA support
+if [[ ! -z "${cuda_compiler_version+x}" && "${cuda_compiler_version}" != 
"None" ]]
+then
+export PYARROW_WITH_CUDA=1
+BUILD_EXT_FLAGS="${BUILD_EXT_FLAGS} --with-cuda"

Review comment:
   Passing env var shouldn't be sufficient?





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org