[GitHub] [arrow] nealrichardson commented on pull request #7287: ARROW-8771: [C++] Add boost/process library to build support

2020-08-27 Thread GitBox


nealrichardson commented on pull request #7287:
URL: https://github.com/apache/arrow/pull/7287#issuecomment-682000384


   > > Is there a JIRA open to upgrade to thrift 0.13.0?
   > 
   > @emkornfield AFAIK, there is no such a JIRA, and I am not sure if we have 
a plan to upgrade to thrift 0.13.0 recently.
   
   https://issues.apache.org/jira/browse/ARROW-8049 is the JIRA to upgrade 
thrift



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] nealrichardson commented on pull request #7287: ARROW-8771: [C++] Add boost/process library to build support

2020-06-17 Thread GitBox


nealrichardson commented on pull request #7287:
URL: https://github.com/apache/arrow/pull/7287#issuecomment-645432605


   That's odd. I wonder what's different about your build setup from the jobs 
we run on CI because I haven't seen that before. Do you think you could add a 
crossbow job that captures this build setup (is it just bundled boost and 
thrift, plus ARROW_FLIGHT=ON and tests on?)
   
   FWIW this boost include has been removed in Thrift 0.13: 
https://github.com/apache/thrift/commit/1f34504f43a7a409364d4114f180762bf2679e57#diff-73a92ed6f7bb65d6e8f29f74ae6c94bf
   
   So if/whenever we can [upgrade to 
0.13](https://issues.apache.org/jira/browse/ARROW-8049), this particular header 
won't ever be invoked. 



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] nealrichardson commented on pull request #7287: ARROW-8771: [C++] Add boost/process library to build support

2020-06-16 Thread GitBox


nealrichardson commented on pull request #7287:
URL: https://github.com/apache/arrow/pull/7287#issuecomment-645042129


   @liyafan82 I rebuilt the boost bundle and uploaded to bintray. Can you 
re-run whichever tests you have that failed because of this before and see if 
they work now?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] nealrichardson commented on pull request #7287: ARROW-8771: [C++] Add boost/process library to build support

2020-05-30 Thread GitBox


nealrichardson commented on pull request #7287:
URL: https://github.com/apache/arrow/pull/7287#issuecomment-636384923


   Apologies if I'm slow to iterate on this; since this is a test dependency, 
it doesn't seem urgent, and I've got a few other things I'm juggling at the 
moment.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] nealrichardson commented on pull request #7287: ARROW-8771: [C++] Add boost/process library to build support

2020-05-30 Thread GitBox


nealrichardson commented on pull request #7287:
URL: https://github.com/apache/arrow/pull/7287#issuecomment-636384787


   I just tweaked trim-boost.sh, will need to test that this does the right 
thing locally, then I can update bintray and we can try all of the builds.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] nealrichardson commented on pull request #7287: ARROW-8771: [C++] Add boost/process library to build support

2020-05-27 Thread GitBox


nealrichardson commented on pull request #7287:
URL: https://github.com/apache/arrow/pull/7287#issuecomment-634786539


   Yes, we will. Good test of the process we (hopefully) set up before.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org