[GitHub] [arrow] wesm commented on a change in pull request #7449: ARROW-9133: [C++] Add utf8_upper and utf8_lower

2020-06-25 Thread GitBox
wesm commented on a change in pull request #7449: URL: https://github.com/apache/arrow/pull/7449#discussion_r445574693 ## File path: cpp/src/arrow/compute/kernels/scalar_string_test.cc ## @@ -68,6 +76,64 @@ TYPED_TEST(TestStringKernels, AsciiLower) {

[GitHub] [arrow] wesm commented on a change in pull request #7449: ARROW-9133: [C++] Add utf8_upper and utf8_lower

2020-06-16 Thread GitBox
wesm commented on a change in pull request #7449: URL: https://github.com/apache/arrow/pull/7449#discussion_r441146931 ## File path: cpp/src/arrow/compute/kernels/scalar_string.cc ## @@ -30,6 +31,21 @@ namespace internal { namespace { +// Code units in the range [a-z] can