wesm commented on pull request #7449:
URL: https://github.com/apache/arrow/pull/7449#issuecomment-651793397
thanks @maartenbreddels!
This is an automated message from the Apache Git Service.
To respond to the message, please
wesm commented on pull request #7449:
URL: https://github.com/apache/arrow/pull/7449#issuecomment-651368104
Indeed, toolchain incompatibilities only affect C++ code
This is an automated message from the Apache Git Service.
wesm commented on pull request #7449:
URL: https://github.com/apache/arrow/pull/7449#issuecomment-650616427
Ok thanks, that's much appreciated
This is an automated message from the Apache Git Service.
To respond to the
wesm commented on pull request #7449:
URL: https://github.com/apache/arrow/pull/7449#issuecomment-650579924
@maartenbreddels let me know if I can help with anything to get this
merge-ready -- I want to make the utf8proc-depending code optional so I will
need to make a small refactor after
wesm commented on pull request #7449:
URL: https://github.com/apache/arrow/pull/7449#issuecomment-647860226
@kou utf8proc should only be used in a small number of compilation units, so
what do you think about just using `set_target_properties(... PROPERTIES
COMPILE_DEFINITIONS
wesm commented on pull request #7449:
URL: https://github.com/apache/arrow/pull/7449#issuecomment-647519089
> The downside is that users of the Arrow library are exposed to the
implementation details of how each kernel can grow the resulting array.
I'm not saying that. I'm proposing
wesm commented on pull request #7449:
URL: https://github.com/apache/arrow/pull/7449#issuecomment-647226180
> There is one loose end, the growth of the string can cause a utf8 array to
be promoted to a large_utf8.
I'd like to treat in-kernel type promotions as an anti-pattern in
wesm commented on pull request #7449:
URL: https://github.com/apache/arrow/pull/7449#issuecomment-645698551
I just merged my changes for the ASCII kernels making those work on sliced
arrays
This is an automated message from
wesm commented on pull request #7449:
URL: https://github.com/apache/arrow/pull/7449#issuecomment-645413587
I also agree with inlining the utf8proc functions until utf8proc can be
patched to have better performance. I doubt that these optimizations will
meaningfully impact the
wesm commented on pull request #7449:
URL: https://github.com/apache/arrow/pull/7449#issuecomment-645341259
Since the Unilib developer isn't interested in changing the license I think
our effort would be better invested in optimizing utf8proc
wesm commented on pull request #7449:
URL: https://github.com/apache/arrow/pull/7449#issuecomment-645023981
I went ahead and asked https://github.com/ufal/unilib/issues/2
This is an automated message from the Apache Git
11 matches
Mail list logo
