wesm commented on pull request #7556:
URL: https://github.com/apache/arrow/pull/7556#issuecomment-652058759
If there's no further feedback I will merge this in the next 24h and I
assume that any packaging issues will come up in nightlies as we push toward
the next release.
wesm commented on pull request #7556:
URL: https://github.com/apache/arrow/pull/7556#issuecomment-651847404
This looks good to me, @kszucs @kou @nealrichardson anything else you would
want to check?
This is an automated
wesm commented on pull request #7556:
URL: https://github.com/apache/arrow/pull/7556#issuecomment-651466752
@github-actions crossbow submit -g linux -g wheel -g conda
This is an automated message from the Apache Git Service.
wesm commented on pull request #7556:
URL: https://github.com/apache/arrow/pull/7556#issuecomment-651466442
Actually, that's crazy. I'm taking the same approach as ZSTD and adding a
CMake toggle between shared and static Brotli (with default being shared)
wesm commented on pull request #7556:
URL: https://github.com/apache/arrow/pull/7556#issuecomment-651186700
If you're installing Brotli in any of the packaging setups, there may be a
scenario where there is both the shared AND static library -- in that case
there would be an issue. We
wesm commented on pull request #7556:
URL: https://github.com/apache/arrow/pull/7556#issuecomment-650648681
@nealrichardson I figure this might impact the R packages also
This is an automated message from the Apache Git
wesm commented on pull request #7556:
URL: https://github.com/apache/arrow/pull/7556#issuecomment-650633720
It appears that the Brotli shared libraries are in the manylinux1 image even
though `-DBUILD_SHARED_LIBS=OFF`
wesm commented on pull request #7556:
URL: https://github.com/apache/arrow/pull/7556#issuecomment-650627218
@github-actions crossbow submit -g linux -g wheel -g conda
This is an automated message from the Apache Git Service.
wesm commented on pull request #7556:
URL: https://github.com/apache/arrow/pull/7556#issuecomment-650618145
Thanks, will look into this. I'm guessing these changes will break some of
the Python wheel builds so we may need a flag to indicate a preference of
shared vs static