[GitHub] [arrow] alamb commented on a change in pull request #8639: ARROW-10559: [Rust][DataFusion] Split up logical_plan/mod.rs into sub modules

2020-11-11 Thread GitBox
alamb commented on a change in pull request #8639: URL: https://github.com/apache/arrow/pull/8639#discussion_r521553659 ## File path: rust/datafusion/src/logical_plan/mod.rs ## @@ -21,2300 +21,21 @@ //! Logical query plans can then be optimized and executed directly, or

[GitHub] [arrow] alamb commented on a change in pull request #8639: ARROW-10559: [Rust][DataFusion] Split up logical_plan/mod.rs into sub modules

2020-11-11 Thread GitBox
alamb commented on a change in pull request #8639: URL: https://github.com/apache/arrow/pull/8639#discussion_r521541312 ## File path: rust/datafusion/src/logical_plan/mod.rs ## @@ -21,2300 +21,21 @@ //! Logical query plans can then be optimized and executed directly, or

[GitHub] [arrow] alamb commented on a change in pull request #8639: ARROW-10559: [Rust][DataFusion] Split up logical_plan/mod.rs into sub modules

2020-11-11 Thread GitBox
alamb commented on a change in pull request #8639: URL: https://github.com/apache/arrow/pull/8639#discussion_r521488424 ## File path: rust/datafusion/src/logical_plan/mod.rs ## @@ -21,2300 +21,21 @@ //! Logical query plans can then be optimized and executed directly, or

[GitHub] [arrow] alamb commented on a change in pull request #8639: ARROW-10559: [Rust][DataFusion] Split up logical_plan/mod.rs into sub modules

2020-11-11 Thread GitBox
alamb commented on a change in pull request #8639: URL: https://github.com/apache/arrow/pull/8639#discussion_r521484903 ## File path: rust/datafusion/src/logical_plan/mod.rs ## @@ -1264,31 +1050,6 @@ mod tests { Ok(()) } -#[test] -fn test_visitor() { -

[GitHub] [arrow] alamb commented on a change in pull request #8639: ARROW-10559: [Rust][DataFusion] Split up logical_plan/mod.rs into sub modules

2020-11-11 Thread GitBox
alamb commented on a change in pull request #8639: URL: https://github.com/apache/arrow/pull/8639#discussion_r521467373 ## File path: rust/datafusion/src/logical_plan/mod.rs ## @@ -21,2300 +21,21 @@ //! Logical query plans can then be optimized and executed directly, or