[GitHub] [arrow] alamb commented on pull request #8018: ARROW-9815 [Rust] [DataFusion] Fixed deadlock caused by accessing the scalar functions' registry.

2020-08-21 Thread GitBox
alamb commented on pull request #8018: URL: https://github.com/apache/arrow/pull/8018#issuecomment-678406791 That definitely sounds cleaner to me On Fri, Aug 21, 2020 at 12:07 PM Andy Grove wrote: > @alamb I think you are right. Rather than >

[GitHub] [arrow] alamb commented on pull request #8018: ARROW-9815 [Rust] [DataFusion] Fixed deadlock caused by accessing the scalar functions' registry.

2020-08-21 Thread GitBox
alamb commented on pull request #8018: URL: https://github.com/apache/arrow/pull/8018#issuecomment-678333145 > I had another thought on this. We do need the `ExecutionContextState` to be mutable, but only up until execution begins. Perhaps we should rename `ExecutionContextState` to

[GitHub] [arrow] alamb commented on pull request #8018: ARROW-9815 [Rust] [DataFusion] Fixed deadlock caused by accessing the scalar functions' registry.

2020-08-20 Thread GitBox
alamb commented on pull request #8018: URL: https://github.com/apache/arrow/pull/8018#issuecomment-677958379 > I left a second commit, which is _in alternative_ to the first one. The main difference between them is that the latter does not lock mutexes inside the recursion, which often