[GitHub] [arrow] alamb commented on pull request #8553: ARROW-10366: [Rust][DataFusion] Do not buffer intermediate results in merge or HashAggregate

2020-11-14 Thread GitBox
alamb commented on pull request #8553: URL: https://github.com/apache/arrow/pull/8553#issuecomment-727201907 FYI @rdettai , this PR has been merged This is an automated message from the Apache Git Service. To respond to the

[GitHub] [arrow] alamb commented on pull request #8553: ARROW-10366: [Rust][DataFusion] Do not buffer intermediate results in merge or HashAggregate

2020-11-14 Thread GitBox
alamb commented on pull request #8553: URL: https://github.com/apache/arrow/pull/8553#issuecomment-727192549 Rebased This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] alamb commented on pull request #8553: ARROW-10366: [Rust][DataFusion] Do not buffer intermediate results in merge or HashAggregate

2020-11-13 Thread GitBox
alamb commented on pull request #8553: URL: https://github.com/apache/arrow/pull/8553#issuecomment-726900488 I plan to merge this tomorrow unless i hear otherwise. @jorgecarleitao / @andygrove let me know if you have any concerns

[GitHub] [arrow] alamb commented on pull request #8553: ARROW-10366: [Rust][DataFusion] Do not buffer intermediate results in merge or HashAggregate

2020-11-10 Thread GitBox
alamb commented on pull request #8553: URL: https://github.com/apache/arrow/pull/8553#issuecomment-725024351 Rebased This is an automated message from the Apache Git Service. To respond to the message, please log on to

[GitHub] [arrow] alamb commented on pull request #8553: ARROW-10366: [Rust][DataFusion] Do not buffer intermediate results in merge or HashAggregate

2020-11-10 Thread GitBox
alamb commented on pull request #8553: URL: https://github.com/apache/arrow/pull/8553#issuecomment-724935395 @jorgecarleitao -- when I ran the TPCH benchmark Q1 locally on my machine, I found it kept all my cores busy and the memory profile was low. Thus the improvements offered by this

[GitHub] [arrow] alamb commented on pull request #8553: ARROW-10366: [Rust][DataFusion] Do not buffer intermediate results in merge or HashAggregate

2020-11-06 Thread GitBox
alamb commented on pull request #8553: URL: https://github.com/apache/arrow/pull/8553#issuecomment-723025807 Ah -- got it.  This is an automated message from the Apache Git Service. To respond to the message, please log on

[GitHub] [arrow] alamb commented on pull request #8553: ARROW-10366: [Rust][DataFusion] Do not buffer intermediate results in merge or HashAggregate

2020-11-05 Thread GitBox
alamb commented on pull request #8553: URL: https://github.com/apache/arrow/pull/8553#issuecomment-722690860 @jorgecarleitao and @andygrove -- I did some profiling of the tpch benchmark (SF10) locally on my laptop this afternoon. I was not able to reproduce a slowdown on this branch

[GitHub] [arrow] alamb commented on pull request #8553: ARROW-10366: [Rust][DataFusion] Do not buffer intermediate results in merge or HashAggregate

2020-11-03 Thread GitBox
alamb commented on pull request #8553: URL: https://github.com/apache/arrow/pull/8553#issuecomment-720409056 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use