[GitHub] [arrow] andygrove commented on pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

2020-09-21 Thread GitBox
andygrove commented on pull request #8172: URL: https://github.com/apache/arrow/pull/8172#issuecomment-695803865 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] andygrove commented on pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

2020-09-20 Thread GitBox
andygrove commented on pull request #8172: URL: https://github.com/apache/arrow/pull/8172#issuecomment-695804151 @jorgecarleitao This needs rebasing against master. I ran into compilation issues after merging master into this branch. ``` error[E0308]: mismatched types -->

[GitHub] [arrow] andygrove commented on pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

2020-09-12 Thread GitBox
andygrove commented on pull request #8172: URL: https://github.com/apache/arrow/pull/8172#issuecomment-691513935 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] andygrove commented on pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

2020-09-12 Thread GitBox
andygrove commented on pull request #8172: URL: https://github.com/apache/arrow/pull/8172#issuecomment-691513935 I did a quick skim through of this and LGTM so far. I will have more time available during the coming week to review more thoroughly and pull the PR locally for some testing.

[GitHub] [arrow] andygrove commented on pull request #8172: ARROW-9937: [Rust] [DataFusion] Improved aggregations

2020-09-12 Thread GitBox
andygrove commented on pull request #8172: URL: https://github.com/apache/arrow/pull/8172#issuecomment-691513935 I did a quick skim through of this and LGTM so far. I will have more time available during the coming week to review more thoroughly and pull the PR locally for some testing.