[GitHub] [arrow] andygrove commented on pull request #8222: ARROW-10043: [Rust][DataFusion] Implement COUNT(DISTINCT col)

2020-09-25 Thread GitBox
andygrove commented on pull request #8222: URL: https://github.com/apache/arrow/pull/8222#issuecomment-699113117 Hi @drusso I would like to review and merge this DF PR next. Would you mind rebasing? This is an automated

[GitHub] [arrow] andygrove commented on pull request #8222: ARROW-10043: [Rust][DataFusion] Implement COUNT(DISTINCT col)

2020-09-21 Thread GitBox
andygrove commented on pull request #8222: URL: https://github.com/apache/arrow/pull/8222#issuecomment-695804292 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [arrow] andygrove commented on pull request #8222: ARROW-10043: [Rust][DataFusion] Implement COUNT(DISTINCT col)

2020-09-21 Thread GitBox
andygrove commented on pull request #8222: URL: https://github.com/apache/arrow/pull/8222#issuecomment-696140653 Thanks @drusso this looks great. I agree with Jorge's comments about ScalarValue and I also added some minor comments.