[GitHub] [arrow] bkietz commented on a change in pull request #6879: ARROW-8377: [CI][C++][R] Build and run C++ tests on Rtools build

Thu, 23 Apr 2020 08:10:28 -0700 


bkietz commented on a change in pull request #6879:
URL: https://github.com/apache/arrow/pull/6879#discussion_r413877530



##########
File path: ci/scripts/PKGBUILD
##########
@@ -50,6 +52,12 @@ source_dir="$ARROW_HOME"
 
 cpp_build_dir=build-${CARCH}-cpp
 
+# This should be "release" for real R package
+cpp_build_type="debug"

Review comment:
       This seems like it should be derived from an environment variable near 
the top of this script:
   ```suggestion
   cpp_build_type="${CPP_BUILD_TYPE:-debug}"
   ```
   
   Then the value of `depends` can include boost iff we're building debug and 
this script can be used to build release by setting `CPP_BUILD_TYPE=release` or 
so




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to