bkietz commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r471664878
##
File path: r/src/arrow_cpp11.h
##
@@ -0,0 +1,243 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
bkietz commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r470880501
##
File path: r/src/arrow_cpp11.h
##
@@ -0,0 +1,243 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license
bkietz commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r467084647
##
File path: r/src/array_from_vector.cpp
##
@@ -406,9 +403,12 @@ std::shared_ptr
MakeFactorArray(Rcpp::IntegerVector_ factor,
case Type::INT64:
bkietz commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r460212984
##
File path: r/src/array_from_vector.cpp
##
@@ -406,9 +406,12 @@ std::shared_ptr
MakeFactorArray(Rcpp::IntegerVector_ factor,
case Type::INT64:
bkietz commented on a change in pull request #7819:
URL: https://github.com/apache/arrow/pull/7819#discussion_r459671007
##
File path: r/src/arrow_rcpp.h
##
@@ -67,120 +71,150 @@ struct ns {
} // namespace arrow
namespace Rcpp {
-namespace internal {
+using NumericVector_
