[GitHub] [arrow] carols10cents commented on pull request #8405: One definition/repetition level test

2020-10-28 Thread GitBox
carols10cents commented on pull request #8405: URL: https://github.com/apache/arrow/pull/8405#issuecomment-717950598 I think I'm going to close this one for now; I don't think it's useful until the def/rep levels are a bit further along.

[GitHub] [arrow] carols10cents commented on pull request #8405: One definition/repetition level test

2020-10-23 Thread GitBox
carols10cents commented on pull request #8405: URL: https://github.com/apache/arrow/pull/8405#issuecomment-715588688 @nevi-me So @shepmaster and I wrote some more tests, but they're failing and we're not sure if our setup is wrong or if they're expected to fail? What do you think?

[GitHub] [arrow] carols10cents commented on pull request #8405: One definition/repetition level test

2020-10-13 Thread GitBox
carols10cents commented on pull request #8405: URL: https://github.com/apache/arrow/pull/8405#issuecomment-707703699 Yup, we can keep this as a draft, no problem! I'll be rebasing and adding to this on Wednesday. This is an