edponce commented on a change in pull request #10274:
URL: https://github.com/apache/arrow/pull/10274#discussion_r632247362
##
File path: cpp/src/arrow/util/int_util_internal.h
##
@@ -63,9 +63,9 @@ OPS_WITH_OVERFLOW(DivideWithOverflow, div)
#undef OP_WITH_OVERFLOW
#undef
edponce commented on a change in pull request #10274:
URL: https://github.com/apache/arrow/pull/10274#discussion_r631529736
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -79,22 +79,20 @@ struct AbsoluteValue {
template
static constexpr
edponce commented on a change in pull request #10274:
URL: https://github.com/apache/arrow/pull/10274#discussion_r631452874
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc
##
@@ -1057,5 +1058,109 @@ TYPED_TEST(TestUnaryArithmeticFloating, Negate) {
}
edponce commented on a change in pull request #10274:
URL: https://github.com/apache/arrow/pull/10274#discussion_r631425707
##
File path: cpp/src/arrow/compute/api_scalar.h
##
@@ -160,6 +160,18 @@ struct ARROW_EXPORT ProjectOptions : public
FunctionOptions {
/// @}
+///
edponce commented on a change in pull request #10274:
URL: https://github.com/apache/arrow/pull/10274#discussion_r630707124
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic_test.cc
##
@@ -1057,5 +1058,109 @@ TYPED_TEST(TestUnaryArithmeticFloating, Negate) {
}
edponce commented on a change in pull request #10274:
URL: https://github.com/apache/arrow/pull/10274#discussion_r630698902
##
File path: cpp/src/arrow/compute/kernels/scalar_arithmetic.cc
##
@@ -66,6 +66,50 @@ constexpr Unsigned to_unsigned(T signed_) {
return
