[GitHub] [arrow] emkornfield commented on a change in pull request #6954: ARROW-8440: [C++] Refine SIMD header files

2020-04-25 Thread GitBox
emkornfield commented on a change in pull request #6954: URL: https://github.com/apache/arrow/pull/6954#discussion_r415226340 ## File path: cpp/src/arrow/util/hash_util.h ## @@ -27,39 +27,27 @@ #include "arrow/util/logging.h" #include "arrow/util/macros.h" -#include "arrow/

[GitHub] [arrow] emkornfield commented on a change in pull request #6954: ARROW-8440: [C++] Refine SIMD header files

2020-04-25 Thread GitBox
emkornfield commented on a change in pull request #6954: URL: https://github.com/apache/arrow/pull/6954#discussion_r415228325 ## File path: cpp/src/arrow/util/simd.h ## @@ -17,6 +17,24 @@ #pragma once +#ifdef _MSC_VER +// MSVC x86_64/arm64 + +#if defined(_M_AMD64) || defin

[GitHub] [arrow] emkornfield commented on a change in pull request #6954: ARROW-8440: [C++] Refine SIMD header files

2020-04-25 Thread GitBox
emkornfield commented on a change in pull request #6954: URL: https://github.com/apache/arrow/pull/6954#discussion_r415226495 ## File path: cpp/src/arrow/util/hash_util.h ## @@ -27,39 +27,27 @@ #include "arrow/util/logging.h" #include "arrow/util/macros.h" -#include "arrow/

[GitHub] [arrow] emkornfield commented on a change in pull request #6954: ARROW-8440: [C++] Refine SIMD header files

2020-04-25 Thread GitBox
emkornfield commented on a change in pull request #6954: URL: https://github.com/apache/arrow/pull/6954#discussion_r415226495 ## File path: cpp/src/arrow/util/hash_util.h ## @@ -27,39 +27,27 @@ #include "arrow/util/logging.h" #include "arrow/util/macros.h" -#include "arrow/

[GitHub] [arrow] emkornfield commented on a change in pull request #6954: ARROW-8440: [C++] Refine SIMD header files

2020-04-25 Thread GitBox
emkornfield commented on a change in pull request #6954: URL: https://github.com/apache/arrow/pull/6954#discussion_r415226340 ## File path: cpp/src/arrow/util/hash_util.h ## @@ -27,39 +27,27 @@ #include "arrow/util/logging.h" #include "arrow/util/macros.h" -#include "arrow/