[GitHub] [arrow] emkornfield commented on pull request #7915: ARROW-9671: [C++] Fix a bug in BasicDecimal128 constructor that interprets uint64_t integers with highest bit set as negative.

2020-08-07 Thread GitBox
emkornfield commented on pull request #7915: URL: https://github.com/apache/arrow/pull/7915#issuecomment-670813455 It seems travis is having issues today. I'm going to go ahead and merge this. This is an automated message

[GitHub] [arrow] emkornfield commented on pull request #7915: ARROW-9671: [C++] Fix a bug in BasicDecimal128 constructor that interprets uint64_t integers with highest bit set as negative.

2020-08-07 Thread GitBox
emkornfield commented on pull request #7915: URL: https://github.com/apache/arrow/pull/7915#issuecomment-670721077 Looks like formatting needs to be run: ``` template ::value && - (sizeof(T) <= sizeof(uint64_t)), T>::type> +