[GitHub] [arrow] fsaintjacques commented on a change in pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

fsaintjacques commented on a change in pull request #7030: URL: https://github.com/apache/arrow/pull/7030#discussion_r439413765 ## File path: cpp/src/arrow/dataset/discovery.h ## @@ -216,6 +216,16 @@ class ARROW_DS_EXPORT FileSystemDatasetFactory : public DatasetFactory {

[GitHub] [arrow] fsaintjacques commented on a change in pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

fsaintjacques commented on a change in pull request #7030: URL: https://github.com/apache/arrow/pull/7030#discussion_r430588931 ## File path: cpp/.gitignore ## @@ -24,6 +24,8 @@ cmake_install.cmake build/ *-build/ Testing/ +cmake-build-debug/ Review comment: I

[GitHub] [arrow] fsaintjacques commented on a change in pull request #7030: ARROW-7808: [Java][Dataset] Implement Datasets Java API by JNI to C++

fsaintjacques commented on a change in pull request #7030: URL: https://github.com/apache/arrow/pull/7030#discussion_r426869642 ## File path: java/dataset/src/main/java/org/apache/arrow/dataset/jni/JniLoader.java ## @@ -0,0 +1,71 @@ +/* + * Licensed to the Apache Software