fsaintjacques edited a comment on pull request #7156:
URL: https://github.com/apache/arrow/pull/7156#issuecomment-644939437


   I feel 0.5 on this PR in general, the functionality it adds is initially for 
testing and it introduces debt. I'm not keen on the change on FileSystemFactory 
since this class is used for 3 purposes, and only one of them is used by Native 
handles:
   
   - [x] Unify schema
   - [ ] Crawl a file systems to explore (requires a filesystem instance)
   - [ ] Discover partition information (requires a path)
   
   This patch retrofits FileSystemFactory for no other purpose than making 
buffer sources accessible in python while ignoring the actual discovery. In 
reality, this class deals heavily and almost exclusively with paths.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to