houqp commented on a change in pull request #7500:
URL: https://github.com/apache/arrow/pull/7500#discussion_r445998007
##########
File path: rust/parquet/src/record/api.rs
##########
@@ -893,16 +893,6 @@ mod tests {
assert_eq!(row, Field::TimestampMillis(1238544060000));
}
- #[test]
- #[should_panic(expected = "Expected non-negative milliseconds when
converting Int96")]
- fn test_row_convert_int96_invalid() {
- // INT96 value does not depend on logical type
- let descr = make_column_descr![PhysicalType::INT96, LogicalType::NONE];
-
- let value = Int96::from(vec![0, 0, 0]);
- Field::convert_int96(&descr, value);
- }
-
Review comment:
I agree that it's better to implement timestamp as signed, not only does
it address the support for time before 1970, but also make it much easier to
work with subtractions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
