[GitHub] [arrow] houqp commented on a change in pull request #7666: ARROW-8559: [Rust] Consolidate Record Batch reader traits in main arrow crate

2020-07-08 Thread GitBox
houqp commented on a change in pull request #7666: URL: https://github.com/apache/arrow/pull/7666#discussion_r451955910 ## File path: rust/arrow/src/record_batch.rs ## @@ -216,15 +216,28 @@ impl Into for RecordBatch { } } -/// Definition of record batch reader. +///

[GitHub] [arrow] houqp commented on a change in pull request #7666: ARROW-8559: [Rust] Consolidate Record Batch reader traits in main arrow crate

2020-07-07 Thread GitBox
houqp commented on a change in pull request #7666: URL: https://github.com/apache/arrow/pull/7666#discussion_r451278084 ## File path: rust/arrow/src/record_batch.rs ## @@ -216,15 +216,28 @@ impl Into for RecordBatch { } } -/// Definition of record batch reader. +///

[GitHub] [arrow] houqp commented on a change in pull request #7666: ARROW-8559: [Rust] Consolidate Record Batch reader traits in main arrow crate

2020-07-07 Thread GitBox
houqp commented on a change in pull request #7666: URL: https://github.com/apache/arrow/pull/7666#discussion_r451273911 ## File path: rust/datafusion/src/datasource/datasource.rs ## @@ -20,13 +20,13 @@ use std::sync::{Arc, Mutex}; use arrow::datatypes::Schema; +use

[GitHub] [arrow] houqp commented on a change in pull request #7666: ARROW-8559: [Rust] Consolidate Record Batch reader traits in main arrow crate

2020-07-07 Thread GitBox
houqp commented on a change in pull request #7666: URL: https://github.com/apache/arrow/pull/7666#discussion_r451273265 ## File path: rust/arrow/src/record_batch.rs ## @@ -216,15 +216,28 @@ impl Into for RecordBatch { } } -/// Definition of record batch reader. +///