[GitHub] [arrow] jeroen commented on pull request #7694: ARROW-9397: [R] Pass CC/CXX et al. to cmake when building libarrow in Linux build

2020-07-10 Thread GitBox 


jeroen commented on pull request #7694:
URL: https://github.com/apache/arrow/pull/7694#issuecomment-656888136


   Not from the configure step I think.
   
   These are all `make` variables so the native way to build embedded libs is 
to pass these down when invoking a sub-make, like so: 
https://github.com/rstudio/httpuv/blob/master/src/Makevars#L65-L70
   
   
   
   



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] jeroen commented on pull request #7694: ARROW-9397: [R] Pass CC/CXX et al. to cmake when building libarrow in Linux build

2020-07-10 Thread GitBox 


jeroen commented on pull request #7694:
URL: https://github.com/apache/arrow/pull/7694#issuecomment-656883822


   You have a bug here because your version of `R_CMD_config` takes R from the 
PATH but that may not be the correct R. Some machines have many versions of R.
   
   It may be safer to use e.g. `tools::Rcmd(c('config', 'CXX'), stdout=T)`



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org