[GitHub] [arrow] jianxind commented on pull request #7531: ARROW-9216: [C++] Use BitBlockCounter for plain spaced encoding/decoding

2020-06-25 Thread GitBox
jianxind commented on pull request #7531: URL: https://github.com/apache/arrow/pull/7531#issuecomment-649874368 > +1, merging this. If removing the BitmapReader helps perf it can be done in a follow up PR Thanks. BitmapReader does help for the 1% and 50% null probability case, the i

[GitHub] [arrow] jianxind commented on pull request #7531: ARROW-9216: [C++] Use BitBlockCounter for plain spaced encoding/decoding

2020-06-24 Thread GitBox
jianxind commented on pull request #7531: URL: https://github.com/apache/arrow/pull/7531#issuecomment-649198815 Here is the results: https://ci.ursalabs.org/#/builders/73/builds/90/steps/3/logs/result, not know why it not paste here, I see all 0.01% get positive results. 106

[GitHub] [arrow] jianxind commented on pull request #7531: ARROW-9216: [C++] Use BitBlockCounter for plain spaced encoding/decoding

2020-06-24 Thread GitBox
jianxind commented on pull request #7531: URL: https://github.com/apache/arrow/pull/7531#issuecomment-649197066 @ursabot benchmark --suite-filter=parquet-encoding-benchmark --benchmark-filter=BM_Plain This is an automated me

[GitHub] [arrow] jianxind commented on pull request #7531: ARROW-9216: [C++] Use BitBlockCounter for plain spaced encoding/decoding

2020-06-24 Thread GitBox
jianxind commented on pull request #7531: URL: https://github.com/apache/arrow/pull/7531#issuecomment-649147883 @ursabot benchmark --suite-filter=parquet-encoding-benchmark This is an automated message from the Apache Git Ser

[GitHub] [arrow] jianxind commented on pull request #7531: ARROW-9216: [C++] Use BitBlockCounter for plain spaced encoding/decoding

2020-06-24 Thread GitBox
jianxind commented on pull request #7531: URL: https://github.com/apache/arrow/pull/7531#issuecomment-648656865 This PR https://github.com/apache/arrow/pull/7532 add the 0.01% benchmark case, I can trigger a benchmark action if 7532 get merged. Below is the results for 0.01% on my de