[GitHub] [arrow] jorgecarleitao commented on pull request #9215: ARROW-11270: [Rust] Array slice accessors

2021-01-26 Thread GitBox
jorgecarleitao commented on pull request #9215: URL: https://github.com/apache/arrow/pull/9215#issuecomment-767712832 @tyrelr , could you rebase against master? @kszucs , something may have happened to the force push: the commits seem funny.

[GitHub] [arrow] jorgecarleitao commented on pull request #9215: ARROW-11270: [Rust] Array slice accessors

2021-01-23 Thread GitBox
jorgecarleitao commented on pull request #9215: URL: https://github.com/apache/arrow/pull/9215#issuecomment-766158069 @tyrelr , I believe that you may have to run the benches against the latest master vs your branch rebased, for consistency: 499b6d0c is before a significant change to the

[GitHub] [arrow] jorgecarleitao commented on pull request #9215: ARROW-11270: [Rust] Array slice accessors

2021-01-20 Thread GitBox
jorgecarleitao commented on pull request #9215: URL: https://github.com/apache/arrow/pull/9215#issuecomment-763555725 Ready to merge. Note that it has some backward incompatible changes, so PRs on top need to be merged carefully.