[GitHub] [arrow] jorgecarleitao edited a comment on pull request #9301: ARROW-11357: [Rust]: Fix out-of-bounds reads in `take` and other undefined behavior

jorgecarleitao edited a comment on pull request #9301: URL: https://github.com/apache/arrow/pull/9301#issuecomment-766088562 On another side note, this just re-inforces the need to mark `PrimitiveArray::value` as `unsafe`.

[GitHub] [arrow] jorgecarleitao edited a comment on pull request #9301: ARROW-11357: [Rust]: Fix out-of-bounds reads in `take` and other undefined behavior

jorgecarleitao edited a comment on pull request #9301: URL: https://github.com/apache/arrow/pull/9301#issuecomment-766163142 Now I get your point. On the PR description, I mention two _independent_ sources of unsoundness: * we are using indices from null slots * we are not

[GitHub] [arrow] jorgecarleitao edited a comment on pull request #9301: ARROW-11357: [Rust]: Fix out-of-bounds reads in `take` and other undefined behavior

jorgecarleitao edited a comment on pull request #9301: URL: https://github.com/apache/arrow/pull/9301#issuecomment-766163142 Now I get your point. On the PR description, I mention two _independent_ sources of unsoundness: * we are using indices from null slots * we are not

[GitHub] [arrow] jorgecarleitao edited a comment on pull request #9301: ARROW-11357: [Rust]: Fix out-of-bounds reads in `take` and other undefined behavior

jorgecarleitao edited a comment on pull request #9301: URL: https://github.com/apache/arrow/pull/9301#issuecomment-766163142 Now I get your point. On the PR description, I mention to _independent_ sources of unsoundness: * we are using indices from null slots * we are not

[GitHub] [arrow] jorgecarleitao edited a comment on pull request #9301: ARROW-11357: [Rust]: Fix out-of-bounds reads in `take` and other undefined behavior

jorgecarleitao edited a comment on pull request #9301: URL: https://github.com/apache/arrow/pull/9301#issuecomment-766163142 Now I get your point. On the PR description, I mention to _independent_ sources of unsoundness: * we are using indices from null slots * we are not

[GitHub] [arrow] jorgecarleitao edited a comment on pull request #9301: ARROW-11357: [Rust]: Fix out-of-bounds reads in `take` and other undefined behavior

jorgecarleitao edited a comment on pull request #9301: URL: https://github.com/apache/arrow/pull/9301#issuecomment-766163142 Now I get your point. On the PR description, I mention to _independent_ sources of unsoundness: * we are using indices from null slots * we are not

[GitHub] [arrow] jorgecarleitao edited a comment on pull request #9301: ARROW-11357: [Rust]: Fix out-of-bounds reads in `take` and other undefined behavior

jorgecarleitao edited a comment on pull request #9301: URL: https://github.com/apache/arrow/pull/9301#issuecomment-766088562 On a side note, this explains why I was unable to beat `take` when I tried to replace it by `MutableArray`. On another side note, this just re-inforces the