[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

2020-09-23 Thread GitBox
jorisvandenbossche commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r493532800 ## File path: python/pyarrow/array.pxi ## @@ -21,28 +21,28 @@ import warnings cdef _sequence_to_array(object sequence, object mask, object siz

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

2020-09-22 Thread GitBox
jorisvandenbossche commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r492666980 ## File path: python/pyarrow/array.pxi ## @@ -21,28 +21,28 @@ import warnings cdef _sequence_to_array(object sequence, object mask, object siz

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

2020-09-22 Thread GitBox
jorisvandenbossche commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r492667996 ## File path: python/pyarrow/tests/test_convert_builtin.py ## @@ -1513,6 +1519,108 @@ def test_struct_from_tuples(): pa.array([tup],

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

2020-09-22 Thread GitBox
jorisvandenbossche commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r492666980 ## File path: python/pyarrow/array.pxi ## @@ -21,28 +21,28 @@ import warnings cdef _sequence_to_array(object sequence, object mask, object siz

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

2020-09-21 Thread GitBox
jorisvandenbossche commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r488714572 ## File path: python/pyarrow/tests/test_types.py ## @@ -280,6 +284,13 @@ def test_tzinfo_to_string_errors(): pa.lib.tzinfo_to_string

[GitHub] [arrow] jorisvandenbossche commented on a change in pull request #8088: ARROW-9992: [C++][Python] Refactor python to arrow conversions based on a reusable conversion API

2020-09-21 Thread GitBox
jorisvandenbossche commented on a change in pull request #8088: URL: https://github.com/apache/arrow/pull/8088#discussion_r488714572 ## File path: python/pyarrow/tests/test_types.py ## @@ -280,6 +284,13 @@ def test_tzinfo_to_string_errors(): pa.lib.tzinfo_to_string