[GitHub] [arrow] kou commented on a change in pull request #7589: ARROW-9276: [Release] Enforce CUDA device for updating the api documentations

2020-07-07 Thread GitBox


kou commented on a change in pull request #7589:
URL: https://github.com/apache/arrow/pull/7589#discussion_r451154810



##
File path: dev/release/post-09-docs.sh
##
@@ -42,20 +47,20 @@ popd
 pushd "${ARROW_DIR}"
 git checkout "${release_tag}"

Review comment:
   Could you try the following change? I confirmed that this can build C++ 
and GLib with CUDA but Java build is failed... (I think that the Java build 
error is unrelated to this.)
   
   ```diff
   diff --git a/ci/docker/linux-apt-docs.dockerfile 
b/ci/docker/linux-apt-docs.dockerfile
   index 55ce2b87c..d0d98d5cd 100644
   --- a/ci/docker/linux-apt-docs.dockerfile
   +++ b/ci/docker/linux-apt-docs.dockerfile
   @@ -43,6 +43,7 @@ RUN apt-get update -y && \
libtool \
libxml2-dev \
ninja-build \
   +nvidia-cuda-toolkit \
openjdk-${jdk}-jdk-headless \
pandoc \
r-base=${r}* \
   diff --git a/dev/release/post-09-docs.sh b/dev/release/post-09-docs.sh
   index e81147a0e..cf983d066 100755
   --- a/dev/release/post-09-docs.sh
   +++ b/dev/release/post-09-docs.sh
   @@ -50,7 +50,7 @@ git checkout "${release_tag}"
archery docker run \
  -v "${ARROW_SITE_DIR}/docs:/build/docs" \
  -e ARROW_DOCS_VERSION="${version}" \
   -  ubuntu-cuda-docs
   +  ubuntu-docs

: ${PUSH:=1}

   diff --git a/docker-compose.yml b/docker-compose.yml
   index f124f28fb..37e0b054d 100644
   --- a/docker-compose.yml
   +++ b/docker-compose.yml
   @@ -65,7 +65,6 @@ x-ccache: 
x-with-gpus:
  - ubuntu-cuda-cpp
  - ubuntu-cuda-python
   -  - ubuntu-cuda-docs

x-hierarchy:
  # This section is used by the archery tool to enable building nested 
images,
   @@ -116,8 +115,7 @@ x-hierarchy:
  - ubuntu-docs
- ubuntu-r
  - ubuntu-cuda-cpp:
   -- ubuntu-cuda-python:
   -  - ubuntu-cuda-docs
   +- ubuntu-cuda-python
  - ubuntu-csharp
  - ubuntu-cpp-sanitizer
  - ubuntu-r-sanitizer
   @@ -1125,6 +1123,7 @@ services:
base: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-python-3
environment:
  <<: *ccache
   +  ARROW_CUDA: "ON"
  ARROW_GLIB_GTK_DOC: "true"
volumes: *ubuntu-volumes
command:  >
   @@ -1137,30 +1136,6 @@ services:
/arrow/ci/scripts/r_build.sh /arrow true &&
/arrow/ci/scripts/docs_build.sh /arrow /build"

   -  ubuntu-cuda-docs:
   -# Usage:
   -#   docker-compose build ubuntu-cuda-cpp
   -#   docker-compose build ubuntu-cuda-python
   -#   docker-compose build ubuntu-cuda-docs
   -#   docker-compose run --rm ubuntu-cuda-docs
   -# Notes about --runtime and --gpus and docker-compose incompatibility
   -image: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-cuda-${CUDA}-python-3-docs
   -build:
   -  context: .
   -  dockerfile: ci/docker/linux-apt-docs.dockerfile
   -  cache_from:
   -- ${REPO}:${ARCH}-ubuntu-${UBUNTU}-docs
   -  args:
   -jdk: ${JDK}
   -node: ${NODE}
   -base: ${REPO}:${ARCH}-ubuntu-${UBUNTU}-cuda-${CUDA}-python-3
   -environment:
   -  <<: *ccache
   -  ARROW_CUDA: "ON"
   -  ARROW_GLIB_GTK_DOC: "true"
   -volumes: *ubuntu-volumes
   -command: *docs-command
   -
  # Tools 
#

  ubuntu-lint:
   ```
   





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [arrow] kou commented on a change in pull request #7589: ARROW-9276: [Release] Enforce CUDA device for updating the api documentations

2020-07-01 Thread GitBox


kou commented on a change in pull request #7589:
URL: https://github.com/apache/arrow/pull/7589#discussion_r448188490



##
File path: dev/release/post-09-docs.sh
##
@@ -42,20 +47,20 @@ popd
 pushd "${ARROW_DIR}"
 git checkout "${release_tag}"

Review comment:
   FYI: We don't need a CUDA machine if we don't need to run CUDA enabled 
programs. We're building CUDA enabled deb packages on a no CUDA machine.





This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org