[GitHub] [arrow] kou commented on pull request #6729: ARROW-8229: [Java] Move ArrowBuf into the Arrow package

2020-06-16 Thread GitBox 


kou commented on pull request #6729:
URL: https://github.com/apache/arrow/pull/6729#issuecomment-645016478


   Thanks!



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kou commented on pull request #6729: ARROW-8229: [Java] Move ArrowBuf into the Arrow package

2020-06-15 Thread GitBox 


kou commented on pull request #6729:
URL: https://github.com/apache/arrow/pull/6729#issuecomment-644387504


   @liyafan82 OK. Could you open an JIRA issue for Spark to notify this to 
Spark developers? https://issues.apache.org/jira/browse/SPARK
   FYI: https://spark.apache.org/contributing.html
   
   @kiszk Could you support updating Spark for this change?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] kou commented on pull request #6729: ARROW-8229: [Java] Move ArrowBuf into the Arrow package

2020-06-14 Thread GitBox 


kou commented on pull request #6729:
URL: https://github.com/apache/arrow/pull/6729#issuecomment-643823860


   This breaks Spark: 
https://github.com/ursa-labs/crossbow/runs/769424833#step:6:13025
   
   ```text
[ERROR] [Error] 
/spark/sql/catalyst/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java:20:
 cannot find symbol
 symbol:   class ArrowBuf
 location: package io.netty.buffer
   [ERROR] [Error] 
/spark/sql/catalyst/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java:461:
 cannot find symbol
 symbol:   class ArrowBuf
 location: class 
org.apache.spark.sql.vectorized.ArrowColumnVector.ArrayAccessor
   ```
   
   Because Spark uses `io.netty.buffer.ArrowBuf`: 
https://github.com/apache/spark/blob/master/sql/catalyst/src/main/java/org/apache/spark/sql/vectorized/ArrowColumnVector.java#L20
   
   Should we restore the `io.netty.buffer.ArrowBuf` name or update Spark?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org