[GitHub] [arrow] lidavidm commented on pull request #7224: ARROW-8858: [FlightRPC] ensure binary/multi-valued headers are properly exposed

2020-06-10 Thread GitBox
lidavidm commented on pull request #7224: URL: https://github.com/apache/arrow/pull/7224#issuecomment-641961534 > LGTM. Do you need someone to review the Java changes? > Also, can you rebase to try and fix the AppVeyor failure? Thanks! Rebased. Ryan already looked at the Java

[GitHub] [arrow] lidavidm commented on pull request #7224: ARROW-8858: [FlightRPC] ensure binary/multi-valued headers are properly exposed

2020-06-09 Thread GitBox
lidavidm commented on pull request #7224: URL: https://github.com/apache/arrow/pull/7224#issuecomment-641603882 Rebased to fix conflicts. This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] [arrow] lidavidm commented on pull request #7224: ARROW-8858: [FlightRPC] ensure binary/multi-valued headers are properly exposed

2020-05-20 Thread GitBox
lidavidm commented on pull request #7224: URL: https://github.com/apache/arrow/pull/7224#issuecomment-631428845 I could take a different approach and only expose bytes, but internally check if there is/isn't the "-bin" suffix and use the appropriate marshaller - does that sound better? It

[GitHub] [arrow] lidavidm commented on pull request #7224: ARROW-8858: [FlightRPC] ensure binary/multi-valued headers are properly exposed

2020-05-19 Thread GitBox
lidavidm commented on pull request #7224: URL: https://github.com/apache/arrow/pull/7224#issuecomment-630877429 CC @rymurr, if you have time to take a look that would be much appreciated (since you've also worked on the metadata handling). grpc-java is very strict about using the proper