[GitHub] [arrow] liyafan82 commented on a change in pull request #6912: ARROW-8020: [Java] Implement vector validate functionality

2020-04-30 Thread GitBox
liyafan82 commented on a change in pull request #6912: URL: https://github.com/apache/arrow/pull/6912#discussion_r417948240 ## File path: java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorVisitor.java ## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache S

[GitHub] [arrow] liyafan82 commented on a change in pull request #6912: ARROW-8020: [Java] Implement vector validate functionality

2020-04-30 Thread GitBox
liyafan82 commented on a change in pull request #6912: URL: https://github.com/apache/arrow/pull/6912#discussion_r417948666 ## File path: java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorVisitor.java ## @@ -0,0 +1,222 @@ +/* + * Licensed to the Apache S

[GitHub] [arrow] liyafan82 commented on a change in pull request #6912: ARROW-8020: [Java] Implement vector validate functionality

2020-04-30 Thread GitBox
liyafan82 commented on a change in pull request #6912: URL: https://github.com/apache/arrow/pull/6912#discussion_r417948240 ## File path: java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorVisitor.java ## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache S

[GitHub] [arrow] liyafan82 commented on a change in pull request #6912: ARROW-8020: [Java] Implement vector validate functionality

2020-04-30 Thread GitBox
liyafan82 commented on a change in pull request #6912: URL: https://github.com/apache/arrow/pull/6912#discussion_r417944148 ## File path: java/vector/src/main/codegen/templates/UnionVector.java ## @@ -30,6 +30,7 @@ import org.apache.arrow.vector.types.pojo.FieldType; import o

[GitHub] [arrow] liyafan82 commented on a change in pull request #6912: ARROW-8020: [Java] Implement vector validate functionality

2020-04-30 Thread GitBox
liyafan82 commented on a change in pull request #6912: URL: https://github.com/apache/arrow/pull/6912#discussion_r417944313 ## File path: java/vector/src/main/java/org/apache/arrow/vector/complex/NonNullableStructVector.java ## @@ -46,6 +46,7 @@ import io.netty.buffer.Arrow

[GitHub] [arrow] liyafan82 commented on a change in pull request #6912: ARROW-8020: [Java] Implement vector validate functionality

2020-04-28 Thread GitBox
liyafan82 commented on a change in pull request #6912: URL: https://github.com/apache/arrow/pull/6912#discussion_r416559338 ## File path: java/vector/src/main/java/org/apache/arrow/vector/util/ValueVectorUtility.java ## @@ -82,4 +89,43 @@ public static String getToString(Value

[GitHub] [arrow] liyafan82 commented on a change in pull request #6912: ARROW-8020: [Java] Implement vector validate functionality

2020-04-28 Thread GitBox
liyafan82 commented on a change in pull request #6912: URL: https://github.com/apache/arrow/pull/6912#discussion_r416558074 ## File path: java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorVisitor.java ## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache S

[GitHub] [arrow] liyafan82 commented on a change in pull request #6912: ARROW-8020: [Java] Implement vector validate functionality

2020-04-28 Thread GitBox
liyafan82 commented on a change in pull request #6912: URL: https://github.com/apache/arrow/pull/6912#discussion_r416557702 ## File path: java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorVisitor.java ## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache S

[GitHub] [arrow] liyafan82 commented on a change in pull request #6912: ARROW-8020: [Java] Implement vector validate functionality

2020-04-28 Thread GitBox
liyafan82 commented on a change in pull request #6912: URL: https://github.com/apache/arrow/pull/6912#discussion_r416557129 ## File path: java/vector/src/main/java/org/apache/arrow/vector/validate/ValidateVectorVisitor.java ## @@ -0,0 +1,177 @@ +/* + * Licensed to the Apache S

[GitHub] [arrow] liyafan82 commented on a change in pull request #6912: ARROW-8020: [Java] Implement vector validate functionality

2020-04-28 Thread GitBox
liyafan82 commented on a change in pull request #6912: URL: https://github.com/apache/arrow/pull/6912#discussion_r416553407 ## File path: java/vector/src/main/java/org/apache/arrow/vector/util/ValueVectorUtility.java ## @@ -82,4 +89,43 @@ public static String getToString(Value

[GitHub] [arrow] liyafan82 commented on a change in pull request #6912: ARROW-8020: [Java] Implement vector validate functionality

2020-04-28 Thread GitBox
liyafan82 commented on a change in pull request #6912: URL: https://github.com/apache/arrow/pull/6912#discussion_r416551750 ## File path: java/vector/src/main/java/org/apache/arrow/vector/ExtensionTypeVector.java ## @@ -264,4 +264,5 @@ public BufferAllocator getAllocator() {

[GitHub] [arrow] liyafan82 commented on a change in pull request #6912: ARROW-8020: [Java] Implement vector validate functionality

2020-04-28 Thread GitBox
liyafan82 commented on a change in pull request #6912: URL: https://github.com/apache/arrow/pull/6912#discussion_r416551607 ## File path: java/vector/src/main/codegen/templates/DenseUnionVector.java ## @@ -34,6 +34,8 @@ import org.apache.arrow.vector.types.pojo.FieldType; imp

[GitHub] [arrow] liyafan82 commented on a change in pull request #6912: ARROW-8020: [Java] Implement vector validate functionality

2020-04-20 Thread GitBox
liyafan82 commented on a change in pull request #6912: URL: https://github.com/apache/arrow/pull/6912#discussion_r411355185 ## File path: java/vector/src/main/java/org/apache/arrow/vector/complex/NonNullableStructVector.java ## @@ -320,6 +322,20 @@ public int hashCode(int inde

[GitHub] [arrow] liyafan82 commented on a change in pull request #6912: ARROW-8020: [Java] Implement vector validate functionality

2020-04-20 Thread GitBox
liyafan82 commented on a change in pull request #6912: URL: https://github.com/apache/arrow/pull/6912#discussion_r411352198 ## File path: java/vector/src/main/java/org/apache/arrow/vector/ValueVector.java ## @@ -283,4 +283,10 @@ * @return the name of the vector. */ S