[GitHub] [arrow] liyafan82 commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

2020-09-25 Thread GitBox
liyafan82 commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494118200 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BaseFixedWidthVector.java ## @@ -48,7 +48,8 @@ implements FixedWidthVector,

[GitHub] [arrow] liyafan82 commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

2020-09-24 Thread GitBox
liyafan82 commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494721296 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BitVector.java ## @@ -119,13 +119,16 @@ public void setInitialCapacity(int valueCount) {

[GitHub] [arrow] liyafan82 commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

2020-09-24 Thread GitBox
liyafan82 commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494713164 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BitVector.java ## @@ -119,13 +119,16 @@ public void setInitialCapacity(int valueCount) {

[GitHub] [arrow] liyafan82 commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

2020-09-24 Thread GitBox
liyafan82 commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494713260 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BitVector.java ## @@ -119,13 +119,16 @@ public void setInitialCapacity(int valueCount) {

[GitHub] [arrow] liyafan82 commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

2020-09-24 Thread GitBox
liyafan82 commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494707070 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BitVector.java ## @@ -126,7 +126,12 @@ public void setInitialCapacity(int valueCount) {

[GitHub] [arrow] liyafan82 commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

2020-09-24 Thread GitBox
liyafan82 commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494705115 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BitVector.java ## @@ -126,7 +126,12 @@ public void setInitialCapacity(int valueCount) {

[GitHub] [arrow] liyafan82 commented on a change in pull request #8214: ARROW-9965: [Java] Improve performance of BaseFixedWidthVector.setSafe by optimizing capacity calculations

2020-09-24 Thread GitBox
liyafan82 commented on a change in pull request #8214: URL: https://github.com/apache/arrow/pull/8214#discussion_r494118200 ## File path: java/vector/src/main/java/org/apache/arrow/vector/BaseFixedWidthVector.java ## @@ -48,7 +48,8 @@ implements FixedWidthVector,