liyafan82 commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-635050822
@BryanCutler @siddharthteotia @emkornfield I am aware that this PR is large,
and consumes lots of effort. So thanks a lot for your effort and good comments!
---
liyafan82 commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-634447500
> Great job getting integration tests passing @liyafan82 ! I took a quick
look and LGTM, will do a more thorough pass hopefully tomorrow before merging.
@BryanCutler Pleas
liyafan82 commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-633883684
@BryanCutler The integration tests pass now. Please take another look when
you have time. Thank you.
This is an
liyafan82 commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-632982040
> Thanks @liyafan82 , looks like they didn't pass on this first try. Any
idea what was causing the error?
>
> ```
> Error accessing files
> Current token (VALUE_STRI
liyafan82 commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-632603791
@BryanCutler @emkornfield Sorry for my late response.
I have removed the skip. Let's see if the integration tests can pass this
time.
-
liyafan82 commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-624426890
@nealrichardson and @BryanCutler Thanks for your good suggestion.
I have removed the skip in `datagen.py`, but the tests failed. The reason is
that we do not support `LargeLis
liyafan82 commented on pull request #6425:
URL: https://github.com/apache/arrow/pull/6425#issuecomment-621827317
I have added integration test for the large varchar vector.
This is an automated message from the Apache Git Se
