liyafan82 commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-699729876
Merging. The check failure is irrelavent. Thanks for the PR @josiahyan
This is an automated message from the
liyafan82 commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-698713708
@jacques-n Do you have any more comments?
This is an automated message from the Apache Git Service.
To respond
liyafan82 commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-698713708
@jacques-n Do you have any more comments?
This is an automated message from the Apache Git Service.
To respond
liyafan82 commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-697114813
Thank you all for the fruitful discussion.
One small reminder for @josiahyan : to cache the buffer capacity, it is
sufficient to use an `int` instead of a `long`
liyafan82 commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-695873809
@josiahyan Thank you for the additional details.
I think one of your concern is that, the underlying buffers can be changed
unintentionally, which lefts the vector in an
liyafan82 commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-695873809
@josiahyan Thank you for the additional details.
I think one of your concern is that, the underlying buffers can be changed
unintentionally, which lefts the vector in an
liyafan82 commented on pull request #8214:
URL: https://github.com/apache/arrow/pull/8214#issuecomment-694850013
> +1, integration test failure is unrelated.
>
> @liyafan82 since you're also working in this space, what do you think of
the optimization here? I think it's an easy win