[GitHub] [arrow] nealrichardson commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows
nealrichardson commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-645041382 Uploaded and re-triggered the failing build for confirmation that it's working now. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows
nealrichardson commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-645041249 @github-actions crossbow submit test-r-rstudio-r-base-3.6-bionic This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows
nealrichardson commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-645021672 > OK. Could you update the bundle and then re-run the build? Yes, will do > And could you add me ( https://bintray.com/kou ) to https://bintray.com/ursalabs 's members? > I may want to upload something to there in the future. Done. > Or should we create https://bintray.com/apache/arrow/boost and migrate https://bintray.com/ursalabs/arrow-boost/arrow-boost to https://bintray.com/apache/arrow/boost ? We could I guess, though I don't think I have sufficient permissions on the org to do that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows
nealrichardson commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-644849969 Yes, I expected that it should fail, thus confirming the issue. I can update the bundle and then re-run the build, and when that passes, we've fixed the issue :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows
nealrichardson commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-644413986 I suspect it wouldn't increase build time much, at least not enough to block things. Where would you prefer to run the test? Do we run windows nightlies on crossbow? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows
nealrichardson commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-644410813 Maybe adding `BOOST_SOURCE: BUNDLED` around [here](https://github.com/apache/arrow/blob/master/.github/workflows/cpp.yml#L179) would be sufficient? The job is already building Thrift. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #7430: ARROW-9126: [C++] Fix building trimmed Boost bundle on Windows
nealrichardson commented on pull request #7430: URL: https://github.com/apache/arrow/pull/7430#issuecomment-644207536 Thanks @ctring! Since the builds have been green, we must not have any CI jobs that test building with bundled boost and thrift on MSVC. Should we add one (nightly perhaps)? @kou thoughts? To be clear, if we add such a job, it should fail until the trimmed boost is rebuild, assuming that that typeof/incr_registration_group.hpp is required as reported here. How exactly did you confirm that these changes work as expected, @ctring? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
