[GitHub] [arrow] nealrichardson commented on pull request #7524: ARROW-8899 [R] Add R metadata like pandas metadata for round-trip fidelity

2020-06-29 Thread GitBox 


nealrichardson commented on pull request #7524:
URL: https://github.com/apache/arrow/pull/7524#issuecomment-651484901


   Ok, this isn't necessarily pretty but I think it's done, or done enough for 
here. I'll add some more tests, probably some docs for the format, and poke 
around a bit more while doing the tickets for `haven::labelled` and `POSIXlt` 
types. @romainfrancois if you can glance at the changes I made and confirm that 
I haven't butchered things too badly, that would be great, thanks.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] nealrichardson commented on pull request #7524: ARROW-8899 [R] Add R metadata like pandas metadata for round-trip fidelity

2020-06-29 Thread GitBox 


nealrichardson commented on pull request #7524:
URL: https://github.com/apache/arrow/pull/7524#issuecomment-651263042


   I'm taking this over. Outstanding TODOs:
   
   - [x] Add tests
   - [x] Support record batches
   - [ ] Support nested types (requires adapting the data structure and adding 
recursion)
   - [ ] Test the print method
   - [ ] Test/handle bad data in metadata$r; allow users to edit it manually?



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [arrow] nealrichardson commented on pull request #7524: ARROW-8899 [R] Add R metadata like pandas metadata for round-trip fidelity

2020-06-26 Thread GitBox 


nealrichardson commented on pull request #7524:
URL: https://github.com/apache/arrow/pull/7524#issuecomment-650249655


   @romainfrancois regarding tests, I think a fixture something like 
   
   ```r
   df <- tibble::tibble(
 a = structure("one", class = "special_string"),
 b = 2,
 c = tibble::tibble(
   c1 = structure("inner", extra_attr = "something"),
   c2 = 4
 )
   )
   ```
   
   could be sufficient. 
   
   ```r
   expect_identical(as.data.frame(Table$create(df)), df)
   expect_identical(as.data.frame(record_batch(df)), df)
   ```
   
   and then also confirm that it's identical round-tripping to Feather and 
Parquet.



This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org