[GitHub] [arrow] nevi-me commented on a change in pull request #7917: ARROW-8243: [Rust] [Parquet] Serialize Arrow schema metadata

2020-08-18 Thread GitBox
nevi-me commented on a change in pull request #7917: URL: https://github.com/apache/arrow/pull/7917#discussion_r472106770 ## File path: rust/parquet/src/arrow/schema.rs ## @@ -83,12 +90,77 @@ where .map(|fields| Schema::new_with_metadata(fields, metadata)) } +///

[GitHub] [arrow] nevi-me commented on a change in pull request #7917: ARROW-8243: [Rust] [Parquet] Serialize Arrow schema metadata

2020-08-18 Thread GitBox
nevi-me commented on a change in pull request #7917: URL: https://github.com/apache/arrow/pull/7917#discussion_r472105674 ## File path: rust/parquet/src/arrow/schema.rs ## @@ -83,12 +90,77 @@ where .map(|fields| Schema::new_with_metadata(fields, metadata)) } +///

[GitHub] [arrow] nevi-me commented on a change in pull request #7917: ARROW-8243: [Rust] [Parquet] Serialize Arrow schema metadata

2020-08-18 Thread GitBox
nevi-me commented on a change in pull request #7917: URL: https://github.com/apache/arrow/pull/7917#discussion_r471964910 ## File path: rust/parquet/src/arrow/schema.rs ## @@ -83,12 +90,77 @@ where .map(|fields| Schema::new_with_metadata(fields, metadata)) } +///

[GitHub] [arrow] nevi-me commented on a change in pull request #7917: ARROW-8243: [Rust] [Parquet] Serialize Arrow schema metadata

2020-08-14 Thread GitBox
nevi-me commented on a change in pull request #7917: URL: https://github.com/apache/arrow/pull/7917#discussion_r470650350 ## File path: rust/parquet/src/arrow/schema.rs ## @@ -34,16 +34,26 @@ use crate::schema::types::{ColumnDescriptor, SchemaDescriptor, Type, TypePtr}; use

[GitHub] [arrow] nevi-me commented on a change in pull request #7917: ARROW-8243: [Rust] [Parquet] Serialize Arrow schema metadata

2020-08-14 Thread GitBox
nevi-me commented on a change in pull request #7917: URL: https://github.com/apache/arrow/pull/7917#discussion_r470102183 ## File path: rust/parquet/src/arrow/arrow_writer.rs ## @@ -674,8 +712,16 @@ mod tests { ) .unwrap(); +let props =

[GitHub] [arrow] nevi-me commented on a change in pull request #7917: ARROW-8243: [Rust] [Parquet] Serialize Arrow schema metadata

2020-08-14 Thread GitBox
nevi-me commented on a change in pull request #7917: URL: https://github.com/apache/arrow/pull/7917#discussion_r470636985 ## File path: rust/parquet/Cargo.toml ## @@ -52,4 +53,4 @@ zstd = "0.5" arrow = { path = "../arrow", version = "2.0.0-SNAPSHOT" } [features] -default =

[GitHub] [arrow] nevi-me commented on a change in pull request #7917: ARROW-8243: [Rust] [Parquet] Serialize Arrow schema metadata

2020-08-13 Thread GitBox
nevi-me commented on a change in pull request #7917: URL: https://github.com/apache/arrow/pull/7917#discussion_r470102183 ## File path: rust/parquet/src/arrow/arrow_writer.rs ## @@ -674,8 +712,16 @@ mod tests { ) .unwrap(); +let props =

[GitHub] [arrow] nevi-me commented on a change in pull request #7917: ARROW-8243: [Rust] [Parquet] Serialize Arrow schema metadata

2020-08-13 Thread GitBox
nevi-me commented on a change in pull request #7917: URL: https://github.com/apache/arrow/pull/7917#discussion_r470097911 ## File path: rust/parquet/src/file/properties.rs ## @@ -99,7 +99,7 @@ pub struct WriterProperties { max_row_group_size: usize, writer_version:

[GitHub] [arrow] nevi-me commented on a change in pull request #7917: ARROW-8243: [Rust] [Parquet] Serialize Arrow schema metadata

2020-08-08 Thread GitBox
nevi-me commented on a change in pull request #7917: URL: https://github.com/apache/arrow/pull/7917#discussion_r467500876 ## File path: rust/parquet/Cargo.toml ## @@ -52,4 +53,4 @@ zstd = "0.5" arrow = { path = "../arrow", version = "2.0.0-SNAPSHOT" } [features] -default =

[GitHub] [arrow] nevi-me commented on a change in pull request #7917: ARROW-8243: [Rust] [Parquet] Serialize Arrow schema metadata

2020-08-08 Thread GitBox
nevi-me commented on a change in pull request #7917: URL: https://github.com/apache/arrow/pull/7917#discussion_r467497445 ## File path: rust/parquet/Cargo.toml ## @@ -52,4 +53,4 @@ zstd = "0.5" arrow = { path = "../arrow", version = "2.0.0-SNAPSHOT" } [features] -default =

[GitHub] [arrow] nevi-me commented on a change in pull request #7917: ARROW-8243: [Rust] [Parquet] Serialize Arrow schema metadata

2020-08-08 Thread GitBox
nevi-me commented on a change in pull request #7917: URL: https://github.com/apache/arrow/pull/7917#discussion_r467491490 ## File path: rust/parquet/Cargo.toml ## @@ -52,4 +53,4 @@ zstd = "0.5" arrow = { path = "../arrow", version = "2.0.0-SNAPSHOT" } [features] -default =

[GitHub] [arrow] nevi-me commented on a change in pull request #7917: ARROW-8243: [Rust] [Parquet] Serialize Arrow schema metadata

2020-08-08 Thread GitBox
nevi-me commented on a change in pull request #7917: URL: https://github.com/apache/arrow/pull/7917#discussion_r467491183 ## File path: rust/parquet/Cargo.toml ## @@ -40,6 +40,7 @@ zstd = { version = "0.5", optional = true } chrono = "0.4" num-bigint = "0.3" arrow = { path