[GitHub] [arrow] paddyhoran commented on a change in pull request #9602: ARROW-11630: [Rust] Introduce limit option for sort kernel

2021-03-03 Thread GitBox
paddyhoran commented on a change in pull request #9602: URL: https://github.com/apache/arrow/pull/9602#discussion_r586324951 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -278,12 +347,27 @@ fn sort_boolean( let valids_len = valids.len(); let nulls_len =

[GitHub] [arrow] paddyhoran commented on a change in pull request #9602: ARROW-11630: [Rust] Introduce limit option for sort kernel

2021-03-03 Thread GitBox
paddyhoran commented on a change in pull request #9602: URL: https://github.com/apache/arrow/pull/9602#discussion_r586323373 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -278,12 +347,27 @@ fn sort_boolean( let valids_len = valids.len(); let nulls_len =

[GitHub] [arrow] paddyhoran commented on a change in pull request #9602: ARROW-11630: [Rust] Introduce limit option for sort kernel

2021-03-03 Thread GitBox
paddyhoran commented on a change in pull request #9602: URL: https://github.com/apache/arrow/pull/9602#discussion_r586321776 ## File path: rust/arrow/src/compute/kernels/sort.rs ## @@ -517,20 +650,32 @@ where }, ); -if !options.descending { -